Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f53b0b08-3f35-184e-5be4-3143192e3e44@xs4all.nl>
Date:   Tue, 29 Nov 2022 08:34:02 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH] media: platform: Fix missing error code in
 rzg2l_cru_start_streaming_vq()
Content-Language: en-US
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, mchehab@kernel.org
Cc:     p.zabel@pengutronix.de, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
References: <20221129031712.115354-1-jiapeng.chong@linux.alibaba.com>
From:   Hans Verkuil <hverkuil@xs4all.nl>
In-Reply-To: <20221129031712.115354-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Jiapeng Chong,

Please repost with a proper subject line prefix: "media: rzg2l-cru:".

The 'media: platform:' prefix suggests a media/platform-wide patch, not a patch
for a single driver.

Why is this so hard to do?

Regards,

	Hans


On 29/11/2022 04:17, Jiapeng Chong wrote:
> Failed to allocate scratch buffer, add the error code '-ENOMEM' to the
> return value 'ret'.
> 
> drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c:676 rzg2l_cru_start_streaming_vq() warn: missing error code 'ret'.
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3275
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> index 9533e4069ecd..91b57c7c2e56 100644
> --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> @@ -673,6 +673,7 @@ static int rzg2l_cru_start_streaming_vq(struct vb2_queue *vq, unsigned int count
>  	if (!cru->scratch) {
>  		return_unused_buffers(cru, VB2_BUF_STATE_QUEUED);
>  		dev_err(cru->dev, "Failed to allocate scratch buffer\n");
> +		ret = -ENOMEM;
>  		goto free_image_conv_irq;
>  	}
>