Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp460729rwb; Tue, 29 Nov 2022 00:34:55 -0800 (PST) X-Google-Smtp-Source: AA0mqf6gt05k+223M1J/7Fg65knojlaPW8g4iUkzDkdbCCfiDzPJRhYZojWfulnsjI7+2mDmOaTq X-Received: by 2002:a63:e401:0:b0:46f:c183:2437 with SMTP id a1-20020a63e401000000b0046fc1832437mr50148753pgi.613.1669710894941; Tue, 29 Nov 2022 00:34:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669710894; cv=none; d=google.com; s=arc-20160816; b=mNmjiqz16+O7hZbqwHcJhow6NX1rJ0alOmab+vjkQK/STcbqi4J9/EeKiVj5lBdVYJ LvJLRf+Ki3FHh8VJ+eBXkSQiwgZcHR+iEkmRUVNMzp17NdV/5Treuq2JqWEuDD7zLZ+V aSYAa8EW9rfxRcu6NTNPNo3q980tRCVbV0sv0urK8qN4/YcJgc9F5N5+tW/JLInah/4C uGz0F9lKuxtjqwU6Wabcv7jRyxiEVE6G56CDfqiG2FkEXfF7B77KNIylYcRmU3w/BNZf 3l/lckIb4szn+Uasl4PodIOtzt+By+b2NB5koP5nimDUUYsltuLgUK9WG1a/dv0B2/96 GJPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=G49SkX01qChsR5iFJQAizpygDPLV9dh5qLPBaMD/ATw=; b=inT+oIiNtMCuLL7YrwQdaTiRWjrtWwHSQGlxv+qHbasjh6+r9KPymkYsEeXrRlJZYT 3f5bilzvsXDEnSzXq3pzAMbJNESYx8fh8N79Grh8DXZeC0o2WXLdE8cNTo5i6ZdZXBvJ MhxLHVJMsS2qhRbpw2fOuSXnm/NS7iPViKW3XOiSJEYaRBtbIclslFhRcPyNtX0qLX0F 7NceVfnRd3ViVgFMj9TVuhX5BZTmf0KbS2f6EhXe++ZqxCtZF6mUZ3LiOWHjAPkTqZZF FOBas7/bBhlQcMIpeb+WUtHOZZCf8ubjVFxWFEkTh1eBD0GedZI5+MMYrOkBU+JKkY/h kJLA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f14-20020a170902ce8e00b0018659963cdcsi16248308plg.514.2022.11.29.00.34.44; Tue, 29 Nov 2022 00:34:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230146AbiK2IcB (ORCPT + 83 others); Tue, 29 Nov 2022 03:32:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230422AbiK2IbB (ORCPT ); Tue, 29 Nov 2022 03:31:01 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23B7459850; Tue, 29 Nov 2022 00:30:15 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 226C668D06; Tue, 29 Nov 2022 09:30:11 +0100 (CET) Date: Tue, 29 Nov 2022 09:30:10 +0100 From: Christoph Hellwig To: Jinlong Chen Cc: axboe@kernel.dk, hch@lst.de, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] elevator: print none at first in elv_iosched_show even if the queue has a scheduler Message-ID: <20221129083010.GA24762@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 25, 2022 at 11:53:11PM +0800, Jinlong Chen wrote: > This makes the printing order of the io schedulers consistent, and removes > a redundant q->elevator check. Looks good: Reviewed-by: Christoph Hellwig