Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp472054rwb; Tue, 29 Nov 2022 00:47:56 -0800 (PST) X-Google-Smtp-Source: AA0mqf43we1F/c9x3s9LKeVkWFWxYS6QYElEFCSjnjpR5QbFSq+mmFf56hGX4rWpKlPt7oPABwcL X-Received: by 2002:a17:907:8e09:b0:7bc:420d:709f with SMTP id th9-20020a1709078e0900b007bc420d709fmr19153829ejc.658.1669711676296; Tue, 29 Nov 2022 00:47:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669711676; cv=none; d=google.com; s=arc-20160816; b=OclX73aoSwn9xbvMy6Wdg6Av8Prql3DSHWgIiBvpagGKO1r+h7/6Q8Eq/vdJrF2oBk 6f4x1F9UV6C9+WP6+g6Zv916nd2O9hOGOt1ZHLV+HHO3eH65l4GYaNg3aCxPOedsZZQl jeTjUxbSJNRvtvwLnvkGA53m+azr39Wufph9aYdcy3AKfYFPwFD0Ske/mf26vw6CYsLl eJsOSuxB9qh+8KymQJUAIFR9adtMxauhZTKY7YTikYh0Lfbw1Jy0Bwfd4RWgvqqfFpnJ 6RH6P/5mMz3yDNBWEW4g6vTqcl4r03U4fieMy4E5Ww/MrhzH9Pk3DiR/RZ2J9+Zz6OPa H8EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=vonFvT0kAvFGn1OzRSLrlV1NMVGWkHLlZTjMsiqsTf0=; b=CCwq0/OEa7ZPEkK9OOZLEeKIH5c0GUmEoCrwe+VxzhPvzdtYPK7AeQ3wLIp1XigQmU /sVeXjDZAgaD7E23PLtLvblYYhIdpSogYYAxYKlAV5w30GKbTtxHqBk1hbPog0k/brcw vAWTIMBhs652TJZWAh2UIDS1DA8PrkLrUlv0/DIDl7pC4Dl4mIEYpu+pg96KMsq/UGH0 xkvuRoD9sGbhHTfoaxZmZdRnqQruuHPJEy+MokTT7NMEs3k7wax7HwAu/+P+sWgWTe3k vk2OEovDLAGm6212aofMmQRXIls2OTvmy+ebV2yJFvBCi9yHwJARqKyuOrmUuo/Wk8U0 oxyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hb17-20020a170907161100b00781e6ba94ffsi11574377ejc.126.2022.11.29.00.47.36; Tue, 29 Nov 2022 00:47:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231350AbiK2IgN (ORCPT + 83 others); Tue, 29 Nov 2022 03:36:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231133AbiK2Ifc (ORCPT ); Tue, 29 Nov 2022 03:35:32 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07FC819002; Tue, 29 Nov 2022 00:34:12 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 67ACB68AFE; Tue, 29 Nov 2022 09:34:09 +0100 (CET) Date: Tue, 29 Nov 2022 09:34:09 +0100 From: Christoph Hellwig To: Jinlong Chen Cc: axboe@kernel.dk, hch@lst.de, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] elevator: use bool instead of int as the return type of elv_iosched_allow_bio_merge Message-ID: <20221129083409.GD24762@lst.de> References: <1a179a01463c7dbbc1b2be09111ea35617f763a9.1669391142.git.nickyc975@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1a179a01463c7dbbc1b2be09111ea35617f763a9.1669391142.git.nickyc975@zju.edu.cn> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 25, 2022 at 11:53:14PM +0800, Jinlong Chen wrote: > We have bool type now, update the old signature. Looks good, especially as the allow_merge method already returns a bool: Reviewed-by: Christoph Hellwig