Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp511344rwb; Tue, 29 Nov 2022 01:30:48 -0800 (PST) X-Google-Smtp-Source: AA0mqf4mnHC40DDVn+cpEQ7HAnZFewNcYaCAtFTEgFZgGD25rXpLyREh5VdUjMAb9WUhLh6REmZx X-Received: by 2002:a17:903:28f:b0:189:8a36:1b70 with SMTP id j15-20020a170903028f00b001898a361b70mr9840964plr.12.1669714248140; Tue, 29 Nov 2022 01:30:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669714248; cv=none; d=google.com; s=arc-20160816; b=RTUTNy83HHRdZo9HZU/QYmjmueOpVz46yYHmIZ7Cy6zN2eOoiA97PB0hE5tOk3tsal qif39tVhliLyj+LulJlh2Rul5hZH0hlRGE+CBsaX54BvKTdCctUqwa2XWokZs2JD0osW yf3/vo+3uXj70yzEyBfjWN6tjm/81nmrMreEtHw9L5DLd5RGujzyBNa4+Cybbo5k0DFG a9rIsBvDXyPVU0lSd6WYMMiO7e1AViyIVO7PVy1vait2B+iWvMhtjh+5KpuX2qDlCRDu LL+HjYRnyh7AZPEnLEqTjki+VH/6wUbPu7Br4EQzyZ1puGNqcr2eKBzD1EcF9oeLHGpx xeBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=Jc46mAz9NztNx8chRpbm1Vq8QESxVI6TfnUBukgOsYg=; b=YPitTrez/xxI/YGPPTz9UfCjcTLFmv3s5/p1esgikgwlNwdXFTynOyHOj5r5dB6soH Iw5j5xJ/+NKr8eQAAhiO00lvVBu39kwCscJcE0cUPwueh9hBNUgPuMwRFQe6evIvkS4I VRdkkikyn10Z5X3Y6MqRPafIZEiF4rS+YFh9yuF0fu+mOxe/XOZYJaWCLSPjHEZfQzVp DdGJPVEqMNWkx4CteUsEf/W4ZAROyX7Hg9ASsGiORYF5jXts3KyBo3ubtOZpY3U5/ZHx U0NONE1IV2OC1cWmmuQZN6atB0J4YJvZIzZ6cqhkE9bKjLkklXchaWj5PrvfftQQDjsy PVkw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jk24-20020a170903331800b001892c399db0si401688plb.363.2022.11.29.01.30.37; Tue, 29 Nov 2022 01:30:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230509AbiK2If1 (ORCPT + 83 others); Tue, 29 Nov 2022 03:35:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230398AbiK2Ieu (ORCPT ); Tue, 29 Nov 2022 03:34:50 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F610DC9; Tue, 29 Nov 2022 00:33:21 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id B069368AFE; Tue, 29 Nov 2022 09:33:18 +0100 (CET) Date: Tue, 29 Nov 2022 09:33:18 +0100 From: Christoph Hellwig To: Jinlong Chen Cc: axboe@kernel.dk, hch@lst.de, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] elevator: repalce "len+name" with "name+len" in elv_iosched_show Message-ID: <20221129083318.GC24762@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 25, 2022 at 11:53:13PM +0800, Jinlong Chen wrote: > The "pointer + offset" pattern is more resonable. Looks good: Reviewed-by: Christoph Hellwig