Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221126051002.123199-1-linux@weissschuh.net> <20221126051002.123199-2-linux@weissschuh.net>
 <03859890-bf90-4ad0-1926-4b8cb8dbfa57@csgroup.eu> <8f8b12fd-2e25-49e4-a1fa-247f08f56454@t-8ch.de>
 <87r0xoatrg.fsf@mpe.ellerman.id.au>
In-Reply-To: <87r0xoatrg.fsf@mpe.ellerman.id.au>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Tue, 29 Nov 2022 18:34:39 +0900
Message-ID: <CAK7LNATjaVerkr8GFVFQwqGnjC1Jz23E+C5f9+0LTLhX4gNmZA@mail.gmail.com>
Subject: Re: [PATCH 2/3] powerpc/book3e: remove #include <generated/utsrelease.h>
To:     Michael Ellerman <mpe@ellerman.id.au>
Cc:     =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Russ Weight <russell.h.weight@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        Nicholas Piggin <npiggin@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-arch <linux-arch@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Nov 28, 2022 at 7:59 AM Michael Ellerman <mpe@ellerman.id.au> wrote=
:
>
> Thomas Wei=C3=9Fschuh <linux@weissschuh.net> writes:
> > On 2022-11-26 07:36+0000, Christophe Leroy wrote:
> >> Le 26/11/2022 =C3=A0 06:10, Thomas Wei=C3=9Fschuh a =C3=A9crit :
> >>> Commit 7ad4bd887d27 ("powerpc/book3e: get rid of #include <generated/=
compile.h>")
> >>> removed the usage of the define UTS_VERSION but forgot to drop the
> >>> include.
> >>
> >> What about:
> >> arch/powerpc/platforms/52xx/efika.c
> >> arch/powerpc/platforms/amigaone/setup.c
> >> arch/powerpc/platforms/chrp/setup.c
> >> arch/powerpc/platforms/powermac/bootx_init.c
> >>
> >> I believe you can do a lot more than what you did in your series.
> >
> > The commit messages are wrong.
> > They should have said UTS_RELEASE instead of UTS_VERSION.
> >
> > Could the maintainers fix this up when applying?
> > I also changed it locally so it will be fixed for v2.
>
> I'll take this patch, but not the others.
>
> cheers


Okay, I applied 1/3 and 3/3 to the kbuild tree.


--=20
Best Regards
Masahiro Yamada