Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 29 Nov 2022 10:56:11 +0200
From:   Leon Romanovsky <leon@kernel.org>
To:     Wang Yufen <wangyufen@huawei.com>,
        dennis.dalessandro@cornelisnetworks.com
Cc:     bvanassche@acm.org, jgg@ziepe.ca, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org, andriy.shevchenko@linux.intel.com,
        easwar.hariharan@intel.com
Subject: Re: [PATCH v4 1/2] RDMA/hfi1: Fix error return code in
 parse_platform_config()
Message-ID: <Y4XJK1wvpxrIeUS2@unreal>
References: <1669687459-14180-1-git-send-email-wangyufen@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1669687459-14180-1-git-send-email-wangyufen@huawei.com>
Precedence: bulk

On Tue, Nov 29, 2022 at 10:04:18AM +0800, Wang Yufen wrote:
> In the previous while loop, "ret" may be assigned zero, so the error
> return code may be incorrectly set to 0 instead of -EINVAL.
> 
> Fixes: 97167e813415 ("staging/rdma/hfi1: Tune for unknown channel if configuration file is absent")
> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
> ---
>  drivers/infiniband/hw/hfi1/firmware.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 

Thanks, LGTM.

@Dennis?