Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221126051002.123199-1-linux@weissschuh.net> <6dc8ce0d-6587-5f39-d8cc-e4626ebfaf41@intel.com>
In-Reply-To: <6dc8ce0d-6587-5f39-d8cc-e4626ebfaf41@intel.com>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Tue, 29 Nov 2022 18:31:33 +0900
Message-ID: <CAK7LNASzeb5cEkHg8EimFnp02L0Kdcj_=c5GbD12g8JTH+3UqA@mail.gmail.com>
Subject: Re: [PATCH 1/3] firmware_loader: remove #include <generated/utsrelease.h>
To:     Russ Weight <russell.h.weight@intel.com>
Cc:     =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        Michael Ellerman <mpe@ellerman.id.au>,
        Nicholas Piggin <npiggin@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Nov 29, 2022 at 10:18 AM Russ Weight <russell.h.weight@intel.com> w=
rote:
>
>
>
> On 11/25/22 21:09, Thomas Wei=C3=9Fschuh wrote:
> > utsrelease.h is potentially generated on each build.
> > By removing this unused include we can get rid of some spurious
> > recompilations.
> Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> > Signed-off-by: Thomas Wei=C3=9Fschuh <linux@weissschuh.net>
> > ---
> >  drivers/base/firmware_loader/firmware.h | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/base/firmware_loader/firmware.h b/drivers/base/fir=
mware_loader/firmware.h
> > index fe77e91c38a2..bf549d6500d7 100644
> > --- a/drivers/base/firmware_loader/firmware.h
> > +++ b/drivers/base/firmware_loader/firmware.h
> > @@ -9,8 +9,6 @@
> >  #include <linux/list.h>
> >  #include <linux/completion.h>
> >
> > -#include <generated/utsrelease.h>
> > -
> >  /**
> >   * enum fw_opt - options to control firmware loading behaviour
> >   *
> >
> > base-commit: 0b1dcc2cf55ae6523c6fbd0d741b3ac28c9f4536
>

Applied to linux-kbuild.
Thanks.

--=20
Best Regards
Masahiro Yamada