Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <76147056-e937-8e7d-e589-7fabb3c61345@synaptics.com>
Date:   Tue, 29 Nov 2022 18:57:27 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [RFC] drm/fourcc: Add a modifier for contiguous memory
Content-Language: en-US
To:     Daniel Stone <daniel@fooishbar.org>
Cc:     dri-devel@lists.freedesktop.org, ayaka@soulik.info,
        linux-kernel@vger.kernel.org, nicolas@ndufresne.ca,
        hverkuil@xs4all.nl, tzimmermann@suse.de, tfiga@chromium.org,
        linux-media@vger.kernel.org, ppaalanen@gmail.com
References: <20221129101030.57499-1-randy.li@synaptics.com>
 <CAPj87rOiLoGCnOio7=g9wd4auMuwSQV8PesD3Svf=gOWJAzwOg@mail.gmail.com>
From:   Hsia-Jun Li <Randy.Li@synaptics.com>
In-Reply-To: <CAPj87rOiLoGCnOio7=g9wd4auMuwSQV8PesD3Svf=gOWJAzwOg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3MyUGxDVUJqL0EyOGFMVGpQdWdBeEFQZDZiTlRtTTh5cHVvRnpyeUVjeFBm?=
 =?utf-8?B?Y0FwL1VhTHJsWHpVdHA2N1kwUnVvd1NXQ3d0RmlEdDU4MzVQOU53T0dRS3Zj?=
 =?utf-8?B?c0trWDZxZTlSS3lQS0xpSnFWcXhpZWZUUU1kdGdyZkg3OS8ycms0U1QvelJs?=
 =?utf-8?B?eG9WcEQvZUlIWFd3djhWZTJ3UmE4L0QxOTcxRktwMHlDa01yOGxtdnFSMUpj?=
 =?utf-8?B?LzdxdlBzc2cvM2w4ZzhBaHY1R2JVV3lPMnZwd0l1TDA1Qm1HSUR2TWMyQXdp?=
 =?utf-8?B?bWhJMFRVUUYraDlKUWs4VEphQzIvazZpTHBjUlc2SURNdlhsaXc1eTFQU2NG?=
 =?utf-8?B?cHc0VFdPMTU3MHBiZkNFbFY4MFAxQ0JLdU5sNHdvMGgzdndOREVmZmo3QlQ2?=
 =?utf-8?B?WjhHZmE2eGQvNld6VXRRTWEvTGNubHZrNlVSV3g4OGl5Q3ArVk1iRG9NZ0E4?=
 =?utf-8?B?bUM4QmlGdnMwSTBnNXlWdTNDWVNuUHR1ZUh4VzlnSE9DZ2Qva1MyRy9TYW9Y?=
 =?utf-8?B?SXFNSjN0b21CcmZqUTEyaXhtdGxTS1I3SXBGWlZCZ291Zy82UnEyTnpZeHZr?=
 =?utf-8?B?MXRxWVE0eEhTdnpoYTF5N2RMdDdxY1ZFbGthZEhER0ZZcHlnekJTYmw4QmIr?=
 =?utf-8?B?SzN1bURacjhxaFN4VTBnRlFSZ3RacTlvR2F6aE1xeklJRHNDMURVaHVRU3Rj?=
 =?utf-8?B?TFF0SmxRYktNS08rQmdYaXVZa28vZ0ZneWxkSWdUK3Jkb3ZNbHpIVXFrd2xw?=
 =?utf-8?B?bDQzanVqMUovQ1BqaDUrK2hyT0FsbWU5bzBhK2dSdEZKWGVFaTFrandlSlBM?=
 =?utf-8?B?U1VXTmFHRXUvajNUcmZqZFkra0loOHduVm1TYXVoVUcwM0pTOWRoOHF0dld1?=
 =?utf-8?B?RlBvQllUcGFnMHd5aVp6ZERjM3R0a205MzFhMkNXbW5vNnRCYW9BWkE3TEx4?=
 =?utf-8?B?Q3NEWVFZQXdROFBZMDB3Q3pMRkE0WGpVSVY3U1VSMTFBNmE5VXU3UjdpLzQy?=
 =?utf-8?B?ZnB6aVEyZk5TY2Fka0psREZoTllqc1EwZzFKYllzVjlVWTN3dlpJSjM4REN4?=
 =?utf-8?B?WGdmRm12NkJraGJHRzVRMzg3VkVUd2wvSEF1UE85RDNKT0pJME9ZR2E3TGVO?=
 =?utf-8?B?ZkU4Yi82RW14YURCOHlOdTYyR3FHb0tObUI5OCtZeFNScXE0cFZTWU5QS2lz?=
 =?utf-8?B?bXhyU2lKMU4xZW9ZYWc0K21oZmlDdzVmcnc2Nm1pSkdGQ0h2Y2VVd1BMS3Zk?=
 =?utf-8?B?ekw2R0VGWEZvZ095LzZWK1JvNklOLzNxanhmWXh2WTNrdzUwbFJnV0gwL1dN?=
 =?utf-8?B?MisyQ25JZ2EwcXJ4bHdHbmZ4RzlKK2R6cmN2TUE2R2lrK0pGQUViUXgyYUtD?=
 =?utf-8?B?aDRmeGxWek4xUFliUVNjYzBpNFZxV3pZeUl0OGJCU2RkZ1drTy80akRXc0hZ?=
 =?utf-8?B?aXZTaXZ1Rkwva3VDUWNKc0V5RHBrc0FVS05idXFxV3JtMmY5KzVpb0Z3MjJv?=
 =?utf-8?B?M2V2ZHY0L2FFNjhIcklMTTJWeGJVaUZoL0gzTVJ2ZnBxZ2E0eWNxcFpiMyt5?=
 =?utf-8?B?T05FR0IvekRFUlpFQWo1dGd5TldaK2pITVJBdGk2TnNUYzQxYXR4RWcyNFpj?=
 =?utf-8?B?QnovNWgxK1JNQU42Q1RHK2txME9mOTJlMlliNWlSaWZNQ2hJVlc3TWNlaWIx?=
 =?utf-8?B?RHk5SmpWbFI2N0lpeWVoOSszRXZndmllU3g4QmFzd0VGbzluQk53UEVDZ0hm?=
 =?utf-8?B?TnJ2eFhWWklSeFJLRDRuVE1NQ1dhYi8yQkJXSzJjK1pBMm9DUU5Nbm1ZRWpo?=
 =?utf-8?B?ZHlmd3YwamFraDQyMGFkK3R1OFdwVjFFdkdaV0NkYXU4d1NESjJ5MVF1dFZ0?=
 =?utf-8?B?bWlZVjc1clZLaXIrQWN3bnVGQU51MXpJYVc0QzJ4YU9WYkMzNUl6S0Zrd1Nt?=
 =?utf-8?B?ODdCNUFlSzNmV3QwVGZzN2RCSWlWSERMK1h4RzF5Y08rdGt2dWFuMlR5U214?=
 =?utf-8?B?RzAvUE5JbUdHS1JEaUdHL3JEazVLaXdVYWswa0FmY0xnZ2JxK0g5bFlMNElD?=
 =?utf-8?B?NFZKcHdOclM0aFRVdFEzbjVxSVJUemZ4aHpNRWM0M3hwTDJjaXU0Y3dpb000?=
 =?utf-8?Q?Qso6nUw3JKP+PgQqhncQWS9LL?=
X-OriginatorOrg: synaptics.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e358296-7526-410f-b734-08dad1f8855c
X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB5196.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 10:57:34.6511
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 335d1fbc-2124-4173-9863-17e7051a2a0e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6qqjuwYo3XQ+aFjBQFH4EO6HkGGr8qHpK1vGLCJ2KyG31Y24bUdKS/B3ruFiLWtJiSXIu/ZRLwYbDg2/KJyJmw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5578
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/29/22 18:42, Daniel Stone wrote:
> CAUTION: Email originated externally, do not click links or open attachments unless you recognize the sender and know the content is safe.
> 
> 
> Hi Randy,
> 
> On Tue, 29 Nov 2022 at 10:11, Hsia-Jun Li <randy.li@synaptics.com> wrote:
>> Currently, we assume all the pixel formats are multiple planes, devices
>> could support each component has its own memory plane.
>> But that may not apply for any device in the world. We could have a
>> device without IOMMU then this is not impossible.
>>
>> Besides, when we export an handle through the PRIME, the upstream
>> device(likes a capture card or camera) may not support non-contiguous
>> memory. It would be better to allocate the handle in contiguous memory
>> at the first time.
>>
>> We may think the memory allocation is done in user space, we could do
>> the trick there. But the dumb_create() sometimes is not the right API
>> for that.
>>
>> "Note that userspace is not allowed to use such objects for render
>> acceleration - drivers must create their own private ioctls for such a
>> use case."
>> "Note that dumb objects may not be used for gpu acceleration, as has
>> been attempted on some ARM embedded platforms. Such drivers really must
>> have a hardware-specific ioctl to allocate suitable buffer objects."
>>
>> We need to relay on those device custom APIs then. It would be helpful
>> for their library to calculate the right size for contiguous memory. It
>> would be useful for the driver supports rendering dumb buffer as well.
> 
> As a buffer can only have a single modifier, this isn't practical.
Usually only those legacy or low cost devices would request this 
modifier. Unlikely they would support tile format(or we would add 
support for them).

But yes, we would be better not set a trap for us.
> Contiguous needs to be negotiated separately and out of band. See e.g.
> dma-heaps for this.
I don't really like the Android way here. If we are in a world of no 
hot-plug. That would be fine.

V4L2 has had a way to negotiate the memory layout it could support. 
Android gralloc would use the fixed platform sentences to decide the 
memory layout and buffer size. That is not flexible.

So would it be better that I add a common property(a list be the same 
length of the formats property) in drm_plane ?
> 
> Cheers,
> Daniel

-- 
Hsia-Jun(Randy) Li