Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e62a539b-614c-c008-873a-f9c57c7ecb33@digikod.net>
Date:   Tue, 29 Nov 2022 12:03:25 +0100
MIME-Version: 1.0
User-Agent: 
Subject: Re: [PATCH -next] selftests/landlock: Fix selftest ptrace_test run
 fail
Content-Language: en-US
To:     limin <limin100@huawei.com>, shuah@kernel.org,
        linux-kselftest@vger.kernel.org,
        linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev,
        shakeelb@google.com, songmuchun@bytedance.com, tj@kernel.org,
        lizefan.x@bytedance.com
References: <20221128020409.1545717-1-limin100@huawei.com>
 <1232e4f3-e4b8-ff23-61e8-5465c8406f6e@digikod.net>
 <7379a5fd-5593-c6ce-40fd-c543dcf70d2b@huawei.com>
From:   =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= <mic@digikod.net>
In-Reply-To: <7379a5fd-5593-c6ce-40fd-c543dcf70d2b@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

I tested with next-20221116 and all tests are OK. Could you share your 
kernel configuration with a link? What is the content of /proc/cmdline?

On 29/11/2022 02:42, limin wrote:
> I run test on Linux ubuntu2204 6.1.0-next-20221116
> 
> I did't use yama.
> 
> you can reproduce by this step:
> 
> cd kernel_src
> 
> cd tools/testing/selftests/landlock/
> make
> ./ptrace_test
> 
> 
> 
> 
> On 2022/11/29 3:44, Mickaël Salaün wrote:
>> This patch changes the test semantic and then cannot work on my test
>> environment. On which kernel did you run test? Do you use Yama or
>> something similar?
>>
>> On 28/11/2022 03:04, limin wrote:
>>> Tests PTRACE_ATTACH and PTRACE_MODE_READ on the parent,
>>> trace parent return -1 when child== 0
>>> How to reproduce warning:
>>> $ make -C tools/testing/selftests TARGETS=landlock run_tests
>>>
>>> Signed-off-by: limin <limin100@huawei.com>
>>> ---
>>>    tools/testing/selftests/landlock/ptrace_test.c | 5 ++---
>>>    1 file changed, 2 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/tools/testing/selftests/landlock/ptrace_test.c
>>> b/tools/testing/selftests/landlock/ptrace_test.c
>>> index c28ef98ff3ac..88c4dc63eea0 100644
>>> --- a/tools/testing/selftests/landlock/ptrace_test.c
>>> +++ b/tools/testing/selftests/landlock/ptrace_test.c
>>> @@ -267,12 +267,11 @@ TEST_F(hierarchy, trace)
>>>            /* Tests PTRACE_ATTACH and PTRACE_MODE_READ on the parent. */
>>>            err_proc_read = test_ptrace_read(parent);
>>>            ret = ptrace(PTRACE_ATTACH, parent, NULL, 0);
>>> +        EXPECT_EQ(-1, ret);
>>> +        EXPECT_EQ(EPERM, errno);
>>>            if (variant->domain_child) {
>>> -            EXPECT_EQ(-1, ret);
>>> -            EXPECT_EQ(EPERM, errno);
>>>                EXPECT_EQ(EACCES, err_proc_read);
>>>            } else {
>>> -            EXPECT_EQ(0, ret);
>>>                EXPECT_EQ(0, err_proc_read);
>>>            }
>>>            if (ret == 0) {