Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 29 Nov 2022 20:50:19 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     Vlastimil Babka <vbabka@suse.cz>
CC:     Marco Elver <elver@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Oliver Glitta <glittao@gmail.com>,
        Christoph Lameter <cl@linux.com>,
        "Pekka Enberg" <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        "Joonsoo Kim" <iamjoonsoo.kim@lge.com>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Hyeonggon Yoo <42.hyeyoo@gmail.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] mm/slub, kunit: Add a test case for kmalloc
 redzone check
Message-ID: <Y4YAC9UTxQLg4Y5q@feng-clx>
References: <20221129063358.3012362-1-feng.tang@intel.com>
 <20221129063358.3012362-2-feng.tang@intel.com>
 <CANpmjNNkLWvNYUf-bPPDBcqFWegp3_NpYdhygvYU1dtT52m29g@mail.gmail.com>
 <67e6ebce-f8cc-7d28-5e85-8a3909c2d180@suse.cz>
 <CANpmjNNZhXX830jqPn9eaQZHwKhBb4b_PEuUdH6O69ELqW470w@mail.gmail.com>
 <d6c614fe-cc80-7a19-1fa6-2ed6cc75b705@suse.cz>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <d6c614fe-cc80-7a19-1fa6-2ed6cc75b705@suse.cz>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BHbuWu4HuGDFFaprBKda3t2Gwd9TZHgITwISsX5G3RpPSwL2eGc6Nj1ccqqe?=
 =?us-ascii?Q?yLTw0CF61dbyH1p8BH5p+SG8iPuqkKNitGAt+qo3wf+9+U5GD8KukO/NZx5e?=
 =?us-ascii?Q?GTC2rx7AcpT5q7E8v1J1sd2vm0iMtjgLGRSG2pCQL1HG6PmRycFiS5WGlfKS?=
 =?us-ascii?Q?krmTdE3I8b53ESeowblcJbnT5nj68gciYzPezzTUzy0/NTnI13YGLA9P8xj8?=
 =?us-ascii?Q?C6U7WC4N1OZa11E86ZM1Tw0OJ+91IMnDWfu8bTofxrg1KcJXEhoejV+H94/d?=
 =?us-ascii?Q?wS99c2WAQ7tTR69cVhgXgfPvhdzPS7H3aKs5jc6L2udSNleMbT7B7xZWqRiY?=
 =?us-ascii?Q?tZ3yOTvz+J2zSw5V0CKUTggXi0AxjaJPFxee5IrkipKNYa415AdYdpU+mees?=
 =?us-ascii?Q?aAH9K4yXYvgKYCpZx3E7yI8XwCUWfHWYsmZb2jRHC2ijoJsZjn03wF+6v4+d?=
 =?us-ascii?Q?zYMpV/HdEbNKvXM5Z173FIJ2XS6g37cKHhajnKGB6KbmhNyGJ3x4I8TNkS0H?=
 =?us-ascii?Q?8a+9ismWpxuAJbHOLoQwxvsyzReXcIP2yBgqwXfseBXzeHxt8F+sMAko2qaT?=
 =?us-ascii?Q?y7xh2FdkZChcd5vpRibqVj69izh9+RuR3+Qrp023sUgIzOpzbZ70qlD6mBNw?=
 =?us-ascii?Q?TWFkyIGqHiQz98HUAlQIKJgqSiGG/HvNTsOjtbQtWcjJ2y+Jxyj4/VHCmddw?=
 =?us-ascii?Q?FjaW1KpBYUdWUYXzIeveXSO/UzkcUxOvIa77PjJKjmi0EIJXTnYIjkVuGir9?=
 =?us-ascii?Q?9elK9xyYuWaym0oKePFTBXguuNROiKx0PsbyRE0x1GOtd3jS5VTiqZYSkSHn?=
 =?us-ascii?Q?HONm/YWslyM7bZQeK/BBiNMOg/mJksqsCuwqZ5fEKGR+0jtrygozY5PrCN1e?=
 =?us-ascii?Q?lTYnYcnP56XaAvvRKS0HxswNhwqP+nBs5dpbqgBBID1fbVBbjgbzqgVosaFu?=
 =?us-ascii?Q?SEq4nxWI3QtoFat+E+GFHjX6tqO1XLawc2kw4r9ub9/nYfRK+pU0oLPb8B4y?=
 =?us-ascii?Q?vIJqUhPafgVYTgirdSKgbztRUB4UBKUYKxN0/p/+/TSUBBYgGu4RrHgzlCsv?=
 =?us-ascii?Q?mFjTOsz87M1JkdHgnftDuUb74hN0w3kmkaymRvw5/wYDyjG/gA/UE12FtPEx?=
 =?us-ascii?Q?1wAeGfYavyYCYWHByPStbgUJb+EatUA5g4xePCKBks0v/3Wsc+21wM6+GZPw?=
 =?us-ascii?Q?XDBuNYoDMcad7M95RJqL43+M4W5UXjbZ6TWPQhWWcV7ROnCE1nqMo3b8Mcgw?=
 =?us-ascii?Q?6w2K5uulOg8QLHIZYHkuSeTyyrxurgQ+AV0zHFag6ih383p+OFogt2zvgad5?=
 =?us-ascii?Q?eqB+wwTpbKc38UO9ynYIqn9Dq4BNhgbHQTfeAfj3Zhr55XLxpz1WFe/HDLS/?=
 =?us-ascii?Q?Ggr2aHKZaMfWwZr/dowhLlX1yxnz10wf1Hu1uvY1rK7FxeIJlnbLCWCiRsuK?=
 =?us-ascii?Q?laz+zkU6DrIByV1+Mx1mQrzWvRoWC/YtK/BOhDcxGjV1mpAJoYp6pjyGItNl?=
 =?us-ascii?Q?9/W60dULMssTQxyLpJUycAUI27BksVWfDMIXafX/Mj+qaJKwyL16kd3r2bQQ?=
 =?us-ascii?Q?c8BlHs0pQsWjCsC8NCpdIhfxwmK9s4aaH9DjD8lU?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0df8372b-3995-4cc0-ddc9-08dad208b436
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 12:53:25.3443
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kmDlurGSzaLK1XMKbhL38OOu7OtplDDIJfbrP0TUVqmwWLYDjT7QjG64vn1sKgnkac6N1vFi9B8Vzj4+CzRXOA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6151
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 29, 2022 at 08:02:51PM +0800, Vlastimil Babka wrote:
> On 11/29/22 12:48, Marco Elver wrote:
> > On Tue, 29 Nov 2022 at 12:01, Vlastimil Babka <vbabka@suse.cz> wrote:
> >>
> >> On 11/29/22 10:31, Marco Elver wrote:
> >> > On Tue, 29 Nov 2022 at 07:37, Feng Tang <feng.tang@intel.com> wrote:
> > 
> >> For SLAB_SKIP_KFENCE, we could also add the flag after creation to avoid
> >> this trouble? After all there is a sysfs file to control it at runtime
> >> anyway (via skip_kfence_store()).
> >> In that case patch 1 would have to wrap kmem_cache_create() and the flag
> >> addition with a new function to avoid repeating. That function could also be
> >> adding SLAB_NO_USER_FLAGS to kmem_cache_create(), instead of the #define
> >> DEFAULT_FLAGS.
> > 
> > I wouldn't overcomplicate it, all we need is a way to say "this flag
> > should not be used directly" - and only have it available via an
> > indirect step. Availability via sysfs is one such step.
> > 
> > And for tests, there are 2 options:
> > 
> > 1. we could provide a function "kmem_cache_set_test_flags(cache,
> > gfp_flags)" and define SLAB_TEST_FLAGS (which would include
> > SLAB_SKIP_KFENCE). This still allows to set it generally, but should
> > make abuse less likely due to the "test" in the name of that function.
> > 
> > 2. just set it directly, s->flags |= SLAB_SKIP_KFENCE.
> > 
> > If you're fine with #2, that seems simplest and would be my preference.
> 
> Yeah, that's what I meant. But slub_kunit.c could still have own internal
> cache creation function so the "|SLAB_NO_USER_FLAGS" and "s->flags |=
> SLAB_SKIP_KFENCE" is not repeated X times.

I just quickly tried adding a new wrapper, like 

  struct kmem_cache *debug_kmem_cache_create(const char *name, unsigned int size,
			unsigned int align, slab_flags_t flags,
			void (*ctor)(void *), slab_flags_t debug_flags);

and found that, IIUC, both SLAB_KMALLOC and SLAB_NO_USER are creation
time flag, while SLAB_SKIP_KFENCE is an allocation runtime flag which
could be set after creation. 

So how about use the initial suggestion from Vlastimil to set the
SKIP_KFENCE flag through an internal wrapper in slub_kunit.c?

	/* Only for debug and test use, to skip kfence allocation */
	static inline void kmem_cache_skip_kfence(struct kmem_cache *s)
	{
		s->flags |= SLAB_SKIP_KFENCE; 
	}

Thanks,
Feng

> > 
> >> For SLAB_KMALLOC there's probably no such way unless we abuse the internal
> >> APIs even more and call e.g. create_boot_cache() instead of
> >> kmem_cache_create(). But that one is __init, so probably not. If we do
> >> instead allow the flag, I wouldn't add it to SLAB_CORE_FLAGS but rather
> >> SLAB_CACHE_FLAGS and SLAB_FLAGS_PERMITTED.
> > 
> > I'd probably go with the simplest solution here.
> 
> Agreed.