Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fdbc3c12-71c8-16da-6b69-eb235964fcd7@datenfreihafen.org>
Date:   Tue, 29 Nov 2022 15:01:01 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH] ieee802154: cc2520: Fix error return code in
 cc2520_hw_init()
Content-Language: en-US
To:     Ziyang Xuan <william.xuanziyang@huawei.com>,
        varkabhadram@gmail.com, alex.aring@gmail.com, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        linux-wpan@vger.kernel.org, netdev@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org
References: <20221120075046.2213633-1-william.xuanziyang@huawei.com>
From:   Stefan Schmidt <stefan@datenfreihafen.org>
In-Reply-To: <20221120075046.2213633-1-william.xuanziyang@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello.

On 20.11.22 08:50, Ziyang Xuan wrote:
> In cc2520_hw_init(), if oscillator start failed, the error code
> should be returned.
> 
> Fixes: 0da6bc8cc341 ("ieee802154: cc2520: adds driver for TI CC2520 radio")
> Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com>
> ---
>   drivers/net/ieee802154/cc2520.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
> index c69b87d3837d..edc769daad07 100644
> --- a/drivers/net/ieee802154/cc2520.c
> +++ b/drivers/net/ieee802154/cc2520.c
> @@ -970,7 +970,7 @@ static int cc2520_hw_init(struct cc2520_private *priv)
>   
>   		if (timeout-- <= 0) {
>   			dev_err(&priv->spi->dev, "oscillator start failed!\n");
> -			return ret;
> +			return -ETIMEDOUT;
>   		}
>   		udelay(1);
>   	} while (!(status & CC2520_STATUS_XOSC32M_STABLE));

This patch has been applied to the wpan tree and will be
part of the next pull request to net. Thanks!

regards
Stefan Schmidt