Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp889414rwb; Tue, 29 Nov 2022 06:36:47 -0800 (PST) X-Google-Smtp-Source: AA0mqf6EdmpTZjac7NqY6lFZelRx2p7lcHKgDBRecgyFWjNxH1duTPM3917KvrGBB+/VtggoynzE X-Received: by 2002:a17:902:a503:b0:188:6baf:2011 with SMTP id s3-20020a170902a50300b001886baf2011mr35838155plq.165.1669732607267; Tue, 29 Nov 2022 06:36:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669732607; cv=none; d=google.com; s=arc-20160816; b=xFUpL0BvcXOmx1waCbVGQxfnKshme7QhBaWcQ3SYUTIAxwPYXrcAO5thErtklLycSo A9ErNf+ijWBKFg4hqtgf7HMwqs1TIYrc6nlfCXzrKUvIRqNQecxSnVFdIeE1ouV2/1q9 sX0wI3ajWb5jVD1Dh8L0xGaao04oGY1ey7zeqXC87ir8+p9EsW5M+RWXQs8Du4nvGBs4 X644JrBOl0Q6JzJmQT4vGxx0kS+mM4yMnh2wZICI0A3xuwPNhAN6YSzQbA545/cloZvp zM6Pa5OtCg9zfCKMknBD+nIDJMTrC/+zyAk+c9j1f4W7jJcJwJCqPiWUKKKtt6uzKM6u UflQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Ylwb4KCyca+jQJTbdW1raeSgIDIZEx3eWo3k4sH/7JI=; b=KtPYHjFDXoUZ/I7uh/fvJQaR/P1BI900UIZbtgPDrHQdhiaF9+6qzbuz7dTvotCHkK 9GwKDKC2NOWEEmtx6vviU24Vc1NYi7XP/VSS7M+QCKHoY7BR2UtqOQ+HXg8g/6H0d8n3 JNy9hr9dAzAUJL4/dJuwPYuTKYPba3/zzzgD5am8oSDR39LZQViA2w0eLn/oRUT3dr96 JGeCmEcX5orQqBEdkMGEXi8WXCEdDBN7grfgGx2Ra8DzAkOTUQfnZmbfJcOAKjGYA73b 9xORN2p4LQW1gwsjRdBaq1C/6hevZqDlPVfQ0/LmHh/taNTfRhKLQSHljtdMFENSnUXK dsJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=3jmd+PnW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z17-20020a631911000000b00434dd6f6e21si15725094pgl.125.2022.11.29.06.36.36; Tue, 29 Nov 2022 06:36:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=3jmd+PnW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234692AbiK2OZZ (ORCPT + 84 others); Tue, 29 Nov 2022 09:25:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235019AbiK2OZK (ORCPT ); Tue, 29 Nov 2022 09:25:10 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 729BA2E2; Tue, 29 Nov 2022 06:25:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Ylwb4KCyca+jQJTbdW1raeSgIDIZEx3eWo3k4sH/7JI=; b=3jmd+PnWA2cHklZWXfXzE0YLxH P3Qt4u6ALN3HizAKCzkKmK+ufSt2091ZZsysN0o2kJLAqo3XpNU2hwD7duqzqdxKIqAIzG9/RkBPD 0Nnpmd+8H+4zmuJwASUo2kjImy4VUZWKOM/rm2L8qseuxQquU+nZO2UOK50cVrck1PB46bjUHh2QP N2HHuOoWwcjpyBlGF0e540qKOr2VCwI4ImwR7szrlu3r7zK/+Q2SeBiYZE6ElUKqlJW56amItAyTU 0F+vRxS/uoyh8RxMT3RDNXS/iKOZehuAXnPGMGJPTXgFJNhtQD7GoUwfe1jUXkgw7GyqJlANg09FF yLvUY30Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p01Xl-009Dk7-Af; Tue, 29 Nov 2022 14:25:05 +0000 Date: Tue, 29 Nov 2022 06:25:05 -0800 From: Christoph Hellwig To: Li Nan Cc: tj@kernel.org, josef@toxicpanda.com, axboe@kernel.dk, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com Subject: Re: [PATCH -next 8/8] block: fix null-pointer dereference in ioc_pd_init Message-ID: References: <20221128154434.4177442-1-linan122@huawei.com> <20221128154434.4177442-9-linan122@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221128154434.4177442-9-linan122@huawei.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 28, 2022 at 11:44:34PM +0800, Li Nan wrote: > Fix problem by moving rq_qos_exit() to disk_release(). No, that now means it is removed to later. You need to add proper synchronization.