Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "G, GurucharanX" <gurucharanx.g@intel.com>
To:     Akihiko Odaki <akihiko.odaki@daynix.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Yuri Benditovich" <yuri.benditovich@daynix.com>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Yan Vugenfirer <yan@daynix.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S. Miller" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH net v4] igb: Allocate MSI-X vector when
 testing
Thread-Topic: [Intel-wired-lan] [PATCH net v4] igb: Allocate MSI-X vector when
 testing
Thread-Index: AQHZANI65tHc8YIWGUO076whpgIGrK5V/1Nw
Date:   Tue, 29 Nov 2022 14:41:02 +0000
Message-ID: <BYAPR11MB336772D78CBD1F38C8054636FC129@BYAPR11MB3367.namprd11.prod.outlook.com>
References: <20221125133031.46845-1-akihiko.odaki@daynix.com>
In-Reply-To: <20221125133031.46845-1-akihiko.odaki@daynix.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LWttWkPrTwKoCpzoOydKaBURjzlzCAbFWe6sFp7thQgN4PWcGhEP3YoctK6P?=
 =?us-ascii?Q?xebrn3yOADgKWl0D169N9d6HMAHGZaPUqUcJGcJRhhPM7+uS7Wx4GoGy+9V4?=
 =?us-ascii?Q?CxJbszBlRWql1diBLbfdKUyGM/zE8LKhhZmrGCm3r5UIN1F3GyRKL/KHFFlF?=
 =?us-ascii?Q?8BL49KFqpReCS8OFW323iEzogCm92awx+Gh38xqaXclEknuz3JB1qN+kjCkC?=
 =?us-ascii?Q?BEt3kfgbvuxjW+lqZoKoW+S/rvvkrTRA/ZfSyZq/441OOTuTOs/g5UjggiR6?=
 =?us-ascii?Q?zv1PeXkDCGAKte9h6viUKV9rrlqRWocW4fyVMpjxOshgCDxTqBwiupnAx71Z?=
 =?us-ascii?Q?pV+ozurn5Xsxyw2aZgxzozwzFCuLxRduL6hu+XoxxT80QJECKu0WFger9iNL?=
 =?us-ascii?Q?p1wadBpPbmQMamNCA8Sh0FBUNyiWtaO5nVbexPhZHt5HdruUKBJHSJhnZYP/?=
 =?us-ascii?Q?i+VFre9Qg38XodzO11ONSN4V6gbiQjxESFWrXkGGrWFrdhHXafImUbINjWSg?=
 =?us-ascii?Q?g7QvK0lcDYSn83e1zALN/07NgA0Qbi0NZrZFwac3Ly11/tpUL6qgbOvcs30R?=
 =?us-ascii?Q?94paaNOBK8mxjwS73pp2X8txjp2ZPyIZ0UCKQFUmT3zNiu4Df2DzJep3WuKy?=
 =?us-ascii?Q?fbr4GGJdWForGVRRnBHRqWYQerQlo5vudCQgvExRTCiWUh2jDZGRGiRcahKQ?=
 =?us-ascii?Q?NX4iOouRrBn+Pn/NS7kmPUr4uzc6qqyDQq9lGwrzRAQDsLtOSIV5NiA0gqya?=
 =?us-ascii?Q?WPCFHIdMGuvXxTLnhMlfWW/osnA5AvY6gi692Diroiil+h3KxLLUG9VQmKQX?=
 =?us-ascii?Q?qlWSKJG5nQC/knnYx7S6hU6Qwiq5sV3o8EwB7QM8vPuvOOF3MyCoiI8HM/eN?=
 =?us-ascii?Q?HocAoYMtdb2KhuhUOz0u1VAn705DVFLC/UATt95fVtgu1KNhbAoYzpWXPqXa?=
 =?us-ascii?Q?QgqVJApvJrPCxBNdQaVZH9q1lMLiLmryumb+GvDkM9j0MLAkx1LzXg+DQCy+?=
 =?us-ascii?Q?5VfS6CR31WHzDtDziyWwF2D+NdS8HrKtb8at4FK9SHdc0fz5MlXBGS7pu+Rk?=
 =?us-ascii?Q?h5Ec7pN6WL06PZ+9IuSp+qILBWxKi6BkcKxWLBzeJz3CNrMgs260wEB3W/mk?=
 =?us-ascii?Q?IkSmPGQIFzyxGOpo7X0JRWTKN+8gau7t9MHf5jSwKEsL4YG43KlLGdSvIjTI?=
 =?us-ascii?Q?rM8C+oHUJi+5bOQ69S72dIwtBpyyvwtRnZADeQaapu8HXcXjFhzfCfh+7MrB?=
 =?us-ascii?Q?IkEBHceiZ2st4FABbYqMRHvKetD6tT/6Rz1rGE0ENmRIUn4ql6He0sfteWrC?=
 =?us-ascii?Q?srpayMMuqJpO5k7NV+Te5xr7Ogalbzq3Ouyw72ffMIZquDroxGkc0eMWu6ii?=
 =?us-ascii?Q?DphXJlEuhuM98Wg1tRsjxSbpPA9LKeoX4kiqF0ZA97hORatbJJsuvP7ySDMF?=
 =?us-ascii?Q?/z0esHMIy+zokUCzpq9X88m3RWDRxGUQ77FwL0Su6s4ToGFz99AIYfZyvi+m?=
 =?us-ascii?Q?G94NMCAQaVjjFAwih62utUCauPD9uqJZNKwm9VFO3TSrht5LOzbMmTWGpCjm?=
 =?us-ascii?Q?DS4cFckTG+zpJdixCZ/X7ZqwqnMbpr3fqzBjrl6K?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3367.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 30e2224e-c6c0-42c9-e3ed-08dad217bd15
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2022 14:41:02.4599
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: a5vXraSo2u0vqMTc9qvGdJk+X86J7wym8E6vite7ZNmMxZaNp4NhjMKF14Etp3eyW9CGBt+BBrMQDnWAKpSjhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6115
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Akihiko Odaki
> Sent: Friday, November 25, 2022 7:01 PM
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Yuri Benditovic=
h
> <yuri.benditovich@daynix.com>; Eric Dumazet <edumazet@google.com>;
> Jakub Kicinski <kuba@kernel.org>; Yan Vugenfirer <yan@daynix.com>; intel-
> wired-lan@lists.osuosl.org; Paolo Abeni <pabeni@redhat.com>; David S.
> Miller <davem@davemloft.net>
> Subject: [Intel-wired-lan] [PATCH net v4] igb: Allocate MSI-X vector when
> testing
>=20
> Without this change, the interrupt test fail with MSI-X environment:
>=20
> $ sudo ethtool -t enp0s2 offline
> [   43.921783] igb 0000:00:02.0: offline testing starting
> [   44.855824] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Down
> [   44.961249] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Up 1000 M=
bps
> Full Duplex, Flow Control: RX/TX
> [   51.272202] igb 0000:00:02.0: testing shared interrupt
> [   56.996975] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Up 1000 M=
bps
> Full Duplex, Flow Control: RX/TX
> The test result is FAIL
> The test extra info:
> Register test  (offline)	 0
> Eeprom test    (offline)	 0
> Interrupt test (offline)	 4
> Loopback test  (offline)	 0
> Link test   (on/offline)	 0
>=20
> Here, "4" means an expected interrupt was not delivered.
>=20
> To fix this, route IRQs correctly to the first MSI-X vector by setting
> IVAR_MISC. Also, set bit 0 of EIMS so that the vector will not be masked.=
 The
> interrupt test now runs properly with this change:
>=20
> $ sudo ethtool -t enp0s2 offline
> [   42.762985] igb 0000:00:02.0: offline testing starting
> [   50.141967] igb 0000:00:02.0: testing shared interrupt
> [   56.163957] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Up 1000 M=
bps
> Full Duplex, Flow Control: RX/TX
> The test result is PASS
> The test extra info:
> Register test  (offline)	 0
> Eeprom test    (offline)	 0
> Interrupt test (offline)	 0
> Loopback test  (offline)	 0
> Link test   (on/offline)	 0
>=20
> Fixes: 4eefa8f01314 ("igb: add single vector msi-x testing to interrupt t=
est")
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> V3 -> V4: Added Fixes: tag
>=20
>  drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20

Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at I=
ntel)