Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 29 Nov 2022 09:56:20 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Andrew Yang <andrew.yang@mediatek.com>
Cc:     Masami Hiramatsu <mhiramat@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Casper Li <casper.li@mediatek.com>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH] mm/writeback: fix dereferencing NULL mapping->host
Message-ID: <20221129095620.4c1a8056@gandalf.local.home>
In-Reply-To: <20221129033304.4465-1-andrew.yang@mediatek.com>
References: <20221129033304.4465-1-andrew.yang@mediatek.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 29 Nov 2022 11:32:59 +0800
Andrew Yang <andrew.yang@mediatek.com> wrote:

> From: "andrew.yang" <andrew.yang@mediatek.com>
> 
> Check before dereferencing mapping->host
> 
> Signed-off-by: andrew.yang <andrew.yang@mediatek.com>
> ---
>  include/trace/events/writeback.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h
> index 86b2a82da546..56f6e114d3ed 100644
> --- a/include/trace/events/writeback.h
> +++ b/include/trace/events/writeback.h
> @@ -68,7 +68,7 @@ DECLARE_EVENT_CLASS(writeback_folio_template,
>  		strscpy_pad(__entry->name,
>  			    bdi_dev_name(mapping ? inode_to_bdi(mapping->host) :
>  					 NULL), 32);
> -		__entry->ino = mapping ? mapping->host->i_ino : 0;
> +		__entry->ino = mapping && mapping->host ? mapping->host->i_ino : 0;

I hate remembering precedence. Can we add parenthesis around this to be
clear?

		__entry->ino = (mapping && mapping->host) ? mapping->host->i_ino : 0;

Thanks,

-- Steve


>  		__entry->index = folio->index;
>  	),
>