Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1009866rwb; Tue, 29 Nov 2022 07:57:56 -0800 (PST) X-Google-Smtp-Source: AA0mqf4hO6brhC7xWFtsM4uSy+/IzpV0/aaiC9p0FjHWnJhuMdz/5iwRxpn6ltEoSWSkdxr7QHE/ X-Received: by 2002:a17:90a:9488:b0:218:bfa3:3dd3 with SMTP id s8-20020a17090a948800b00218bfa33dd3mr41218084pjo.135.1669737475829; Tue, 29 Nov 2022 07:57:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669737475; cv=none; d=google.com; s=arc-20160816; b=WEx/ctt9fY5gUDNr1a9vJH9GYvQS66bcmX52W6FuciwhRgJtaWQ6DPtM072Pkevb2Z nN4GyGl7XnOaeQPm/n5847uDTbz65Y7b9d1uM6jlEoDLS6CK72xF5ugtUUMeVPtvmLcq rPao53Yw0BNpOzt5JKo2KToCGwH1GjJUibd8V+/+XibcZPsJu1cqXmiIfKK9kbYkfj7F DN8wMg6bjfDOnEOA+Mv8bamuseSyK30LAxfk1DuBQ8vhe4lCFYIZwkqF9ScnhJ00be6D U4YLuGOnz++h3R8bIwp51ZnBZbc6AFVWVReqAT0mr6j1/qUBpZiQO8lX9wQanQ5fEBAc O3Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=PKhOOvtlfb2qi0t8kP3a+apl+9/7kIQvBSOWJ9+Wfec=; b=wS8S01f0vgcFR2Qb8nia8Rg6EbQ6wVNKHGDhrwWbSm3j4ZD8w4j3YqeN0477My0gXT BGb4Uai6D70vrKk0XeAwAOKIgEZv0+Rqju7BA81tHRv+fJZa0S7Yf8y9qsriV9K6t0UL AcAR+BWhhQY0wooPCe8iIVaSp9MivOb4W20X4Ng+UqyBDSmV0NVimLTxNcU/wOwLUGrM Zl+xQxdYRIIJRI5aYIYtoQ15kwSRdDK9nu0Mau4SY7z62rdtz5hplBYAWfSqJ3ebWEVo zodBGbOp159VqtR9DPMJoYbo2BLSVcuuKGoROWhS0kPMMBaopfmTCNR3Q8vnsxrl91/t IA9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j3-20020a635943000000b00458ae7b0a24si14688198pgm.208.2022.11.29.07.57.44; Tue, 29 Nov 2022 07:57:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235999AbiK2PrN (ORCPT + 84 others); Tue, 29 Nov 2022 10:47:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235961AbiK2PrA (ORCPT ); Tue, 29 Nov 2022 10:47:00 -0500 Received: from zju.edu.cn (mail.zju.edu.cn [61.164.42.155]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 376816315A; Tue, 29 Nov 2022 07:46:59 -0800 (PST) Received: from localhost.localdomain (unknown [10.14.30.50]) by mail-app4 (Coremail) with SMTP id cS_KCgBnaMxfKYZjT2esCA--.15899S4; Tue, 29 Nov 2022 23:46:56 +0800 (CST) From: Jinlong Chen To: axboe@kernel.dk Cc: hch@lst.de, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, nickyc975@zju.edu.cn Subject: [PATCH v2 2/5] elevator: replace continue with else-if in elv_iosched_show Date: Tue, 29 Nov 2022 23:46:35 +0800 Message-Id: <77ac19ba556efd2c8639a6396eb4203c59bc13d6.1669736350.git.nickyc975@zju.edu.cn> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: cS_KCgBnaMxfKYZjT2esCA--.15899S4 X-Coremail-Antispam: 1UD129KBjvdXoWrtr48XryrAr18ArWrur4UJwb_yoW3AFb_Ka s5Xwn7J345Jr9Ikr1jvFn5tFWjvwn3Jr15Kwnrtr97ta90gFyfA3Wxua45JryDWFWUu3s8 Cw1DZFn7CryxKjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbIAFc2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wAFIxvE14AK wVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20x vE14v26w1j6s0DM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4UJVW0owA2z4x0Y4vEx4A2 jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oVCq3wAac4AC62xK8xCEY4 vEwIxC4wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv 7VC0I7IYx2IY67AKxVWUGVWUXwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r 1j6r4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCF04k20xvY0x0E wIxGrwCF04k20xvE74AGY7Cv6cx26r4fKr1UJr1l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2 IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v2 6r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2 IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv 67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyT uYvjfUFYFADUUUU X-CM-SenderInfo: qssqjiaqqzq6lmxovvfxof0/1tbiAgIJB1ZdtcpCQAAFs9 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org else-if is more readable than continue here. Signed-off-by: Jinlong Chen --- block/elevator.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/block/elevator.c b/block/elevator.c index 308bee253564..ffa750976d25 100644 --- a/block/elevator.c +++ b/block/elevator.c @@ -776,11 +776,9 @@ ssize_t elv_iosched_show(struct request_queue *q, char *name) spin_lock(&elv_list_lock); list_for_each_entry(e, &elv_list, list) { - if (e == cur) { + if (e == cur) len += sprintf(name+len, "[%s] ", cur->elevator_name); - continue; - } - if (elv_support_features(q, e)) + else if (elv_support_features(q, e)) len += sprintf(name+len, "%s ", e->elevator_name); } spin_unlock(&elv_list_lock); -- 2.34.1