Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1010198rwb; Tue, 29 Nov 2022 07:58:11 -0800 (PST) X-Google-Smtp-Source: AA0mqf7EAp9gWPwreCvW042XEjz0Nsl5dM2MaX2LsXs75D7A/NLPWW4BNh6m87st/Og6As7jGgcI X-Received: by 2002:a65:4584:0:b0:478:50ca:cdf2 with SMTP id o4-20020a654584000000b0047850cacdf2mr1562932pgq.200.1669737491622; Tue, 29 Nov 2022 07:58:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669737491; cv=none; d=google.com; s=arc-20160816; b=fFxK/gYF6NUTZJIBsXQ1JQ0a74af2cf9g90IwKyVJSbATRGJWlXtnW7qngeEfsafV5 FchI8A0nDONz1XvZnzpLbyquZIKj+8EzNYjZ3gqK655gggnGIzU6vgTf6Br9VEaX4tlF 7uW4MiKhJHTualde8aNngGPjORJNmkGAngU/vS/OzWAJccPdmZmtPSQlR8wzv5iofIbM O33JF0eYxlocHf+zgZlsj1d2RzpT0d9qsbX5vfFazKjdsS5uh29K3lFUaYZAPxLeC7R3 htTMKXRxpOPfYdx4DQVogN4oSrtw32Vudfi5x3WfXt4pbe98i2MQc/9PatkwVKQGocVs Xy8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=J7z0fW8hLsUUROVz4grCU3pT+TK3DyH/QCKd43+KL78=; b=fxw/mRorevaPIabviJIgmXZEwQKsgkpCL/V0pTqTMhoDMT8oh8CwkVotOiCvc/dHb+ f3YQmEjqRGX4/foS4LwN++zx5fa+HZwK8VQENWADLhw7h5otTjNH2OQl2GBd4hVZld02 sbkH0B6fxlmaSejbemfA4dp23WlxJfzlFFvs6gtwH98RpN9DVxS8ZC3CrsGOQyXfDBON HziWVWIqjvRQVmfiOTDKBHeb6rGEUb0vSscIKwjohNz2uSx7eX99bJnaEfFV3vci96jM KvuIH3iRKzcBKnSV0FzgQaWYOYwgyYPGNjdh60kXqQV8k50i3Kt3wehYFGDIp0Ol9NI9 W5Ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=oRMCZegN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z21-20020a17090ad79500b0021942473a5fsi1870483pju.122.2022.11.29.07.58.00; Tue, 29 Nov 2022 07:58:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=oRMCZegN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233743AbiK2PJG (ORCPT + 84 others); Tue, 29 Nov 2022 10:09:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229693AbiK2PJE (ORCPT ); Tue, 29 Nov 2022 10:09:04 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36582286F1 for ; Tue, 29 Nov 2022 07:09:04 -0800 (PST) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id DC0ED660165C; Tue, 29 Nov 2022 15:09:01 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1669734542; bh=dcuFXuyUO4u2FBDicBX43KEncCSh9cUMs/11eeCUzvE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=oRMCZegNrpohvspElhK3dFjkl2MLJhdHERN+KOOENUn1PFF53MgBppv674WTAuEvx QDA+e6aiZoab1UgigopWThqHrLYkmK8Gno5V3KfTGMN3zyx0A5tp9L/+GgU0YxYZCF bJNf9Hv58eG07SYbbSrTI5/3aNIPc2Fr6EvyVg9wvQJh3Mc9bKGMooE5vzkaiYxPd+ p331lpCfejTFCnrLV/4zrm7z74g4EkiClCwmTHBhNsmtTTYgwF99uAv5EzEdsvE7ur nW1qe0FzC6GZPmZz0nFmeDEskx9aq/fsSHI/q9EBS8PdsCd1Pg+WHv+5jji1HDQn4+ ebZJPlzFVL05g== Message-ID: Date: Tue, 29 Nov 2022 16:08:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2] iommu/mediatek: Fix crash on isr after kexec() Content-Language: en-US To: Ricardo Ribalda , Joerg Roedel , Matthias Brugger , Yong Wu , Will Deacon , Robin Murphy Cc: linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org References: <20221125-mtk-iommu-v2-0-e168dff7d43e@chromium.org> From: AngeloGioacchino Del Regno In-Reply-To: <20221125-mtk-iommu-v2-0-e168dff7d43e@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 28/11/22 23:16, Ricardo Ribalda ha scritto: > If the system is rebooted via isr(), the IRQ handler might be triggerd > before the domain is initialized. Resulting on an invalid memory access > error. > > Fix: > [ 0.500930] Unable to handle kernel read from unreadable memory at virtual address 0000000000000070 > [ 0.501166] Call trace: > [ 0.501174] report_iommu_fault+0x28/0xfc > [ 0.501180] mtk_iommu_isr+0x10c/0x1c0 > > Signed-off-by: Ricardo Ribalda > Reviewed-by: Robin Murphy Reviewed-by: AngeloGioacchino Del Regno