Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f954e71b-043c-43bc-a692-530497de2d0b@gmail.com>
Date:   Tue, 29 Nov 2022 18:28:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH] dmaengine: ti: k3-udma: drop loglevel for non-fatal probe
 deferral log
Content-Language: en-US
To:     Jayesh Choudhary <j-choudhary@ti.com>, vkoul@kernel.org
Cc:     dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221128101334.512816-1-j-choudhary@ti.com>
From:   =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= <peter.ujfalusi@gmail.com>
In-Reply-To: <20221128101334.512816-1-j-choudhary@ti.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 28/11/2022 12:13, Jayesh Choudhary wrote:
> Change the log level from dev_err() to dev_dbg() for non-fatal probe
> deferral log for getting MSI domain.
> This makes the kernel log clean and we do not get recurring logs
> stating: "Failed to get MSI domain".

Or not print at all?

Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>

> 
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> ---
>   drivers/dma/ti/k3-udma.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
> index ce8b80bb34d7..e540166cf4c7 100644
> --- a/drivers/dma/ti/k3-udma.c
> +++ b/drivers/dma/ti/k3-udma.c
> @@ -5344,7 +5344,7 @@ static int udma_probe(struct platform_device *pdev)
>   	dev->msi.domain = of_msi_get_domain(dev, dev->of_node,
>   					    DOMAIN_BUS_TI_SCI_INTA_MSI);
>   	if (!dev->msi.domain) {
> -		dev_err(dev, "Failed to get MSI domain\n");
> +		dev_dbg(dev, "Failed to get MSI domain\n");
>   		return -EPROBE_DEFER;
>   	}
>   

-- 
Péter