Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <10c0545d-d9aa-8d85-e3ba-ee739cb126ef@seco.com>
Date:   Tue, 29 Nov 2022 11:29:39 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH net v2 2/2] phy: aquantia: Determine rate adaptation
 support from registers
Content-Language: en-US
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>, netdev@vger.kernel.org,
        Vladimir Oltean <olteanv@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org,
        Jakub Kicinski <kuba@kernel.org>,
        Tim Harvey <tharvey@gateworks.com>,
        "David S . Miller" <davem@davemloft.net>
References: <20221128195409.100873-1-sean.anderson@seco.com>
 <20221128195409.100873-2-sean.anderson@seco.com>
 <Y4VCz2i+kkK0z+XY@shell.armlinux.org.uk>
 <b25b1d9b-35dd-a645-a5f4-05eb0dbc6039@seco.com>
 <Y4VVhwQqk2iwBzao@shell.armlinux.org.uk>
 <9d4db6a2-5d3f-1e2a-b60a-9a051a61b7da@seco.com>
 <Y4Ywh+0p8tfTMt0f@shell.armlinux.org.uk>
From:   Sean Anderson <sean.anderson@seco.com>
In-Reply-To: <Y4Ywh+0p8tfTMt0f@shell.armlinux.org.uk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXp0Q3dlclNhTzRNV1E5U1Rsem0vS0pYU2lESmRBRU9jUkJpeHdPY0pGeFll?=
 =?utf-8?B?ZmxlamNiQXBBaVMwM3ZXaHEvVWVqR1BFL2VtN1NGQ0tibnMzKzZ3NVNRekVC?=
 =?utf-8?B?Wm9Od095Mjg5M24xYk5JdzBac1JZYnU3UDRDOXZqMUZ4NkZIMkxIZ0lBaThN?=
 =?utf-8?B?SXRkS3BZSXlzb0FDSGxtMjFKQVVsVi9BUDlpVkVPTmlPS0ZlMHBNcEVNQ1Fp?=
 =?utf-8?B?Rkc0TWlEQWMrNDJBR2I4cUprZ1VOcDlBcGxDRHRrNU5NcE81TThoWlZFcUNq?=
 =?utf-8?B?UnlpQzZSbTlaWEZ5YytSd1BxaXo4azNZT2JFVThZWjJlMlNYUDZRWDlaajZ3?=
 =?utf-8?B?MUdBemR2eXZBVVRWVGlMWGMrNjBHbmdLMVFIdGJwamYzeFc2Z3ZKVEFxQmtR?=
 =?utf-8?B?TDVSZjllMmV0YzVCbEtEbHpRMU1GZ0owQjcwbjY2Ym5CYU9WQjU5ZUFIWUNW?=
 =?utf-8?B?ZkYybDB4TDR3Mk93Q2cyaW8zVVhVOVBuQ2ZhYjRZOFluM296TlhPR3hmWi9x?=
 =?utf-8?B?dGRPN2JaSllKTTBJTk5XSHpPZ2VZN1hyNWUwdHhUaDBsUlFNZWdqWHVJYWJy?=
 =?utf-8?B?R2NsUDhiWUlsQlVxbnd4aWwrbUpyandsallkMC8rS2NyN0xlM1hJdXhqc0Rr?=
 =?utf-8?B?b1BUK0Q5dmVTYkJWU2hQQ3l4K2x4bzhJQjl4UHJnbXFMek4zaXBHVi80bjM1?=
 =?utf-8?B?U0hKOHF3enBzOG1VaGFnYXRGVTlndEo3MTNVZldFemNGRytsdUpwbUxTc1FZ?=
 =?utf-8?B?WGh6ZFpNbmR4NEc0bStyUWkxVkJMK2t6cUdQenUxeGtnWG93VlQ0cG4wK2Ra?=
 =?utf-8?B?MmRFbXIybDQ2ZDBDa1dnZ1ZERU5GQVdSU2czbHBrREpuRXJkNU9hWXN5UVhs?=
 =?utf-8?B?NWpXZWwvSmJlMGVSejZXeEZiY01wQndOc1BaSFNCZUIrSXVDdmxTY1dyaUVG?=
 =?utf-8?B?L204aFh3M3Z4NTlGc09CV0NCTUtKNHlOdGdST3RhSUFhMFJNcTFtdEI5cXRY?=
 =?utf-8?B?bXdTNnZ6akQrTVY1YUtCb2NCbE0xZ1hIcngyOW9rYWEzRnliKzFKYUkxSmF3?=
 =?utf-8?B?SnVLS3dtS0Y5TUNNQzRCb0pWTVB4MHVUYjhTT240aUs3UEhWY2NHTXY4ZGlD?=
 =?utf-8?B?V0hnOXRjbU85Q1lxNGJveDJyY1BzS05RMW9IdGU4VHE2WHRpUVFhT2RmbVUr?=
 =?utf-8?B?RTIzY0NPTlhtSXJPVkNabEtEUm1wdlBHUGZGK2xhMzg5Q0JXdVdmSUpFZVBL?=
 =?utf-8?B?MWtyRmhhVDkxSEhkTm5NZ1lUMnVIWjBZQ2tsV2RRMFdEelljSDg0N1Zrc3BQ?=
 =?utf-8?B?V3Nnd0FKSkU1dWt6amk2ZGxJbVp4L1YvdWNTTFhKU0JyQ1ZwN1VDek82bHpa?=
 =?utf-8?B?TmpXQlR0LzJUZWl6UFg0YUVnZmo3Nm10bGFmU0tCZk12N0g3eHJZb3k0d2RW?=
 =?utf-8?B?Zi9hQVdPRXgySVQ3cDcyZXE3aXZldWEvRXVoNitGVHR4QWV2L210SnphWmtv?=
 =?utf-8?B?QzZaRGlIejljT3dTM2RmOHVId1I0anQ3RGxOT3NJbHdCTnpyRkJGMXJqeld6?=
 =?utf-8?B?YTVNT1Z4Qlg0OGRhYXF4VmpjeVRuWGZKVUR6OHMyWXNBRXNINmc4Zkc3Slps?=
 =?utf-8?B?VUU2cEZGYWxQalY4TDErRHI3bUN3cnA4QVhiUldBYmtnRFJoQVFKQi8xM1Ra?=
 =?utf-8?B?MllFcDBXNUZacy82a2V1QXhvRzkwNjVjWVh1dGVZUzRKeFE4dUNFSFVtKzFn?=
 =?utf-8?B?blVqdzc1WG9HSklGVGU5YVYrRHlHdHhuMENlQVBaU0lZZU41ZFFFZDNDbmkw?=
 =?utf-8?B?OFprQlVpbHJ5RU8yaDBmWWdSOXB4eENKNFNjU2RHMDBYWnB2QnNNVTRJWGs5?=
 =?utf-8?B?UHRYYk1OSTcvQTBiZG1xTVkreFdwT09aNVl2Z2FOOEtSSTZub1hOTERZd0lY?=
 =?utf-8?B?d2VjWkZ5RFVWMHU1dE5oWWt5TWNLN3I4NUlyTldiNGpSRFlMaXN6c3J2VTM3?=
 =?utf-8?B?SUdDYmRaNklJOE1sU0EvNklTWEl2QTRnQ3RrV3VaZitkeVExWEFWNmk5Ly9U?=
 =?utf-8?B?RXRmUEpPU2dvaDI0ZTBEczk2SEhXTktEcnhudDQ3QWNxd05YWUFMcXJXMG4x?=
 =?utf-8?B?Tzl4a0hRNEowZ3BhYzZpcU5JcFVMRW5HTEIzUm53WGU3blIyR3VaQ2JBTWtF?=
 =?utf-8?B?b2c9PQ==?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a7f69ba2-4c21-4df0-eb33-08dad226ee5f
X-MS-Exchange-CrossTenant-AuthSource: DB9PR03MB8847.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 16:29:47.8231
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5OHhQAOleaf1jhWVNVizLwv81x+KbP5I5goUryIpxVMXcmP2KTUB7K270pZfaBONMJjFd+kgPYGg50s2U2gBsg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR03MB7482
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/29/22 11:17, Russell King (Oracle) wrote:
> On Tue, Nov 29, 2022 at 10:56:56AM -0500, Sean Anderson wrote:
>> On 11/28/22 19:42, Russell King (Oracle) wrote:
>> > On Mon, Nov 28, 2022 at 07:21:56PM -0500, Sean Anderson wrote:
>> >> On 11/28/22 18:22, Russell King (Oracle) wrote:
>> >> > This doesn't make any sense. priv->supported_speeds is the set of speeds
>> >> > read from the PMAPMD. The only bits that are valid for this are the
>> >> > MDIO_PMA_SPEED_* definitions, but teh above switch makes use of the
>> >> > MDIO_PCS_SPEED_* definitions. To see why this is wrong, look at these
>> >> > two definitions:
>> >> > 
>> >> > #define MDIO_PMA_SPEED_10               0x0040  /* 10M capable */
>> >> > #define MDIO_PCS_SPEED_2_5G             0x0040  /* 2.5G capable */
>> >> > 
>> >> > Note that they are the same value, yet above, you're testing for bit 6
>> >> > being clear effectively for both 10M and 2.5G speeds. I suspect this
>> >> > is *not* what you want.
>> >> > 
>> >> > MDIO_PMA_SPEED_* are only valid for the PMAPMD MMD (MMD 1).
>> >> > MDIO_PCS_SPEED_* are only valid for the PCS MMD (MMD 3).
>> >> 
>> >> Ugh. I almost noticed this from the register naming...
>> >> 
>> >> Part of the problem is that all the defines are right next to each other
>> >> with no indication of what you just described.
>> > 
>> > That's because they all refer to the speed register which is at the same
>> > address, but for some reason the 802.3 committees decided to make the
>> > register bits mean different things depending on the MMD. That's why the
>> > definition states the MMD name in it.
>> 
>> Well, then it's really a different register per MMD (and therefore the
>> definitions should be better separated). Grouping them together implies
>> that they share bits, when they do not (except for the 10G bit).
> 
> What about bits that are shared amongst the different registers.
> Should we have multiple definitions for the link status bit in _all_
> the different MMDs, despite it being the same across all status 1
> registers?

No, but for registers which are 95% difference we should at least separate
them and add a comment.

> Clause 45 is quite a trainwreck when it comes to these register
> definitions.

Maybe they should have randomized the bit orders in the first place to discourage this sort of thing :)

> As I've stated, there is a pattern to the naming. Understand it,
> and it isn't confusing.
> 

I don't have a problem with the naming, just the organization of the
source file.

--Sean
--Sean