Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1099746rwb; Tue, 29 Nov 2022 09:01:01 -0800 (PST) X-Google-Smtp-Source: AA0mqf5dWx66Tcj4DegUW0VhrEKkxvW6SgFzZeM1TuBo43WWVq5Lui5IX6itkg8qRYAXQy/3ZIXe X-Received: by 2002:a63:5b01:0:b0:477:e3df:13ac with SMTP id p1-20020a635b01000000b00477e3df13acmr19221818pgb.321.1669741261135; Tue, 29 Nov 2022 09:01:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669741261; cv=none; d=google.com; s=arc-20160816; b=ZunAjxuD6j5JBatryMTBbpVnidMiOCfcSSxkOggOV2aCeIzFI6v5XnxKyIsxiAVcla byJ8ESlQpFbMtxFQEveIv2MeutJ1hl3o+aq8RIsJCWCnySD6tXTeTMzRKvcY3bN4ipZX OcmngqD1IBs8TbI4sXVu2BAtfPAHgGP/EQ6MJVfa7xAHvFS48mqyG08wj7/q/7CswT6U cpO4mP151aVfxX1w3beW6efNS/FOcZvvsNHpdpPOEhbfgRSPyWseW5WjquQAyh05h/o1 nfBu9tKx7KJcfmhptCFdrcZrbTFJts0T9LMNWqX2syHG8OHVO1NVnKOGJKMb6n7HBxLA BMRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=NJx/DN/pacow03abC9oKEtC9hBdL+043EoowxtJJW9g=; b=tnNxziuEdIKOGY2AiUq9tUYP0Q+vj1YwyF7Znx6ZfGMXZak/q16e6pfnbcvSr3Rqsv kiJK9k41RL4DLeyltndYxsnulsghEL8qHRGEniXNPk6Ama2lG5tJautCIT151yDhxSlC 6nLiX6i0ffRDrywltdujxTFVxU5FyiWFZgAiY42V0KM4oQwMQb/zARtjoGifKVqGiM7h EpT26GsYs+Z72TxpNTa8K5gXVhfRVXkU8dzKkpEZLe2M2lNalf0H5w7wyYRaBvu6Ksax zN8nBiZITxiEGAe4OnN5+DseQCMeMbZVryrvd34rthoFHVtGJeXU9oKiBLyRHyMLMgli 9Auw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s82-20020a632c55000000b00460a6ee5b53si15437545pgs.37.2022.11.29.09.00.46; Tue, 29 Nov 2022 09:01:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235900AbiK2QaN (ORCPT + 84 others); Tue, 29 Nov 2022 11:30:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235889AbiK2QaK (ORCPT ); Tue, 29 Nov 2022 11:30:10 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E2BF5A6EE for ; Tue, 29 Nov 2022 08:30:10 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AEDC4617F1 for ; Tue, 29 Nov 2022 16:30:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 61941C433D6; Tue, 29 Nov 2022 16:30:08 +0000 (UTC) Date: Tue, 29 Nov 2022 11:30:06 -0500 From: Steven Rostedt To: Jeff Xie Cc: mingo@redhat.com, mhiramat@kernel.org, zanussi@kernel.org, linux-kernel@vger.kernel.org, chensong_2000@189.cn Subject: Re: [PATCH v15 0/4] trace: Introduce objtrace trigger to trace the kernel object Message-ID: <20221129113006.0d745fae@gandalf.local.home> In-Reply-To: References: <20220819032706.695212-1-xiehuan09@gmail.com> <20221017154057.78babf40@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Nov 2022 00:09:51 +0800 Jeff Xie wrote: > > Now instead of searching the function arguments for "obj", we should just > > read the obj value at every function and report when it changed, as well as > > the last function it was still the same. The report will be like the > > "func_repeats" entry. And instead we can print when the object changes, > > something like this: > > > > cat-117 [002] ...2. 1.602245: bio_add_page <-ext4_mpage_readpages object:0xffff88811bee4000 value:0x2000 (last value:0x1000 at [002] __bio_add_page <-bio_add_page ts: 1.602245) > > > I'm just curious if we'll see this rewritten version in the next merge > window ;-) Unfortunately, this ended up getting dropped in priority, as my workload increased internally. :-/ -- Steve