Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221117114818.v7.1.If7926fcbad397bc6990dd725690229bed403948c@changeid>
 <20221117114818.v7.3.Ie23c217d69ff25d7354db942613f143bbc8ef891@changeid> <Y3cbswXxTKWhMjKT@google.com>
In-Reply-To: <Y3cbswXxTKWhMjKT@google.com>
From:   Mark Hasemeyer <markhas@chromium.org>
Date:   Tue, 29 Nov 2022 11:13:04 -0700
Message-ID: <CANg-bXAxeL_N53umfeoYjAyDfw5EeHmcniZusPo+bb-BE1R4Ow@mail.gmail.com>
Subject: Re: [PATCH v7 3/3] platform/chrome: cros_ec_uart: Add DT enumeration support
To:     Tzung-Bi Shih <tzungbi@kernel.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Raul Rangel <rrangel@chromium.org>,
        Bhanu Prakash Maiya <bhanumaiya@chromium.org>,
        Benson Leung <bleung@chromium.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Guenter Roeck <groeck@chromium.org>,
        chrome-platform@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

> > @@ -392,6 +393,12 @@ static int __maybe_unused cros_ec_uart_resume(struct device *dev)
> >  static SIMPLE_DEV_PM_OPS(cros_ec_uart_pm_ops, cros_ec_uart_suspend,
> >                        cros_ec_uart_resume);
> >
> > +static const struct of_device_id cros_ec_uart_of_match[] = {
> > +     { .compatible = "google,cros-ec-uart" },
> > +     {}
> > +};
> > +MODULE_DEVICE_TABLE(of, cros_ec_uart_of_match);
>
> It would need a guard for checking CONFIG_OF.  Similar to what
> `cros_ec_uart_acpi_id` does.
>
> > @@ -405,6 +412,7 @@ static struct serdev_device_driver cros_ec_uart_driver = {
> >       .driver = {
> >               .name   = "cros-ec-uart",
> >               .acpi_match_table = ACPI_PTR(cros_ec_uart_acpi_id),
> > +             .of_match_table = cros_ec_uart_of_match,
>
> It would need be wrapped by `of_match_ptr()`.  Similar to what
> `ACPI_PTR()` does.

I'm not sure we want a guard in this case because we compile the kernel without
CONFIG_OF enabled for (most?) x86 platforms. Yet we still need the device
tree code to enumerate using the PRP0001 _HID method.