Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 29 Nov 2022 20:33:56 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     yang.yang29@zte.com.cn, peppe.cavallaro@st.com,
        alexandre.torgue@foss.st.com, joabreu@synopsys.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, mcoquelin.stm32@gmail.com,
        netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        xu.panda@zte.com.cn
Subject: Re: [PATCH linux-next v2] net: stmmac: use sysfs_streq() instead of
 strncmp()
Message-ID: <20221129183356.bdlhgset4rk5a5kp@skbuf>
References: <202211291502286285262@zte.com.cn>
 <Y4ZOpQL3daLPqXXl@lunn.ch>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y4ZOpQL3daLPqXXl@lunn.ch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cXFSCbg1XIUi1ppY1icO4f8hReo5+549pf1FFhVS7AmuSOXIE8b1gyLuOWWh?=
 =?us-ascii?Q?z7yY9LzHDrOlbyp35oq3FTUIZKMnouAuNyqvAXPyZ+TnEFvtVgLiGgt1jtUq?=
 =?us-ascii?Q?bYcNUutSLAIep6A+VLV/9l0BUiUwpwsFoyfNBek7WUviY0Lm2k0pTzhZw0kn?=
 =?us-ascii?Q?q9BjJpxx7jU52Vc2GLP3ZciuWn+XEPj6Ig4FuNWOxepafiD/dFfUuqVtTL6+?=
 =?us-ascii?Q?NKloO+XHgafmktHf2DrTgDcFpYkfBg2E40o0Ot3nBmMiZdR/lnoh/8fXBCrI?=
 =?us-ascii?Q?VyMXoaddW8kaJPc+ZdZZZS7h6ujLCe/iORp11klNBKgJIF8HZJvr93AdYyFO?=
 =?us-ascii?Q?fsxRw/BjcwRH99VhajLkl85ZaT1SMcnXQGKb536yPd+6VdJ7LpIMyUcsFpuX?=
 =?us-ascii?Q?+uPHh97gbmiyjbn6t8lCUOi7Y4ZlI0Mr8Agtmm5ySh9XcTDBSpOaz0/6nw3v?=
 =?us-ascii?Q?dG+s8sUsZS607QFZTneBkhv7s1X44X7xE4Ml/5XeCrOnCyYAjlRcAOU8Zhlw?=
 =?us-ascii?Q?03xToWhKKbR/VxSe60lOT2veDpcaHhh2h//MfyxfTMvDtvCDLEqEvv/GYv43?=
 =?us-ascii?Q?/810YXl8JnRAnwdo37rcd/foxC02XkOo3ttmTPa+mj1egFFNM8TeGJucUI6S?=
 =?us-ascii?Q?9PW+JQ57d9iGSs+NkYGRa4vmLeq9g/qFtAII6OLYCCIRlPziKvBXkzRuYY/H?=
 =?us-ascii?Q?sl6qH6DK3q4uJD2SiaNuOsKhpvgHEzxYvHbxLROeI8m2ifVvTLQ4KQijL85+?=
 =?us-ascii?Q?NhJ26W5iA9vXsuSVLqi2tiIwOgzGROEE1iBO3g82a0RZ+fDc7avJiaYzcZ2y?=
 =?us-ascii?Q?ROkJ56VZrYxbdYlGtzD9xTKa30vjTn+1AY7zOeGdDyoq+qbMAKYu9PowEvIA?=
 =?us-ascii?Q?CMyx1HcfdBo9Z/cAOEV+OfR+1cHFrdMj76baq2J9ZZE+PM7tEdeWIz4ckPJq?=
 =?us-ascii?Q?AS7EGsPz2Lnq7FR4wAgDw7WYrtdr53vX2QPMeo6hnM3afNxE3sgQGlQSMEb+?=
 =?us-ascii?Q?knZhpPKX1UPWbW9JRBrJLx0E4xmq6m7mrCAhzr/2AreThAg4Es+S9i8D0KW+?=
 =?us-ascii?Q?OA9reRoQ5XNME8CzYglplJGpOR3maUp/fEixqSr+w63ci9pCUEv/1PtXFQUL?=
 =?us-ascii?Q?aNTQ73tRl3r26m9I2UJFIsEU9bqeKQTnKV2vIyFJMPJtAvkl0+oxFG/VTIuR?=
 =?us-ascii?Q?KSwRvbu6f9w5BNbVJFY+uj1D9HLcuzl05NvMXzNApbVl9T3PhPxN+p87WUDa?=
 =?us-ascii?Q?5JoWIaQ8YhON4Zo480jPcxI5XazRczGHQIj60Ip7vP+u29OtFfezmZTr92u9?=
 =?us-ascii?Q?t7qO1TmHZL7O2ljLEqf4J636S5zE1tGFrupnPNQ7cUFjcsxDbJTQLI4GXHcL?=
 =?us-ascii?Q?Rgrw2Y0Ch5OuQcKI0lTA3FclRpMXEYyeG2+VMem9o+f7DH0V+Gmsm8Pywfv+?=
 =?us-ascii?Q?qP2aCQOq5jO6LB+jDLSBCsGdfeCL+uQWx9QKYW0hJOyK0A6iTm2Zo4bJw1G3?=
 =?us-ascii?Q?KQkn1STpK+JGGp/noL7eYCJ9SXPbqbpxgei2LErDYBXIBWBIaR+1VNMvW+O0?=
 =?us-ascii?Q?DARSQcdi+CeosCCRgM0c3HMq9XayHOKMKGrFloJr7duuzr9wNhBPWzxTUw+y?=
 =?us-ascii?Q?nw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b3a9800-56b1-4a1e-8b87-08dad23848ab
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 18:34:00.7112
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AyZ1aySYIvDbyCsXnVixX8od0mjJ69OXps8sbL1MTd//xe6sGQwQmtTc1T9Ykf+rtfHDrp6qu0GY3QiO7by8/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9700
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 29, 2022 at 07:25:41PM +0100, Andrew Lunn wrote:
> > With strncmp("tc:", 3), the code matches on the "tc:1" token properly.
> > With sysfs_streq("tc:"), it doesn't.
> 
> It is not clear you have addressed this point.

As they say, "let sleeping dogs cry". I'm not sure that we should be
making (especially untested) changes in the cmdline handling there.