Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1348626rwb; Tue, 29 Nov 2022 12:17:20 -0800 (PST) X-Google-Smtp-Source: AA0mqf6fewHIUxpEBENIM4bMXeoGP5ufdqFySK8RtTquJKAQ/UaHR5j5ZQIFq3L7JueGSKjkPAeX X-Received: by 2002:a17:907:378:b0:7ad:db82:d071 with SMTP id rs24-20020a170907037800b007addb82d071mr34729734ejb.200.1669753039810; Tue, 29 Nov 2022 12:17:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669753039; cv=none; d=google.com; s=arc-20160816; b=nikpHO2ZZM/A3yWv0ZJxRT488P2PjHQFXdx/3GEfsJ/wDkSP6ula9dnubguYRCGQCg nqzOrHJaXKGI3wbjN6SGQoEz+e1KvJIx/QBMQ9kWOM6/yGF0R6upgsBj/85gVh+t5hZ6 HDuQHW9ovwq8hYmxC7J1/LgHadsLmCD7gy0Zq30hGUcCE1RhmnBoF7pbgA5j6cP7sMmH kg8/w3O0VCsE+xLsWjUoskPGH5oweKrhddPDrEt6uu8lXs4h6NQDElNJxXVcbp9DgRcj YX4IGCM1irxWQ+7vFuEz3mgJIwBqBAv8Fxt1GLYSE0qE2pqfx5PBmMjSxUTdd7kbjGMI YdCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dIthVPfRqMzRLHonB9Z3+9yNKc8FhZTyJnewRLDcrPs=; b=bJVI/rb/6bszG9dyHNhpJdBzQNhXhDxtNmTxjB7kubMfDLdYr/ra260oWVrQD2sNRT BvGuGCKuoq+U+zj72dlqBTaN2lE4W87Xu7DCNqErwFErkX/pk9je7/LdxRe4Ge7rKIJ5 K1CW0YFovVrApd3e9uB1MUIrD+VS0niM40LVnchCfv5qU30JpTjauYiBjQq1IWDjP9Zm H37DPqY/+b411hFvvI/5JyufgE++GUukgr7d/B4XXsKz7fpsBxc5MszPVAEL+WJIXkXR CIn389CUCSi3ZL+oILwyKJK0+FoOfFKH/M/sUEIxviGXvtZplDqKIpRx/T1PudzIs+Yu OcKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=v6cI95cK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b17-20020a056402279100b0046b4ce24c79si4887728ede.242.2022.11.29.12.16.53; Tue, 29 Nov 2022 12:17:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=v6cI95cK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236651AbiK2TSN (ORCPT + 84 others); Tue, 29 Nov 2022 14:18:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236680AbiK2TSJ (ORCPT ); Tue, 29 Nov 2022 14:18:09 -0500 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C493D5B5A9 for ; Tue, 29 Nov 2022 11:18:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1669749470; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dIthVPfRqMzRLHonB9Z3+9yNKc8FhZTyJnewRLDcrPs=; b=v6cI95cKHZF7JRsW6yCZyviPrYgL1hUQg6mGKb3+uSwSQT68AJ3ZblHdt2FXdYjVdF2lxU YhUSzbi1grVPHthQtkb3JWgqIRU8fEVCYtMlY3+3ITbHhcGY6uZfFk5LsBbEBlxgN4TgmX 0FTfc9J1QbkFBazrASWsvhNoZ8uol00= From: Paul Cercueil To: David Airlie , Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Paul Cercueil , Gerd Hoffmann , virtualization@lists.linux-foundation.org Subject: [PATCH v2 02/26] drm: bochs: Define and use generic PM ops Date: Tue, 29 Nov 2022 19:17:09 +0000 Message-Id: <20221129191733.137897-3-paul@crapouillou.net> In-Reply-To: <20221129191733.137897-1-paul@crapouillou.net> References: <20221129191733.137897-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the new DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS() macro to create a "struct dev_pm_ops" that can be used by this driver, instead of using custom PM callbacks with the same behaviour. v2: Use the DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS() macro instead of an exported dev_pm_ops. Signed-off-by: Paul Cercueil --- Cc: Gerd Hoffmann Cc: virtualization@lists.linux-foundation.org --- drivers/gpu/drm/tiny/bochs.c | 29 ++++------------------------- 1 file changed, 4 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c index 024346054c70..598488905607 100644 --- a/drivers/gpu/drm/tiny/bochs.c +++ b/drivers/gpu/drm/tiny/bochs.c @@ -2,6 +2,7 @@ #include #include +#include #include #include @@ -610,30 +611,6 @@ static const struct drm_driver bochs_driver = { DRM_GEM_VRAM_DRIVER, }; -/* ---------------------------------------------------------------------- */ -/* pm interface */ - -#ifdef CONFIG_PM_SLEEP -static int bochs_pm_suspend(struct device *dev) -{ - struct drm_device *drm_dev = dev_get_drvdata(dev); - - return drm_mode_config_helper_suspend(drm_dev); -} - -static int bochs_pm_resume(struct device *dev) -{ - struct drm_device *drm_dev = dev_get_drvdata(dev); - - return drm_mode_config_helper_resume(drm_dev); -} -#endif - -static const struct dev_pm_ops bochs_pm_ops = { - SET_SYSTEM_SLEEP_PM_OPS(bochs_pm_suspend, - bochs_pm_resume) -}; - /* ---------------------------------------------------------------------- */ /* pci interface */ @@ -716,12 +693,14 @@ static const struct pci_device_id bochs_pci_tbl[] = { { /* end of list */ } }; +DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS(bochs_pm_ops); + static struct pci_driver bochs_pci_driver = { .name = "bochs-drm", .id_table = bochs_pci_tbl, .probe = bochs_pci_probe, .remove = bochs_pci_remove, - .driver.pm = &bochs_pm_ops, + .driver.pm = pm_sleep_ptr(&bochs_pm_ops), }; /* ---------------------------------------------------------------------- */ -- 2.35.1