Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1363628rwb; Tue, 29 Nov 2022 12:31:31 -0800 (PST) X-Google-Smtp-Source: AA0mqf4zgBonmYwFYN9dcohJqL2P+Z4bMxl+LCGzrzk9IriFtFS6spC5AnwRcmN/NAsQs6eNpQx+ X-Received: by 2002:a63:5d55:0:b0:46e:fd0a:fe7a with SMTP id o21-20020a635d55000000b0046efd0afe7amr34557308pgm.59.1669753891393; Tue, 29 Nov 2022 12:31:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669753891; cv=none; d=google.com; s=arc-20160816; b=C69THPghHPUENGew4us2OAxzK7lGRT1E2dLnZsIIYuiXFuojhDoqqKFtoL9HyKMjOI Wr0t8Lsl/Lm+2SXW/8XcQhnF+x/JH4b5ZjySaUF7jrwtQ6ScMRyg0HYLkFQM2x+L6XD7 gsUYzYtuabR+01zmP4kc/di1Kzf46bQY+0b+eRwFeQYyqr/Qi9veScElOFIw16gEacC9 vudqQmQaDL9b0QiWnoNPh488LoVekQCLhDB6K8m9cOepQ7a4IMVY+NN6TBKU6PnuJYuu cfyrqgQcOD1y63huE24gAjXmNGbH8B99WdSmQwvmfVbpJxLVQ1RKqCcROH52W2mRGbPo NgVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=XJfb607OEPZzj5jgkFphMZxTPqxtnHJHM51G7bS3xhg=; b=smu0+XeCdV44iQYsGz9yF5XIUfgWl0WpNZt9A7CjXnygqiK84mKuZ9V/BRCn25Ifjf wqKtZdCe+vkf8kRmGxJ78FZG9P08IJWRbv8HfRNNR99nszv0nbvBiu47Lg0GYTSdcxW4 zqwfRiLLhPq95NS0Kg8uyyuBjId+tGnSkm1LlX1aJLCOaPTberfdMpg6wnSSTLjwIRvV WZCjhR4aTyq1/lbT9sVkz6J+SKe/GSJOx9vlQHZU+y2r+FVWZqIGoSd+ffn6/kNcN8nv ctbCTyC6FMbtotJlmlzdaj9VlwTjJB+QyZVPKyhGYm6ebTsgTFZObRebCu1hDPhPVShe uhpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=NHeNnfaj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k8-20020aa788c8000000b00574d06d6a4fsi14356528pff.56.2022.11.29.12.31.20; Tue, 29 Nov 2022 12:31:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@crapouillou.net header.s=mail header.b=NHeNnfaj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=crapouillou.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236740AbiK2TUC (ORCPT + 84 others); Tue, 29 Nov 2022 14:20:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236780AbiK2TTM (ORCPT ); Tue, 29 Nov 2022 14:19:12 -0500 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 051456D48F for ; Tue, 29 Nov 2022 11:18:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1669749480; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XJfb607OEPZzj5jgkFphMZxTPqxtnHJHM51G7bS3xhg=; b=NHeNnfajuJj9RKYJuLwf++m+ogVpTx5mJDmSLqyL7XYR/Sv/A8mIz8XsTQlKwTWAcwC8L5 tMJKHInbAvfNrr0xxTdaa88NpD4bqf3cgKpPG+SlGkoBYqtCAlbq9OrAHuYzYK1wmkiCp5 mMJ22m4Cwp4riY9CkZMFeJsyHG6w47c= From: Paul Cercueil To: David Airlie , Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Paul Cercueil , Marek Vasut , Stefan Agner , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 07/26] drm: mxsfb: Define and use generic PM ops Date: Tue, 29 Nov 2022 19:17:14 +0000 Message-Id: <20221129191733.137897-8-paul@crapouillou.net> In-Reply-To: <20221129191733.137897-1-paul@crapouillou.net> References: <20221129191733.137897-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the new DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS() macro to create a "struct dev_pm_ops" that can be used by this driver, instead of using custom PM callbacks with the same behaviour. v2: Use the DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS() macro instead of an exported dev_pm_ops. Signed-off-by: Paul Cercueil --- Cc: Marek Vasut Cc: Stefan Agner Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Cc: linux-arm-kernel@lists.infradead.org --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 22 ++-------------------- 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c index 810edea0a31e..c63d2eb3b379 100644 --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c @@ -398,25 +398,7 @@ static void mxsfb_shutdown(struct platform_device *pdev) drm_atomic_helper_shutdown(drm); } -#ifdef CONFIG_PM_SLEEP -static int mxsfb_suspend(struct device *dev) -{ - struct drm_device *drm = dev_get_drvdata(dev); - - return drm_mode_config_helper_suspend(drm); -} - -static int mxsfb_resume(struct device *dev) -{ - struct drm_device *drm = dev_get_drvdata(dev); - - return drm_mode_config_helper_resume(drm); -} -#endif - -static const struct dev_pm_ops mxsfb_pm_ops = { - SET_SYSTEM_SLEEP_PM_OPS(mxsfb_suspend, mxsfb_resume) -}; +DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS(mxsfb_pm_ops); static struct platform_driver mxsfb_platform_driver = { .probe = mxsfb_probe, @@ -425,7 +407,7 @@ static struct platform_driver mxsfb_platform_driver = { .driver = { .name = "mxsfb", .of_match_table = mxsfb_dt_ids, - .pm = &mxsfb_pm_ops, + .pm = pm_sleep_ptr(&mxsfb_pm_ops), }, }; -- 2.35.1