Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1456452rwb; Tue, 29 Nov 2022 13:58:23 -0800 (PST) X-Google-Smtp-Source: AA0mqf61LgycqnTSgH8JjNm9iE5lUbHBHQ6q78GiJdjJERjN/4mKUY/sBo/+vqs39HmB3hTbk06V X-Received: by 2002:a17:906:541:b0:7b2:8431:6d75 with SMTP id k1-20020a170906054100b007b284316d75mr31500120eja.329.1669759103529; Tue, 29 Nov 2022 13:58:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669759103; cv=none; d=google.com; s=arc-20160816; b=efr7gChxiQm4To9XH7rgA4lgTPQ4soteg1bRxe7I/DCg92V6wQZYlFd4WtHIi1zQk4 vzAryLlh8zcwIbg5HEPyxQro6xWPDZXIGFK2WmXnrgRmbhTVnHJrbdfek9DfPTKLuqjJ +aFog8WtmqP/yIRUVckjeTFlSABNBmmPsA7lWZGhwA6gFGw3y+LLgYu3iGSF7rgXSmGj t2IP/usKnlUBp94BbtkrpedzprHOj8FCpUilHyuBWuTnDa8AKw8SBbHpC+W9Jn/C1r6B nf+DGWWBpZfSLS/g6fGI168FKtzAuCCq/zmy5Dw/Td2Oi55crKJe//M2R8TZXSnIsYcT W6Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=pC2eHa0msxd9sy+5bd/7OZtPq8dO13H53fm6+pOfYUs=; b=XYnTkHGwL5JKLzhmwFcwgYP3g39Z+bpdMeU+G8q1sSJPrwtupIiCsS7fJx87Y8slQC TZSbFMsgWLy6A9OftDJBygB6NA607D239X5VlMVHm0fMbIN/Mql8KZ1IV0M5kK6Nwdxx TAQeaBw2FAQ8EduSYPWBLvd0HyJJFCP8U4dGWwNJZPL0Dt+mvuuXVbazlOs8FCsM9KHd hq4h56N+azFla6AFMhyjSl7tdBCJQmiW+YRbuisPF1jThW9QQC+WAgoO2Zq/RXYgOax7 6TZNTSHhXskW+O5CieEDbme0Dn778KGEKm6k6hSsH2vYBN4110DHAw9r50taFillwCCM OHDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=EAQhfAtl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f7-20020a056402194700b004571a669230si11539144edz.469.2022.11.29.13.58.02; Tue, 29 Nov 2022 13:58:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=EAQhfAtl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237051AbiK2V0Y (ORCPT + 85 others); Tue, 29 Nov 2022 16:26:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236072AbiK2V0W (ORCPT ); Tue, 29 Nov 2022 16:26:22 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE3D52873C for ; Tue, 29 Nov 2022 13:26:21 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 59D5A6193C for ; Tue, 29 Nov 2022 21:26:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62F43C433C1; Tue, 29 Nov 2022 21:26:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1669757180; bh=6ALCXb/pWvuaPqQbiW6kDLBf8N7JSNk2pLYAG27FG00=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EAQhfAtlgmpzYOMolrZDszRgzQkfuSrbi4HidyAWyZd8JUBq3EgRk9XzxH8xx6xCY 8NQl2KvQiG39KDECQsim0NJ5h9TQTh+XgCVzxWOJ/kb6Ek9zZ79sAOMzsyfM3c3E3W gX9/OAPT369m8Vpe+d/Kww1WyJaL3l2Wl8oqD/Xo= Date: Tue, 29 Nov 2022 13:26:19 -0800 From: Andrew Morton To: Peter Xu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, James Houghton , Jann Horn , Andrea Arcangeli , Rik van Riel , Nadav Amit , Miaohe Lin , Muchun Song , Mike Kravetz , David Hildenbrand Subject: Re: [PATCH 00/10] mm/hugetlb: Make huge_pte_offset() thread-safe for pmd unshare Message-Id: <20221129132619.f982806393c607fc20c9cb34@linux-foundation.org> In-Reply-To: References: <20221129193526.3588187-1-peterx@redhat.com> <20221129124944.8eff54cda65d0f5a8a089e22@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Nov 2022 16:19:52 -0500 Peter Xu wrote: > On Tue, Nov 29, 2022 at 12:49:44PM -0800, Andrew Morton wrote: > > On Tue, 29 Nov 2022 14:35:16 -0500 Peter Xu wrote: > > > > > Based on latest mm-unstable (9ed079378408). > > > > > > This can be seen as a follow-up series to Mike's recent hugetlb vma lock > > > series for pmd unsharing, but majorly covering safe use of huge_pte_offset. > > > > We're at -rc7 (a -rc8 appears probable this time) and I'm looking to > > settle down and stabilize things... > > I targeted this series for the next release not current, because there's no > known report for it per my knowledge. > > The reproducer needs explicit kernel delays to trigger as mentioned in the > cover letter. So far I didn't try to reproduce with a generic kernel yet > but just to verify the existance of the problem. OK, thanks, I missed that. I'll give the series a run in -next for a couple of days then I'll pull it out until after the next Linus merge window, so it can't invalidate testing heading into that merge window.