Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 29 Nov 2022 16:34:12 -0800
From:   Jacob Pan <jacob.jun.pan@linux.intel.com>
To:     Baolu Lu <baolu.lu@linux.intel.com>
Cc:     iommu@lists.linux.dev, LKML <linux-kernel@vger.kernel.org>,
        Joerg Roedel <joro@8bytes.org>,
        David Woodhouse <dwmw2@infradead.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Will Deacon <will@kernel.org>, Yi Liu <yi.l.liu@intel.com>,
        "Tian, Kevin" <kevin.tian@intel.com>,
        Raj Ashok <ashok.raj@intel.com>,
        Yuzhang Luo <yuzhang.luo@intel.com>,
        jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH v2] iommu/vt-d: Add a fix for devices need extra dtlb
 flush
Message-ID: <20221129163412.15da3081@jacob-builder>
In-Reply-To: <9fd4bf6c-5525-c209-28b6-492558c1dd35@linux.intel.com>
References: <20221128170410.3830605-1-jacob.jun.pan@linux.intel.com>
        <9fd4bf6c-5525-c209-28b6-492558c1dd35@linux.intel.com>
Organization: OTC
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Baolu,

On Wed, 30 Nov 2022 08:10:55 +0800, Baolu Lu <baolu.lu@linux.intel.com>
wrote:

> > --- a/drivers/iommu/intel/iommu.c
> > +++ b/drivers/iommu/intel/iommu.c
> > @@ -1396,6 +1396,23 @@ static void domain_update_iotlb(struct
> > dmar_domain *domain) spin_unlock_irqrestore(&domain->lock, flags);
> >   }
> >   
> > +/*
> > + * Impacted QAT device IDs ranging from 0x4940 to 0x4943.
> > + * This quirk is exempted from risky_device() check because it applies
> > only
> > + * to the built-in QAT devices.
> > + */  
> 
> How about adding:
> 
> "This quirk is exempted from risky_device() check because it doesn't
> effectively grant additional privileges."
sounds good.

Thanks,

Jacob