Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <yuji2.ishikawa@toshiba.co.jp>
To:     <robh@kernel.org>
CC:     <hverkuil@xs4all.nl>, <laurent.pinchart@ideasonboard.com>,
        <mchehab@kernel.org>, <nobuhiro1.iwamatsu@toshiba.co.jp>,
        <linux-media@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: RE: [PATCH v3 1/4] dt-bindings: media: platform: visconti: Add
 Toshiba Visconti Video Input Interface bindings
Thread-Topic: [PATCH v3 1/4] dt-bindings: media: platform: visconti: Add
 Toshiba Visconti Video Input Interface bindings
Thread-Index: AQHYrL0T1ap+U+r1qk+2w9IindSRaK2oRN8AgK8NMWA=
Date:   Wed, 30 Nov 2022 01:36:18 +0000
Message-ID: <TYAPR01MB6201D43FD70094EC613CAF3092159@TYAPR01MB6201.jpnprd01.prod.outlook.com>
References: <20220810132822.32534-1-yuji2.ishikawa@toshiba.co.jp>
 <20220810132822.32534-2-yuji2.ishikawa@toshiba.co.jp>
 <20220810153802.GA585-robh@kernel.org>
In-Reply-To: <20220810153802.GA585-robh@kernel.org>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?TmhpNFM5N0tHdGlBUUpYWlY5SDhOcXAzWkpoUWIxWXZwV0J3L0VWNk5C?=
 =?iso-2022-jp?B?MEJvc2JkaFlYOGZsVnVMUjl4TTFkOWdDQVBROWRJVXVkTEJkNUR6aEJN?=
 =?iso-2022-jp?B?RUEzWWhLcWpWOWZBVkRpdzFUSWU5bklsYktDeUpqK3NUeWN0YTN0aGt4?=
 =?iso-2022-jp?B?cWFqVWRtOU4wd2MwSnhIME9EQkdiMkNXVGl1dm5RTXZGTjZxWCtNSHFC?=
 =?iso-2022-jp?B?Z3c2dVJIdjBiSDdITG15R05iVSsvUC94REZGWVZQTU1VcWx4NUp5RVBQ?=
 =?iso-2022-jp?B?N1lwRThQUFV2MDBwTGNTbXo1bkhjazYyclNBOFdsN3Zsc2xGYlRGWldP?=
 =?iso-2022-jp?B?TTV6dEM0UzM0eEQvY3lwWlNhUkp4c3ZtR3BoNDd1clNnU05TNnR4WFlQ?=
 =?iso-2022-jp?B?SUhSTVFyVENNbmQza1pqQVJXbmo3akltZG1BWkRRV2RabjZJcU9pQ2M2?=
 =?iso-2022-jp?B?V2twWWtUUmZhbFJqNG4vcEY1T3BiVk9mb3VmRSs0UWwrTjRScmM0NUZF?=
 =?iso-2022-jp?B?dlhCZ2pXS3JCMm9zcnZ6RytrRWJjOTcxcFRJUGQvak9KdTFicjFSK3lY?=
 =?iso-2022-jp?B?Vmw1OWdEdzB0WStvNDMzWSt5K2FWZGpqazcyRnliTjhvOXk2NFpTTW43?=
 =?iso-2022-jp?B?WUI0em5IVTFHaDB2WGpESkk2NEVVd01jRjhZaUZ0T1Bjdm1aVmM0R1Jj?=
 =?iso-2022-jp?B?cGEvcExkUk05RkxGdUVYYWhoa0NtTXIvUE1Dd0xHeFpBajcxT0EvVDJT?=
 =?iso-2022-jp?B?K2s2WFI2cnRRcGlOMDlyaVhPeGNsSmkwVkhRK1ZyUDNaL3NtUUpUQitQ?=
 =?iso-2022-jp?B?em53cHEzRXlqYURVdGpxSTVPZDZpdklucXBGNEx5aWpkS3dqWEZqdjls?=
 =?iso-2022-jp?B?YmtOZDVVS2VDN2M4S29oeXlCTTErNGZISGRsZ2d0UUc3bG9NK2liS05r?=
 =?iso-2022-jp?B?ay9yeExtZFVBcUF3dzlRL3hYU0tsdDgwNStBYlN6djdkbTIvQ2xsc0Rh?=
 =?iso-2022-jp?B?TlRzTzZuWFlGSnNEZGNBbWdXYitwYVZOVjQwUTE1b0s3ZDV0Qkp5L3hi?=
 =?iso-2022-jp?B?SVV4S1IwbUpUUU5Cc2dOd3l5U2dkNEpwVmUxRU9iZnQ0RWRzMmFHdUFy?=
 =?iso-2022-jp?B?cDFlZmhoL3FwdFU4TFpScGs2L3ZlN1dsT0RPWWRHbks5b2kvUUdPNGRs?=
 =?iso-2022-jp?B?ZC82eUw1a0hncGt3S0prMklNa2dZZHc5TERjNlZLUUZwSjQrMWNkR3ZJ?=
 =?iso-2022-jp?B?YkFUZ2hGQ1MwZWtSTVNCNStWSUNtZWVjeHNtaG1PQXZsMFhxS3RnU1p2?=
 =?iso-2022-jp?B?OWNYbkFyWWJvZzdhZUlzZ0VkSkFVUDdjalNRWHg0WWZtVVBWYlM1ZGI1?=
 =?iso-2022-jp?B?T25pcFdhNTJjTE1rT3hnUVdBZm9IUUVhS0taZEFXYnBLWkhnRTNneTZZ?=
 =?iso-2022-jp?B?U05qM0FUcUh4dUpjMVhwa1lLUFB5bTY5OVA4V1d3a2hlay9pMmFSSWNp?=
 =?iso-2022-jp?B?VkNtNDZ6NWlmeVhxOHpnSjhueWF0UUVaS3I5aEVNeFdpbUlPWmFVT3ZW?=
 =?iso-2022-jp?B?aGpucU4yd3dHa1NBK3ZtVE5pWXh0bHloUndRVVQ0T0FRTDFCZkJyL21M?=
 =?iso-2022-jp?B?OXBLaHFzc0dyZHRoKzErSTZJWU00bTFKUnlTVUNUMUZvbXQ0eVlxQlJ5?=
 =?iso-2022-jp?B?dXROMEpabjg1MU5yTEY1aWJGQ0NxMTkwVDVaNWdScXpkdmIxUFg5S3E4?=
 =?iso-2022-jp?B?OEFxdGJzaCtOcnVsQzFjT3pITUVyWTMwMHJaSjFEbmx0RVBBT0dYM3Np?=
 =?iso-2022-jp?B?bnhBbFVjSlBpVnFrckpHbTY2OFRFc1U0UEFOQS90cm04V1kzMUtHNjdk?=
 =?iso-2022-jp?B?eUhhZ2tyQ1FSektiSFlESS9wU1ZPbHJTYThwZkVPQTZMZjd0eWwvb0FG?=
 =?iso-2022-jp?B?cDZHdEVYb0tNcWtNVjFhOVM4U2tJNUU0NlkxeHVOYVdPblhyWnRRRFhW?=
 =?iso-2022-jp?B?NEp6cW5BbDBKYldJUTBGWmRZSTFUaHlJSDRrL1hham9qMmFNNmp2R0Ru?=
 =?iso-2022-jp?B?cWpBd3p4Q3BRYkdvVEpHcDVmZ1dNNUkxeWZSQkZ4WEVWd0FrZStJQW4y?=
 =?iso-2022-jp?B?Zkxtd09LQmtYNjZvVHlLdDN4ZGpLeUVXQ1NrdDJ4cW4ycWptT0FsN0Nv?=
 =?iso-2022-jp?B?Zjd3NWdLVW95a3hqSDQ4VnpwKzJyU0NnRWNyUWJtRnR0VTNzOXNMOEFl?=
 =?iso-2022-jp?B?ZFpkdTRsUzNWSmNMaDQvSUg3bzZ1RGtDTUc3RGlBRlJqbXlPdU9qU1pS?=
 =?iso-2022-jp?B?QVN4dFVqdzJNSDRvbnBMYXMyQWdxcCs2Z0E9PQ==?=
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYAPR01MB6201.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0aa5eef8-a4ac-4ea3-2609-08dad2734733
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2022 01:36:18.3640
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f109924e-fb71-4ba0-b2cc-65dcdf6fbe4f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nmJbLzRxlkkFPhLnbkmSV5vs6eHSxe4OB2onONM332J9UOVSfb0iNomitg5PdXdbqWFigZjYBo9GyKG+GGIcH1gOWnH9+VyVxt19F/YkOuk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSZPR01MB9360
X-OriginatorOrg: toshiba.co.jp
MSSCP.TransferMailToMossAgent: 103
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Rob,

Thank you for your comments and sorry for this too late reply.

> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Thursday, August 11, 2022 12:38 AM
> To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開)
> <yuji2.ishikawa@toshiba.co.jp>
> Cc: Hans Verkuil <hverkuil@xs4all.nl>; Laurent Pinchart
> <laurent.pinchart@ideasonboard.com>; Mauro Carvalho Chehab
> <mchehab@kernel.org>; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ)
> <nobuhiro1.iwamatsu@toshiba.co.jp>; linux-media@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org
> Subject: Re: [PATCH v3 1/4] dt-bindings: media: platform: visconti: Add Toshiba
> Visconti Video Input Interface bindings
> 
> On Wed, Aug 10, 2022 at 10:28:19PM +0900, Yuji Ishikawa wrote:
> > Adds the Device Tree binding documentation that allows to describe the
> > Video Input Interface found in Toshiba Visconti SoCs.
> >
> > Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp>
> > Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> > ---
> > Chengelog v2:
> > - no change
> >
> > Changelog v3:
> > - no change
> > ---
> >  .../bindings/media/toshiba,visconti-viif.yaml | 103
> > ++++++++++++++++++
> >  1 file changed, 103 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/media/toshiba,visconti-viif.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/media/toshiba,visconti-viif.yaml
> > b/Documentation/devicetree/bindings/media/toshiba,visconti-viif.yaml
> > new file mode 100644
> > index 000000000..848ea5019
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/toshiba,visconti-viif.ya
> > +++ ml
> > @@ -0,0 +1,103 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/toshiba,visconti-viif.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Toshiba Visconti5 SoC Video Input Interface Device Tree
> > +Bindings
> > +
> > +maintainers:
> > +  - Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> > +
> > +description: |
> 
> Don't need '|' if no formatting.

I'll remove '|'.

> > +  Toshiba Visconti5 SoC Video Input Interface (VIIF) receives MIPI
> > + CSI2 video stream,  processes the stream with embedded image signal
> processor (L1ISP, L2ISP), then stores pictures to main memory.
> 
> Wrap lines at 80 char.

I'll update the description.

> > +
> > +properties:
> > +  compatible:
> > +    const: toshiba,visconti-viif
> > +
> > +  reg:
> > +    items:
> > +      - description: registers for capture control
> > +      - description: registers for CSI2 receiver control
> > +
> > +  interrupts:
> > +    items:
> > +      - description: Sync Interrupt
> > +      - description: Status (Error) Interrupt
> > +      - description: CSI2 Receiver Interrupt
> > +      - description: L1ISP Interrupt
> > +
> > +  index:
> > +    enum: [0, 1]
> 
> No, we don't do indices in DT. Why do you need this?

The property 'index' can have value <0> or <1>. 
A node with 'index=<0>' corresponds to 0'th VIIF HW instance (VIIF0).
Also, there's 1'st VIIF HW instance (VIIF1) with a bit different operation-mode set.

Sorry for asking question for a comment months ago.
Let me clarify:
* The problem is NOT defining style of 'index' with enum
* The problem is NOT that 'index' is reserved keyword
* The problem is having additional sequential ID for a node, 
  while 'reg' (usually, the base address of registers) can identify instance.
  Therefore, 'index' should be removed, 
  and vendor-specific property can be used to declare each feature only on VIIF1.

Is this correct understanding or am I still missing the point?

> > +
> > +  port:
> > +    $ref: /schemas/graph.yaml#/$defs/port-base
> > +    unevaluatedProperties: false
> > +    description: Input port node, single endpoint describing the CSI-2
> transmitter.
> > +
> > +    properties:
> > +      endpoint:
> > +        $ref: video-interfaces.yaml#
> > +        unevaluatedProperties: false
> > +
> > +        properties:
> > +          data-lanes:
> > +            description: VIIF supports 2 or 4 data lines
> > +            items:
> > +              minItems: 1
> > +              maxItems: 4
> > +              items:
> > +                - const: 1
> > +                - const: 2
> > +                - const: 3
> > +                - const: 4
> 
> blank line

I'll fix this

> 
> > +          clock-lanes:
> > +            description: VIIF supports 1 clock line
> > +            const: 0
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - port
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +
> > +    soc {
> > +        #address-cells = <2>;
> > +        #size-cells = <2>;
> > +
> > +        viif0: viif@1c000000 {
> 
> Drop unused labels.

I'll fix this.

> 
> > +            compatible = "toshiba,visconti-viif";
> > +            reg = <0 0x1c000000 0 0x6000>,
> > +                  <0 0x1c008000 0 0x400>;
> > +            interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>,
> > +                         <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>,
> > +                         <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>,
> > +                         <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;
> > +            index = <0>;
> > +            status = "disabled";
> 
> Why is your example disabled? Don't put 'status' in examples.

I'll remove 'status'.

> 
> > +
> > +            port {
> > +                #address-cells = <1>;
> > +                #size-cells = <0>;
> > +
> > +                csi_in0: endpoint {
> > +                    remote-endpoint = <&imx219_out0>;
> > +                    bus-type = <4>;
> > +                    data-lanes = <1 2>;
> > +                    clock-lanes = <0>;
> > +                    clock-noncontinuous;
> > +                    link-frequencies = /bits/ 64 <456000000>;
> > +                };
> > +            };
> > +        };
> > +    };
> > +
> > --
> > 2.17.1
> >
> >
> >

Regards,
Yuji Ishikawa