Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 29 Nov 2022 19:59:14 -0800
From:   Dan Williams <dan.j.williams@intel.com>
To:     Shiyang Ruan <ruansy.fnst@fujitsu.com>,
        <linux-kernel@vger.kernel.org>, <linux-xfs@vger.kernel.org>,
        <nvdimm@lists.linux.dev>, <linux-fsdevel@vger.kernel.org>
CC:     <djwong@kernel.org>, <david@fromorbit.com>,
        <dan.j.williams@intel.com>, <akpm@linux-foundation.org>
Subject: RE: [PATCH 0/2] fsdax,xfs: fix warning messages
Message-ID: <6386d512ce3fc_c9572944e@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <1669301694-16-1-git-send-email-ruansy.fnst@fujitsu.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1669301694-16-1-git-send-email-ruansy.fnst@fujitsu.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?M2CPZ038+RBUQyoQhmerSg08s9lP1bxjSnuUvtmzquR6+gSUYybIfjRXeglj?=
 =?us-ascii?Q?W+/f+onyQpLKqx4u+p9cFUFB4DeHByPzP/KY2PeZVoNt88Ri+bJaugZuPCQb?=
 =?us-ascii?Q?l8SPQo4g8Atyaxn77NBVWhS5ZeXOajUKvRe2gbNwt1KiupNwrc11+9j7eOty?=
 =?us-ascii?Q?xlcQzJaYmkoylxpcfO8+axVr399W0YE6Kn2D8QHk81z0/gfdsQno9v7ICMJU?=
 =?us-ascii?Q?xZlJRvu9/c6wXUmqM6+5UGwxPcrIwnyeg6fc0o0Gd0/CIqHZ/dT0W+ylaW8X?=
 =?us-ascii?Q?UEya9IX2kI3HdfJXecg9rzA7TZ85Piwfz55JoheSKRWSoSycwan9K94Cl1oQ?=
 =?us-ascii?Q?flLX3AXGpSZ1HfO5LgKLIQlVmtq3BzQRsmeFInEi1ShMEdTvbdbWRu93KxDi?=
 =?us-ascii?Q?sBBqq/QwkV5U/92HVu4NBwnUQDptnpRuM7tND6lsLYBjdqlEgvOGm8PZUonv?=
 =?us-ascii?Q?MV3J/7c6rGImktrWsVdP5QnaWHnh8e5kXSq6dx1MinuoLgUSnoe4Nuy6EvIL?=
 =?us-ascii?Q?EfhUQEmMV9wREeIxq9221n49No8j8LWDPZ1crAuJcr8uohQaxnBgKJC/d1c7?=
 =?us-ascii?Q?m4sCgmJ1uRQ6stKLC3bMkDKydokLfEd35EZ0LGVoa3NCUhfcyiAQz0o71i/B?=
 =?us-ascii?Q?YY0ihxNu8zicE2KpjpJ0V7n7XNK7/02t+DJvtqTd8vkJ0Vz/uQw1r24eCwwS?=
 =?us-ascii?Q?L0K5rAxshaKdZX+OAHMITdCfGs3n/yQHktRwwlfB34n5gtNua35m8C+gvOOq?=
 =?us-ascii?Q?KfukDePh1vRfn4yRSFL4VKz7Crdq2ZqaDXIZ9OnYBIXSJGEj8ZwNDwfWBPf7?=
 =?us-ascii?Q?pwVxjv1XTr3T0wpV3Q3sZ7JdfGsCcz23FFjswOB82jqq/hODUzH9tq2uR9bE?=
 =?us-ascii?Q?VdR1CYSCNFgjTBlTrbGpxLTxnj8wsSyVoUTIyltsYQYqrio/wgWM7/fnpf/7?=
 =?us-ascii?Q?6Ubi4YSN/AN1+xTvEFeymKIpeLC42HO6YA4lcI6eA6v2YR9fuN8Z2+TIb6Ul?=
 =?us-ascii?Q?jHA9C+f4pfW6A2p9K6MsTLoA/F8rp+DL444ykXPVNL+cTVCwLiQeSjwT6Q/X?=
 =?us-ascii?Q?mr2w8D2Eidw+pBCLwoaZRuchydcduhVOH66iSlcJDlV0YekRiiLhtq9qFoe/?=
 =?us-ascii?Q?Fg9ZKx+eyGI4dcWvDF/B/5VG/3+4culpJkzHrY/ZIJqVK7qdRkvcIaqJT89t?=
 =?us-ascii?Q?oHyF/No6r13+jAak3Rl7bgT/ltNNJNbdvpiWelVaWCtHbBdprdEaNx4hCSrv?=
 =?us-ascii?Q?uifmYG6DSWnAinyWc9dVCM1BuzTYyw7K9DmKs9qDeY4k04IItUQAXx3O48mw?=
 =?us-ascii?Q?FHHOtO1v05DQajacejSaJXsbA0FG3ajy/7mexXtRvojjvHq1npdBcMUQ1ty+?=
 =?us-ascii?Q?D/FC6UjKjJ6kQPWmRwdvPO6JdcFF0YJvlaQOIdILZleAGz58Rr7NHhrI2i0Q?=
 =?us-ascii?Q?iU7HojEqEiHnUs1v73fE+lW0U53E6HbD7kjW2gFl6tgmMC/2VLc1Ad1EjIs3?=
 =?us-ascii?Q?3U498iPC3/eXpDu+F7dw403VZWp+xEz/p7nfQIuCWmiA3hlMLuk/FMSWrkuT?=
 =?us-ascii?Q?OnxhOG7aCsDmOEHxtW9iba6PPo7EA9tsIusGLWHmTqsTOJHl2ZJg35hgw6pJ?=
 =?us-ascii?Q?uA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c1d1f885-30f3-4bb3-4264-08dad28740aa
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 03:59:18.7413
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cqlNTggRIVTgreyi3tqtqB2xiATYcyx9cZ5Z4fctTbqZDdFdSHcw5VOa7Yu5z0AslDyuNGnRx07Sn9MzNz4yg8OMtdocufHa+MJIDWeS3H4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7118
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

[ add Andrew ]

Shiyang Ruan wrote:
> Many testcases failed in dax+reflink mode with warning message in dmesg.
> This also effects dax+noreflink mode if we run the test after a
> dax+reflink test.  So, the most urgent thing is solving the warning
> messages.
> 
> Patch 1 fixes some mistakes and adds handling of CoW cases not
> previously considered (srcmap is HOLE or UNWRITTEN).
> Patch 2 adds the implementation of unshare for fsdax.
> 
> With these fixes, most warning messages in dax_associate_entry() are
> gone.  But honestly, generic/388 will randomly failed with the warning.
> The case shutdown the xfs when fsstress is running, and do it for many
> times.  I think the reason is that dax pages in use are not able to be
> invalidated in time when fs is shutdown.  The next time dax page to be
> associated, it still remains the mapping value set last time.  I'll keep
> on solving it.
> 
> The warning message in dax_writeback_one() can also be fixed because of
> the dax unshare.

Thank you for digging in on this, I had been pinned down on CXL tasks
and worried that we would need to mark FS_DAX broken for a cycle, so
this is timely.

My only concern is that these patches look to have significant collisions with
the fsdax page reference counting reworks pending in linux-next. Although,
those are still sitting in mm-unstable:

http://lore.kernel.org/r/20221108162059.2ee440d5244657c4f16bdca0@linux-foundation.org

My preference would be to move ahead with both in which case I can help
rebase these fixes on top. In that scenario everything would go through
Andrew.

However, if we are getting too late in the cycle for that path I think
these dax-fixes take precedence, and one more cycle to let the page
reference count reworks sit is ok.

> Shiyang Ruan (2):
>   fsdax,xfs: fix warning messages at dax_[dis]associate_entry()
>   fsdax,xfs: port unshare to fsdax
> 
>  fs/dax.c             | 166 ++++++++++++++++++++++++++++++-------------
>  fs/xfs/xfs_iomap.c   |   6 +-
>  fs/xfs/xfs_reflink.c |   8 ++-
>  include/linux/dax.h  |   2 +
>  4 files changed, 129 insertions(+), 53 deletions(-)
> 
> -- 
> 2.38.1