Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1820423rwb; Tue, 29 Nov 2022 20:39:18 -0800 (PST) X-Google-Smtp-Source: AA0mqf68vuYB6wKBxEIBsPk4A2qcp6EpenE+/OHk1vDxMvu4m9MeSryruu/lHya1yFggjMN08GtZ X-Received: by 2002:a17:906:658:b0:7ae:df97:9ff4 with SMTP id t24-20020a170906065800b007aedf979ff4mr976371ejb.762.1669783158687; Tue, 29 Nov 2022 20:39:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669783158; cv=none; d=google.com; s=arc-20160816; b=mjvNuSdPmbXALW3/DG7EZqpg4rThGOlv9LiSf+doYJBq7BqKRNyvmij6jUWa3+YmXc Y07mj5MNPzqVEwTMpUKmLKgyHsthdqhW+4jhC+Nd3aZe1qK+1iuU42d+PAEYLtmvxrmK 3psv+USBLSbK+VasMAIcYO5+EIkVQ41PJT7vV9J12VH/svPpiE9Nybr6O4TVpnWdsiPv +ksKAOJzCZntnhSmcivBIvekT/wiZew6ZBFuaj7YE4TcIgemwcA5cCYKSEdvymQrpeWi 3RBTJSC0XWt+pRXndYZY72D2GN9lsXzivbCpMKJ+Bt7q7WrmyRTPEV5PnPW1NAUKmdEH IPnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:feedback-id:dkim-signature:dkim-signature; bh=Lmsmf4sJSUA0QJZ9UMg8yw1qEc3/5iR1aDuujhJHzeU=; b=PjBID9nRSLuqzXXOcLYY5tDkpO8CcPUjecmTrTumy60gpj9ORu73oaIYk0a/W36htO YL0cngTuThvjE56uYJXjfyWBSgOieVkpafzTB60pvG2+UshCKoBv+UcFgQKylHF0RxHO kdWpKkxbnrDhk4Bzmpy0ZgzZj9pZrHVUq0pflp2QrR5Bya7Vr+hbll92O/2ESPPcM/5U PUy45fvBo2rtonJqOfvxYBXdoqkUOq7DiwRow/5sIVwW0+w7Hba/zRDanzAGZFYFzggh Hm5HDRroysAw3gtc7kNjFildzy8xNIvteIMoTZ948oStrga1dGLnlUL83gwNtmA8zPl+ zNFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sholland.org header.s=fm2 header.b=ZmF3iPYu; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=l1HiEqJ5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sholland.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y25-20020a50e619000000b00467570d605dsi387920edm.614.2022.11.29.20.38.58; Tue, 29 Nov 2022 20:39:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sholland.org header.s=fm2 header.b=ZmF3iPYu; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=l1HiEqJ5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sholland.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233066AbiK3EIy (ORCPT + 84 others); Tue, 29 Nov 2022 23:08:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233059AbiK3EIp (ORCPT ); Tue, 29 Nov 2022 23:08:45 -0500 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F64226540 for ; Tue, 29 Nov 2022 20:08:30 -0800 (PST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 3DD063200958; Tue, 29 Nov 2022 23:08:26 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 29 Nov 2022 23:08:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1669781305; x= 1669867705; bh=Lmsmf4sJSUA0QJZ9UMg8yw1qEc3/5iR1aDuujhJHzeU=; b=Z mF3iPYugU6qKj/U0XOfqj7kTjWE//yP8mj2uuhgmN53KZS+CmHPjd/UnHIZgdPM6 pCPXJF51r2Cm/r+hX+2vQL3VayLd7G31Pna7v+tH5eXYXror4FWzSJM1qmNkjz3B UTFPpPIAC+fgscdJsM1SI9SFiXnCfkmeKPOIE5LzwTeyUnWghBjf4i9eIRcnnaGD zGFk8L3rdIsQtLnz1qo8R4D4YZPMlrjGu/u3g4wiuPo1utm5xRSCBwHhx24b7Tk2 Wqnn4G5YrprRDHpvCaz/uuYZQd7yQ984Raa7gBEcrilFHT9w5aPko32Vr0neprIe snUDOvzQrzs3OL08Wefjg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1669781305; x= 1669867705; bh=Lmsmf4sJSUA0QJZ9UMg8yw1qEc3/5iR1aDuujhJHzeU=; b=l 1HiEqJ5rq0Q7FruTDzWCbA4cYO/o+iQnCw0QxCWGasxIHL5Kwh+zmc6dAsifeSDr zlerQAgtvUBQ7p3xpWOWU1xkEEEs3PqZLEJHkornjr3k28fBeFIma3/SVGVOM5Et jZNOgv0Ue4SYlOF+qizHfXyz0KPixIfPLzqA105qSH6YdJ9Tl5qOb1cIqCILUT+k tLcLG8vATax3568bnorxDcyUf4ndmALY/QkbYuM51VZqS16fSCThzJ6I9n+dRH5N RyeFyVfUiW8vShMeSvmPNXQu9hvuCkU+OzrEe2IfizUhio7afmkheluZwu14vch6 IEczGUMLBOfoJqgpM/2DA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrtddvgdeijecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepufgrmhhu vghlucfjohhllhgrnhguuceoshgrmhhuvghlsehshhholhhlrghnugdrohhrgheqnecugg ftrfgrthhtvghrnhepkeejleelfeeitdfhtdfgkeeghedufeduueegffdvhfdukeelleef tdetjeehuddtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepshgrmhhuvghlsehshhholhhlrghnugdrohhrgh X-ME-Proxy: Feedback-ID: i0ad843c9:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 29 Nov 2022 23:08:24 -0500 (EST) Message-ID: <37362a34-0e97-9c31-08fc-6815790c26a8@sholland.org> Date: Tue, 29 Nov 2022 22:08:23 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux ppc64le; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v2 06/26] drm: sun4i: Define and use generic PM ops Content-Language: en-US To: Paul Cercueil , David Airlie , Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev References: <20221129191733.137897-1-paul@crapouillou.net> <20221129191733.137897-7-paul@crapouillou.net> From: Samuel Holland In-Reply-To: <20221129191733.137897-7-paul@crapouillou.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/29/22 13:17, Paul Cercueil wrote: > Use the new DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS() macro to create a > "struct dev_pm_ops" that can be used by this driver, instead of using > custom PM callbacks with the same behaviour. > > v2: Use the DEFINE_DRM_MODE_CONFIG_HELPER_PM_OPS() macro instead of an > exported dev_pm_ops. > > Signed-off-by: Paul Cercueil > --- > > Samuel: since the code changed I had to remove your reviewed-by, sorry > about that. > > Cc: Maxime Ripard > Cc: Chen-Yu Tsai > Cc: Jernej Skrabec > Cc: Samuel Holland > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-sunxi@lists.linux.dev > --- > drivers/gpu/drm/sun4i/sun4i_drv.c | 26 ++++---------------------- > 1 file changed, 4 insertions(+), 22 deletions(-) Reviewed-by: Samuel Holland