Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 29 Nov 2022 20:37:29 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Peter Xu <peterx@redhat.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        James Houghton <jthoughton@google.com>,
        Jann Horn <jannh@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Rik van Riel <riel@surriel.com>,
        Nadav Amit <nadav.amit@gmail.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Muchun Song <songmuchun@bytedance.com>,
        David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH 02/10] mm/hugetlb: Don't wait for migration entry during
 follow page
Message-ID: <Y4beCdGA3bVzgmS/@monkey>
References: <20221129193526.3588187-1-peterx@redhat.com>
 <20221129193526.3588187-3-peterx@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221129193526.3588187-3-peterx@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tBReMCBayiI5GM7X3W8Ydv1YnjiqWhIUJfZyvzKFaBdbknfbpmuzjWq2eyyG?=
 =?us-ascii?Q?cw2AiXexlVswWOVZYn2mPTD7sAXgCxfACffrouY982wA5WVLxQAI4sKzAoZf?=
 =?us-ascii?Q?f9gstMUdmQd2N2zvOMs5NeFUfpWVPE2SXjkGqaaMMC9YJ3YhT7P7EgRKWRu+?=
 =?us-ascii?Q?1UX0dfnJo3KVnkEa+dLiPjwL8n4YHb0atxcObBoXB8xsrfv4pV46U10jjcOF?=
 =?us-ascii?Q?ga6ITEu0i/wH1lePAu7GFAfnyVFjqdi+/gN9PDuZ7EZt74Fus5aeFHX6Paea?=
 =?us-ascii?Q?Dr+1xauSeG9mHWJDspUqQrI8DViswrY861c59V/bm3hEc3IE4YwnYzIhyocv?=
 =?us-ascii?Q?JNtVNo9LDnsFoNjih5pFzWj9cwqzlf2qArcABPjsMCitS0mkTU86wjHl0Vvw?=
 =?us-ascii?Q?7xjcOq/+W3LkLeiXnzuOT3c+rc0mS6gfrbLZl8Sf9YhU/cE5cvaNQREcDRQL?=
 =?us-ascii?Q?fJkWvQfmA58VZ4BX9rszZnwB212Xk7iv1myO1IQacHGuxFEAgLOVaB4nkh6C?=
 =?us-ascii?Q?KesTUGVUXDRiNl17ZX9HM5uN0drawY70QOaLLs1bgU7U/Rir8yPI7agIb25J?=
 =?us-ascii?Q?b2SATdXyWdhx0NbGYIlVoIMPRipxWH8c7shp27t1o0R+kBknDAT9ENnWEJRW?=
 =?us-ascii?Q?8vEgG/B/gGTPPITjonEmGlME4tLAy2Zle6OGFyJn2P1UYakpgG9BPazbYQZR?=
 =?us-ascii?Q?asIY8nA4sY9KJPGSZWVgJnFuUjcjyE40brRhxnZBGkB4b1V315vedOqeCAvh?=
 =?us-ascii?Q?hL+deIKYyyBo/aTFBlL+Xc8b4w9JFKZ3cHOd+7Hqb37DWbUndD6TzFnYlPnb?=
 =?us-ascii?Q?MhCRqjMnQKRKu9ihuQahVjGDw9+wEG1rutq5Cw5nUeONlDVrD8DsWGNZlF6+?=
 =?us-ascii?Q?WYRq0WOT+gc30Iii2FWRoZyWV2usmV9YNQTFgYqti8910hPqX1V1uJ3nRn8O?=
 =?us-ascii?Q?2dFzbE+gTaSUcYp6xeZJs6M6+W3YFkR0NFxlBpXyPHmjfyV6jOkKVNtsg4VQ?=
 =?us-ascii?Q?X228oFjnDmnkG5YYpTVrIXL/Dan7+Kxs54zylIeyTA4b4YWpq3d8rNJg/N6v?=
 =?us-ascii?Q?zo86COSR4rPshyX7+yyPivIpkvpPS0zZ++gw34zYeyvs/yt5Zdc03v4xz2hl?=
 =?us-ascii?Q?PCwVT9iXyHZ3OBHAA35PJwD/YeRmAWxzjZ9VwL2r4nkcL/lO7r9oUskKvjcX?=
 =?us-ascii?Q?9GVA5lWkzFtwPu3AoXQp7cJjhydm6qbQdNfJGQZcxpIctL2Qom2elrZy5bDe?=
 =?us-ascii?Q?Gs/A+ewe5xXEqZTXLYhSv8mA+B7+zH7h+gxm2sl0ziRxant+jSkQFs/wg3J4?=
 =?us-ascii?Q?4UBfc5GDnkCVv7jlnrGGapR54qh80dFCJ6AgycUh2N3aVxgRghrpfwDGaUoT?=
 =?us-ascii?Q?5dN3XiWxZBJhELOLx6bm2z+NjMhYffw99CsnS0MSl8YovZ/3wuh0SaVyEfx4?=
 =?us-ascii?Q?rzNZuuzI+6eg72Q+EwVWPxI+SyxQPaNu1Tbg5u0K4zyYeTQuqJaaH+Ecj31r?=
 =?us-ascii?Q?RG7N9yMg/iFh4JhrmfB1l1SMVlL2oAqlseisBR5APR41J/DeCsAo4x2ScGFE?=
 =?us-ascii?Q?HJQ3fwHxCRNHBGgzsziQms+5sTonboPUvQG6Xsfs0fMxqmbijC+KNYgjGpWO?=
 =?us-ascii?Q?kw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?WsK+SP9TiFsxIw+mJE86HYhZf3Ng0sXZvljiKWzGJ3aLPYSh0bha5sGhQOMU?=
 =?us-ascii?Q?kg4469leo06kfGW/Rll0pslc89L9KrYxZOi0/DZ26sUsXXpJkJrqIhub78wG?=
 =?us-ascii?Q?W0oNE4d1n8ezMKbIEXIKo0y5wQPldyj7kmCy89Ak9ikMkwblM8FBy2SXpoo0?=
 =?us-ascii?Q?SAt2wrpsLZXttKwwR75DVxEIs0p8v/gM8mBIUXw56R4vM/u2noZ96VUcjEBy?=
 =?us-ascii?Q?opvUW/bTCcoGqbRCcuV2n1dx06xDIVLNF5PKZj+gU2BsCUBsHu1B+ejLDXHc?=
 =?us-ascii?Q?2RlwjDm1RO9ld0ZUt7XDdHkgDxdUbrYCDW/Ri4u4pWCp5vJS3vjuvCril0mL?=
 =?us-ascii?Q?WeWz7NsEgwDoV3NWCR3QC2Jz0GNZPVqiSHoBdwv6AKTMkooUzgCQJH4pW/7L?=
 =?us-ascii?Q?DyLxw47AuZ+ltcrEMUlWl03TzZ4KskQkBr/8iYVTV2roF+DxUpxnbsEIYdYq?=
 =?us-ascii?Q?Fyxk4PRDVbLVD814jbEF2QR0nGCbxtDJpsCBylLh5R0wgiz1s5Zn5u2NC7bQ?=
 =?us-ascii?Q?NAgBN4J11RUO7bAQDYhGiI6luIhXGVBdlFF3pqnUcokB8afHjsQosK/PlzmG?=
 =?us-ascii?Q?ROkrsRWhOVWcU6LGV/EnMgxHuq3cUM60qZH8pS9LC7c0fmgAJdM3uFUf/mqN?=
 =?us-ascii?Q?zkmgHslcaDgVqu/+09hRA7tKdblFfsae/rQ/3wfDe3O694kReRR1Y4AoooRq?=
 =?us-ascii?Q?mhneBjj9urXuuREaXOZ/IWctzMlEWVGUH91eKE6pKMNgW9ae5VpNT+IoWPeX?=
 =?us-ascii?Q?KP9u/y3tOs2RLmmpTki9PlRY9oHikNGOxbbqbRgJIsyfgvxDVYqaxmFdtAxZ?=
 =?us-ascii?Q?4bY3VTZmM3oKpKp+6LhN9Y3Hz457CWIEK3o1yqZyHZXfqnLAgOiX03jL2ec/?=
 =?us-ascii?Q?KsZzu8mvooVSLMWtzS5losI0S/cVkQfN+NyUC4r6AOPhYWK2hsxn8Yr8HN6T?=
 =?us-ascii?Q?t1jtCIaCe2NKpaafpxLcyJXAd28I/YZfOThwWbCg/zJiEd6sJ+RfrnArMdZU?=
 =?us-ascii?Q?extRsM4sx1fm8I6piSs8jvZn1SOyyI+79l9bnqe9TO1+cbH0llo/eUnG8T0l?=
 =?us-ascii?Q?GSPp/pou9UU33ShxwtNRV5iPDb2/WeJUtVev+jy8kuz/XGHY6Lg=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c4eb9337-00a5-4e7e-9cfe-08dad28c987e
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 04:37:34.8750
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xQstKOfQP6NulGmEQXnoAHiAsyssoq+1TAYnJYzIeyJZSDWKflV7UHo9c8zobxUjXrzj4fh/cfO7P3DuY3zWKA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6979
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-30_04,2022-11-29_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 phishscore=0
 mlxscore=0 spamscore=0 adultscore=0 malwarescore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211300031
X-Proofpoint-GUID: VXPiBz4mIIUaz9NTFsIt3SdNxHVM_2xq
X-Proofpoint-ORIG-GUID: VXPiBz4mIIUaz9NTFsIt3SdNxHVM_2xq
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/29/22 14:35, Peter Xu wrote:
> That's what the code does with !hugetlb pages, so we should logically do
> the same for hugetlb, so migration entry will also be treated as no page.

Makes sense.  I like the consistency.

> This is probably also the last piece in follow_page code that may sleep,
> the last one should be removed in cf994dd8af27 ("mm/gup: remove
> FOLL_MIGRATION", 2022-11-16).
> 
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  mm/hugetlb.c | 11 -----------
>  1 file changed, 11 deletions(-)

Thanks!

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz