Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 30 Nov 2022 14:00:04 +0800
From:   Feng Tang <feng.tang@intel.com>
To:     "Paul E. McKenney" <paulmck@kernel.org>
CC:     Thomas Gleixner <tglx@linutronix.de>,
        <linux-kernel@vger.kernel.org>, <sboyd@kernel.org>,
        <corbet@lwn.net>, <Mark.Rutland@arm.com>, <maz@kernel.org>,
        <kernel-team@meta.com>, <ak@linux.intel.com>,
        <zhengjun.xing@intel.com>, Chris Mason <clm@meta.com>,
        John Stultz <jstultz@google.com>,
        Waiman Long <longman@redhat.com>
Subject: Re: [PATCH clocksource 1/3] clocksource: Reject bogus watchdog
 clocksource measurements
Message-ID: <Y4bxZCEAmPnALsRV@feng-clx>
References: <Y32HFE+BaATh9+l/@feng-clx>
 <20221123212348.GI4001@paulmck-ThinkPad-P17-Gen-1>
 <Y4QZzzk+FdGj4AXm@feng-clx>
 <20221129192915.GD4001@paulmck-ThinkPad-P17-Gen-1>
 <Y4az+FT5YjpAWjZc@feng-clx>
 <20221130041206.GK4001@paulmck-ThinkPad-P17-Gen-1>
 <Y4bg1H/HLRLfucNO@feng-clx>
 <20221130051600.GL4001@paulmck-ThinkPad-P17-Gen-1>
 <Y4brjD/xUDlzJ4v7@feng-clx>
 <20221130055024.GM4001@paulmck-ThinkPad-P17-Gen-1>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20221130055024.GM4001@paulmck-ThinkPad-P17-Gen-1>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QndkTU9Bc0lFdWpHZitpTngvUHJpSk5xbVpBREM2OHliYUh4UEQ3NFdISTk5?=
 =?utf-8?B?c2hkRjF4d1A3QmJpVkFxRHEvdWJGb1ZjK1E0ZHFNMXZKT29aYStEMUJUSFU4?=
 =?utf-8?B?RGMrSEV4UDVneDBub0JnVldvWFVFdGxlRHJQUURhYm1HQ0xLU2RTRFY2Yi9F?=
 =?utf-8?B?cm5EbHVjNG9wdFJ6dkxlT3hMdlFnNGtqS0gzdzBoci8yWHpBZmZIeGpzdW0x?=
 =?utf-8?B?b3pra1R4M1A0ZlN0c3hidTQxTzhTQWJybWsrMlIzS1RWdlZVaGx3ODh3em9u?=
 =?utf-8?B?UUpxbXpod3pHWjNTSytCQlNOWW1CQzBNY2h4MitSKy9senNCYUE5R0E0Qkt5?=
 =?utf-8?B?SWRLNXArRkkySGNoVGhpTDJhK3l1RHVxK1paU2NKUG01MDVKdTRPaDgxd1V4?=
 =?utf-8?B?TU5GNmdKaG9mY0tObTM2OUllNUI0YThFZXpCU3VvdDlTQW9uVCtHQjNabTRY?=
 =?utf-8?B?UjQ5NnhJMnhqeFdpSnBxL2NUVDgvNGo2SkwvNXIyekFCK0g0Yjd1TjROakth?=
 =?utf-8?B?VG5Zd251c05KVkIvYjU3TGw2L1gzK1ZBY1NmWW9FRjRJS0R0Mm1vcjhmNHZ2?=
 =?utf-8?B?a1grNnAvRmZKR3E2NGVTODZrelF0VFNJMG04dUNnNkIyRkgwQVpYV1VVODlQ?=
 =?utf-8?B?UjNZM3doY2w4bXN0V2tHMisxWWRtRVQvSVZPMVhKcHN4WmxsQzdPd3NXaUkv?=
 =?utf-8?B?cWx4QmJtZFNNaWdXVGEyRk1PMEdqcEZMb0V3cC8xaGdKM3gvV2l2b1czZld6?=
 =?utf-8?B?dzh3cFgyQVBnM2duRHJLWlJwcCtvV3RvZ2RtY0pBR3lQdjJ6NVhNT2QrQmpS?=
 =?utf-8?B?UG5Xamx0OU9zYkdwZW8wMUptdkJaWXFkK05vOFlWU3VKTytXWnlLYVdscWZI?=
 =?utf-8?B?YTZVZGkyOGdzNW94QWJSUkc2WWU1STRUMkVVU3N0REt2L2NvV3hqcXJ2eFhu?=
 =?utf-8?B?dUI4a3RJUEc1b2UxdWtlRExFTytMQ2tjcXlud1J2Y09za0RzdVAxRUM2TS9C?=
 =?utf-8?B?SHhwdk42UHMzOXcyZVdyemZjbitRQUpVK2Vpd2ZaL082N3gvbjJva1pPODNM?=
 =?utf-8?B?d2tGNngwYjJTQ2ppRVFFY0haV2hnOGNhSnRXNVNjK1JXQ1RrQ1VxRVYrbUJo?=
 =?utf-8?B?WTRRZndnWWdDS0Q3Mk9nLzlaVVdtY1lNU0hEVVpjL0l6UXd4ampiOXpRR0VD?=
 =?utf-8?B?SWxmRnZOV3V4ZWpQQVljVGNVNU9YdXhZcTZNT1crdGpFZHM0Qkx5NDdKekVZ?=
 =?utf-8?B?UjFQOWxxWXlRYnJFUEhmN1Z0a2E3VzJySmJTL1lCZXJGcDVLYkhxNWF1bGhm?=
 =?utf-8?B?cGt2MlVPb0gzajdZWEJ2T2tRa3ZEQTI2V1dKbDh1K0xtOHM5MzFyUnhIRG93?=
 =?utf-8?B?TmNaK2JnU1JvK0dvR1hzM01qRHhvaG5NdnFIc282NFBxRGdZN2ZXUUVZM1U2?=
 =?utf-8?B?ajZudm9BeEJWZFp0dFNIdG1PV3FxbElyU2Voay9lYjVIUkFwcjNyWElFOXQ4?=
 =?utf-8?B?V2NzZGtZZER4b2hVN2tEN1N3NUVJVXAveGdHaUk1eUJZYW9ZU3Vtb2pCcm9D?=
 =?utf-8?B?Q0pjeDIySmZVYjBuMGo0VDI2VXVOeHBmZTN3V1JqajNGZzZPUXRzZ2FsbDBu?=
 =?utf-8?B?VVhtTzQvdjVzN2xMSkN1dHQxQ3V1UC9vVWljVy9CS25Tdm9KZ3NzOEpkSFky?=
 =?utf-8?B?N3k4aXBtN2h6aUd3U0doRW83SXgxRTJlekNqaitCL1dXQVB3QlJWM1NMUzJU?=
 =?utf-8?B?UUJnUEtOdW12cVRFM0gzOFlLMlJ0WFZwN1l4aldqVms3Y3ZuQS9mR1AxdlIy?=
 =?utf-8?B?WHlBM0pBOVF3Z25YYk5MWDdqMTMyQkdDeStsQUFReFczQnRkRi9TMlFVTHVE?=
 =?utf-8?B?V3NhdWhYMVlRUjFKb0ovR25ObWJxaFpoTVBYdjIwR2h0Qm9FUUFraUJ5QW9i?=
 =?utf-8?B?SGNCVlBMMUwrdlh4QUFNcVZ6VzltOTBxcUZQTXAzLzdYbzV4OElKcTV2U2dP?=
 =?utf-8?B?UXVrUm1iNU13M2U4Umc5THZ0cDEyYlNndWlQVjRvYTNVeXo1VGFoTWVMVFk2?=
 =?utf-8?B?eVFwWElqMGpHWlArZEJWQmJobTI0aDVkUDhYVkgxMVBvNlJhUlFXZGNBSDNU?=
 =?utf-8?Q?FRfMKXWkmuvrQqO9uNoIVVPzb?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ad43044e-b93f-41f4-62ae-08dad2988eb4
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 06:03:09.8644
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MZIub1DtjJ97KQKccKBVTCbKX1PaI50I0tVtPIi5Q1Rqdugstf252irIDG8SC2eEKoXmu3EIrdFyjR9LhxLF1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR11MB5709
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 29, 2022 at 09:50:24PM -0800, Paul E. McKenney wrote:
[...]
> >  
> > Great! As both HPET and PM_TIMER get the same calibration 1975.000 MHz,
> > and it matches the 40ms drift per second you mentioned earlier, this
> > seems like the CPUID(0x15) gave the wrong frequence number.
> > 
> > Or unlikely, HPET and PM_TIMER are driven by the same circuit source,
> > which has deviation.
> > 
> > Either way, I think the HW/FW could have some problem.
> 
> And this time with your printk()s:
> 
> [    0.000000] tsc: using CPUID[0x15] crystal_khz= 24000 kHz ebx=158 eax=2
> [    0.000000] tsc: Detected 1900.000 MHz processor
> [    0.000000] tsc: Detected 1896.000 MHz TSC
> [    5.268858] clocksource: refined-jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 1910969940391419 ns
> [   25.706231] clocksource: tsc-early: mask: 0xffffffffffffffff max_cycles: 0x36a8d32ce31, max_idle_ns: 881590731004 ns
> [   32.223011] clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 1911260446275000 ns
> [   57.823933] clocksource: Switched to clocksource tsc-early
> [   58.144840] clocksource: acpi_pm: mask: 0xffffff max_cycles: 0xffffff, max_idle_ns: 2085701024 ns
> [   63.613713] clocksource: tsc: mask: 0xffffffffffffffff max_cycles: 0x36a8d32ce31, max_idle_ns: 881590731004 ns
> [   63.637323] clocksource: Switched to clocksource tsc
> [   64.673579] tsc: Warning: TSC freq calibrated by CPUID/MSR differs from what is calibrated by HW timer, please check with vendor!!
> [   64.703719] tsc: Previous calibrated TSC freq:        1896.000 MHz
> [   64.716816] tsc: TSC freq recalibrated by [PM_TIMER]:         1974.999 MHz

This confirms the tsc frequency is calculated from CPUID(0x15).

> What would be good next steps to check up on the hardware and firmware?

Maybe raise it to vendor? I have no idea how to check thos black boxes :)


> (My next step involves a pillow, but will follow up tomorrow morning
> Pacific Time.)
 
Really thanks for checking this through late night!

Thanks,
Feng

> 							Thanx, Paul