Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1980738rwb; Wed, 30 Nov 2022 00:07:19 -0800 (PST) X-Google-Smtp-Source: AA0mqf69o7M4cTNVPRWzHkKzDqmLwuIQsSb4m81kL2QJkv9yBIPRS1zzUdjYgtyghkiFojU0C1RC X-Received: by 2002:a63:f962:0:b0:477:1bb8:bbf4 with SMTP id q34-20020a63f962000000b004771bb8bbf4mr35805382pgk.19.1669795639053; Wed, 30 Nov 2022 00:07:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669795639; cv=none; d=google.com; s=arc-20160816; b=Xxxb4QXmqu95ZYDeh4nl6rZ3xMPVegdBSWdNHuKvIPFZ3nSev5Fs2n0zfyVo4Y5ODU a3zMlQGIkwlsp5TgiR4OlYNEKt3TobdQNNTa0qs91/5roY73OO4VDR1AtJo465/tl4pl bmbPs+3rc67aYKXWq3q1KU2jmxp9V/lQW8PrszvHuFyXAt+kM0jP3Ggv6KWmACRFcOwa 4kuQqU/5VMfIN1rHrUZfXHndNPsQWU8kpW37E+9JJsx77OKqZjghZp1fhY9QDjkXiyTq 7HauIO72fK+TCIpnpZ1ju0lb3N2ym3RcKjSUqOXYBsdalw3wMLiCEwUN/hCTyRlmplVI YZuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:mime-version:message-id:date; bh=pDTF6os7HSbN4HQl6vOa/s1cwsTAKi31mW3QJQmOKeA=; b=AKYYMzRkoqVl+tiKXp/4FFvE35ok6a7dJ5z6VS0O6Va6FqYSZ42pHyyWA7zNHLyIuZ aZOIHPQTGXIZGUd0tK5uEJ5fubQVtqcE0M5/AYgxDR6H/k2MT9LRDDVgdyUrpKWEZ1qP 8SdJk0hkv2QtmqYUaLbANUUTbx6dHrl1lJNM8uPMuX91DTx9LXn9NG39IbwO10gxolUq TccVFoslcxq8neO5QHOzyX79UUFoc0+tTCP5T0Js2LGtdOq8W3Ko2abIT5LqymtmjaIT JFCcrqLiNEf9COzJBM3faq+jqGT5o4CJ9LGSpVWgXkNtNQTAg7ntHuhdnnBXmNQIl8oA V86Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c23-20020a17090a8d1700b001fe1c9436b1si959114pjo.86.2022.11.30.00.07.06; Wed, 30 Nov 2022 00:07:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234269AbiK3H4Q (ORCPT + 84 others); Wed, 30 Nov 2022 02:56:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232674AbiK3H4O (ORCPT ); Wed, 30 Nov 2022 02:56:14 -0500 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAB4660EBF for ; Tue, 29 Nov 2022 23:56:13 -0800 (PST) Received: from mse-fl1.zte.com.cn (unknown [10.5.228.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4NMWjm1vltz5BNRf; Wed, 30 Nov 2022 15:56:12 +0800 (CST) Received: from xaxapp01.zte.com.cn ([10.88.40.50]) by mse-fl1.zte.com.cn with SMTP id 2AU7u4wB019582; Wed, 30 Nov 2022 15:56:04 +0800 (+08) (envelope-from zhang.songyi@zte.com.cn) Received: from mapi (xaxapp01[null]) by mapi (Zmail) with MAPI id mid31; Wed, 30 Nov 2022 15:56:06 +0800 (CST) Date: Wed, 30 Nov 2022 15:56:06 +0800 (CST) X-Zmail-TransId: 2af963870c9635e6ca36 X-Mailer: Zmail v1.0 Message-ID: <202211301556064978448@zte.com.cn> Mime-Version: 1.0 From: To: Cc: , , , Subject: =?UTF-8?B?W1BBVENIIGxpbnV4LW5leHRdIHB4YTogUmVtb3ZlIGRldl9lcnIoKSBhZnRlciBwbGF0Zm9ybV9nZXRfaXJxKCk=?= Content-Type: text/plain; charset="UTF-8" X-MAIL: mse-fl1.zte.com.cn 2AU7u4wB019582 X-Fangmail-Gw-Spam-Type: 0 X-FangMail-Miltered: at cgslv5.04-192.168.250.138.novalocal with ID 63870C9C.000 by FangMail milter! X-FangMail-Envelope: 1669794972/4NMWjm1vltz5BNRf/63870C9C.000/10.5.228.132/[10.5.228.132]/mse-fl1.zte.com.cn/ X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 63870C9C.000/4NMWjm1vltz5BNRf X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: zhang songyi There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure. /drivers/soc/pxa/ssp.c:150:2-9: line 150 is redundant because platform_get_irq() already prints an error Signed-off-by: zhang songyi --- drivers/soc/pxa/ssp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/soc/pxa/ssp.c b/drivers/soc/pxa/ssp.c index 93449fb3519e..7085901b4e4b 100644 --- a/drivers/soc/pxa/ssp.c +++ b/drivers/soc/pxa/ssp.c @@ -147,7 +147,6 @@ static int pxa_ssp_probe(struct platform_device *pdev) ssp->irq = platform_get_irq(pdev, 0); if (ssp->irq < 0) { - dev_err(dev, "no IRQ resource defined\n"); return -ENODEV; } -- 2.15.2