Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Chaitanya Kulkarni <kch@nvidia.com>
CC:     "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        "damien.lemoal@opensource.wdc.com" <damien.lemoal@opensource.wdc.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "vincent.fu@samsung.com" <vincent.fu@samsung.com>
Subject: Re: [PATCH V4 7/8] null_blk: add param to set max write-zeroes sects
Thread-Topic: [PATCH V4 7/8] null_blk: add param to set max write-zeroes sects
Thread-Index: AQHZBEp+OsGAtgqQokWWJUgXPnCtJa5XHaaA
Date:   Wed, 30 Nov 2022 08:09:50 +0000
Message-ID: <20221130080949.3hzjio5x4hagvgga@shindev>
References: <20221129232813.37968-1-kch@nvidia.com>
 <20221129232813.37968-8-kch@nvidia.com>
In-Reply-To: <20221129232813.37968-8-kch@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zRPBEImJ5zCckyKa+2RJqInmIow1cB+tXxRX7yTwiLw+OV42Gvju4WlC0LrI?=
 =?us-ascii?Q?6NhK5iKmFlikJ+MD3Jh4MWYg7oo5vrmo58z+/D9Oxrs04B5lkFLKPG8hlM52?=
 =?us-ascii?Q?GgZlqibrrxJsSCsCMsOeHKHlzvQLpBLCvGL41CJJ8GAc47GO9wIBbYAS1vzF?=
 =?us-ascii?Q?oSyVVUeVumUc2bZSKGfM/WYxu8sudrBoNV4NhHi2m3eldV+ffxU1Pqem2vA+?=
 =?us-ascii?Q?/YXzWHMz4B5X0qmaYNEmfG1ao9s/3EAtkResCoU3X5+TsFz8Ya8Ym6C3UgmR?=
 =?us-ascii?Q?LQGKI7IRZyuhOpclizc1P5TmNdhB++Y8UCKHrRLwZ8fiOWZxgqPn2f4A706y?=
 =?us-ascii?Q?IEBSoLghE0dPNsdYvM0xILtJedyPYkxeZz2hRobMmCR0aevhTTW2iywfV9/N?=
 =?us-ascii?Q?qDKd0LY8RapXPJfaT+BWe1fMa8ofXQPLDhwO4n/Za0/aUvaeq9yzMRBQJMOK?=
 =?us-ascii?Q?NrNLu6RkwoPXBLQdPsrxoFUo8ZG+SZqwL7HTBy+lObHPXSKFt8w1dBMmeUMZ?=
 =?us-ascii?Q?i16jKz3UU6kBtPN7Zhrgmf7apB1WBZCMoF0Q3bzp7HmpkELWbzVIrkET6s9U?=
 =?us-ascii?Q?BoptTXSu2B3KAzgo4lMRyd+pJd70ToPCdhxJLeIYhv4uGxoc/1BKhKq0tK4D?=
 =?us-ascii?Q?kVqa8EdHEB24cTjduUp10lzSq9AhHczr3Mds8LmKbc0u++pN1EZ3EprltJjy?=
 =?us-ascii?Q?W8ticz2qFn6ualhBD5LicmIWBbR6fedAD4Yn6rQ4S9qErVDgCy5Ven9XBM8w?=
 =?us-ascii?Q?xAiyw7C8oMXkCz/x8w7ioVOZ5nbEj6+2jUxqDoql3QQkvYzrIQOUtpH8j/N9?=
 =?us-ascii?Q?Q2OaQ5K+Naezr34pABYAoDWjTUFnlH1Ya9piN2KNDTWODiVNBCNZYDYMu02o?=
 =?us-ascii?Q?C8K9zU89OCO1rPvwL5Mf7ligCMriGxhyhE4VFO9l7CbNpf+UHFKObPtinRWN?=
 =?us-ascii?Q?KjWP1fK02rMQykddeSaVN3+mAU0i3rB057/TEs4v3UfbuVTRq9+vXF0NK8va?=
 =?us-ascii?Q?sVz6h8G7jXVcwmZZxVIBE8ujtGjkbMTOKIoKLsSKNtK/VuoUYRsbGQh4tGJ7?=
 =?us-ascii?Q?Jlbh8tUNfeCjCTzmS/gfvgMlNxdo5XH5ZV6k7GE2aVd2l09MabkNUA1a1syZ?=
 =?us-ascii?Q?AV2nj9tonUSkghTBtE/+kYVwDkRDvATT3SLV6/M+5RWRzdPniq2dhHwkNabM?=
 =?us-ascii?Q?ztOZo1lAHDSyK/uAs1eQOhNUgVw3ICAKvpnqlei79IsAF+h1cWpb8WERu6mF?=
 =?us-ascii?Q?tMKy5v8HbJvSFO0KU80JF5+JAgC8h19T4gWD3PPO1zBjgD/diuFiW8LBRQR2?=
 =?us-ascii?Q?zZHfp/2dGKJlKr8f52rDVBnUuA1yt3waJZKgPSXn5NglYmkghcKQahxQvc34?=
 =?us-ascii?Q?SDI1CDn33I37xChFPJLMJf201lxoGgWOroXqq+cJqNk23gVOoVGpBexDmtbb?=
 =?us-ascii?Q?9DoglYuW4RmHesmPXRzJT7VFxwLbhxNILYKf7CwtUoPVyH+TAC/4WMsR7m9P?=
 =?us-ascii?Q?LHitUmmxjRg/Xlsufh1QNXoBiMsf0wQMCHNNtA2s4OST75TXgvcuTdKaKVv3?=
 =?us-ascii?Q?FBZ/KcWxp96JrhbQYoeYF4BI6z7WjN4hlZUItHZg1AXtNKAs4M1KtFVxkUD2?=
 =?us-ascii?Q?RdoXMcHoKC70q+5j+WV+Vig=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <8BD75020AD37324A8FCBFC9671A811F4@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?xHGJcd+BT4Gy9IvCQENnWHI0GWyi7NP2TBfSqVuDUP3Koc1WW5e5GlWlorxg?=
 =?us-ascii?Q?dIKxrM5YvMZGQHz0AnrW07WECd5Vpmm9cwZF97WLe/3i8ZdZdVoAlIHjmB3n?=
 =?us-ascii?Q?LtL1XCYO2bZ+5yxsOWQryw8zXZmju6TWbsptF+HiV6g5N2l9ZGvjuxRnnxpQ?=
 =?us-ascii?Q?rWtBWuU3UsMrzJefOR7uVEHislICpXY5BIoWSPa9Q2vMcNqD9j7619cxXcMl?=
 =?us-ascii?Q?kN+hdl+xhxEv9DikzB9WGyLv1NGJOgh0lYJSELF0JlLVTshyigEmZq0VyhK/?=
 =?us-ascii?Q?pqu+ETTMf8xRaKlQ6i7lK6OWhR1uHccBXaTdbO9FTSgLvJ1sdgWuBXOGqMDW?=
 =?us-ascii?Q?2yjz1zRsaKOewD5gCLPBy6HaYaUcRayWuvuSJkZ4qqGnga+Rk4Vc6e9f68Y0?=
 =?us-ascii?Q?lwwYuhyP1UJ8tq6qxUMjlVW53N10A7YHELKoVIBdK2CUzvM99FTwo22QGQ+z?=
 =?us-ascii?Q?UclLJMmZ2MRhnhxtqlPwNoKYu+UYOrVsVjdNJpPZ9SN2MDu5AJuWBoqDiKpe?=
 =?us-ascii?Q?wHYrrURqTw3jVDlY8TSj1y0uIIuK5WsPOXGq1fKDvikGecgl1QLZdBGu0ydj?=
 =?us-ascii?Q?ba9+j2td5T4Lnj6yAKB/YuWmOvXQoeHpNyywJd0IzB3Hq0veI/LJRpzcHd4V?=
 =?us-ascii?Q?qopsbNLvz9kjjgCxs1y6t793BIxYWtn7Ib+ETxAVvxCZynjweDHQUQE91qZR?=
 =?us-ascii?Q?ZecNb3ArbXnxNdwPDGm1fhqbO2od/apVf+mghnNTH8ovuQToLjmqEUdca547?=
 =?us-ascii?Q?qIiJigfd9lNNNhXLsVHPJo3+FkyPV2HV4Ku0RbI6SK093buN+OOMrLQ8CyDy?=
 =?us-ascii?Q?ga0GC/NeL2DYIjbhvGIkkHLLFPLKtkWH0nz6v7JPrwSSdiVMnYqGALzGnrVp?=
 =?us-ascii?Q?S/8kx8aA1UTKjbOy8dp5KTFc8q59fw4dzWteB9TXbS/65nRYEB59cPqOWIIL?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 95f59663-94ff-4131-5ecc-08dad2aa40ed
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2022 08:09:50.1761
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: D7kJEY0ePUVbIZx+tWStST0W6tP2FTrozuHiyq4IyDXTgYS+Qd2uHcDEqK3EpqWfimcX+Cl46l10sWhPya1Cr9bnGF8mRXZpikOxCt6y7Vg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB0411
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Nov 29, 2022 / 15:28, Chaitanya Kulkarni wrote:
> Instead of hardcoding value for the maximum write-zeroes sector to
> UINT_MAX >> 9, allow user to set the value with newly added module
> parameter max_write_zeroes_sectors.
>=20
> Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>

Nit: it would be the better to note in the commit message why the default v=
alue
is UINT_MAX >> 9. Other than that, looks good.

Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>

--=20
Shin'ichiro Kawasaki=