Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Chaitanya Kulkarni <kch@nvidia.com>
CC:     "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        "damien.lemoal@opensource.wdc.com" <damien.lemoal@opensource.wdc.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "vincent.fu@samsung.com" <vincent.fu@samsung.com>
Subject: Re: [PATCH V4 3/8] null_blk: initialize cmd->bio in __alloc_cmd()
Thread-Topic: [PATCH V4 3/8] null_blk: initialize cmd->bio in __alloc_cmd()
Thread-Index: AQHZBEpkNBwRKT63k0eaQfKnUma9ha5XG1yA
Date:   Wed, 30 Nov 2022 08:01:37 +0000
Message-ID: <20221130080137.r75sokfluvn4ootr@shindev>
References: <20221129232813.37968-1-kch@nvidia.com>
 <20221129232813.37968-4-kch@nvidia.com>
In-Reply-To: <20221129232813.37968-4-kch@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mPY1T9bVB5P+NBQ05Un+vETHPew5/yC2LJIC+cCo3VVnHhrqdWpTZs71XMKg?=
 =?us-ascii?Q?WJy7KdBgr/Oed4d3Gm29RV49sGhe/RTHqPQLDzTqSydSFjoeAByC+z1Y8TZc?=
 =?us-ascii?Q?S9t4IzDADxgPFbXyAegSE9b7QCVBhmaDva5D666GrAs8jFwZDOg1Pn6U54PA?=
 =?us-ascii?Q?tzxXDJLKbMwfc3J/CbZMpixWCZh1/yfcW4s7SIXNdjX2W6eSr/K7TIVQDhsY?=
 =?us-ascii?Q?MK0vcPjMa91QVDU1x/AMhvtp4tj/QI+q0N/c4Ms1FlOKDM+S5LfB4o9/RX+B?=
 =?us-ascii?Q?2MJLD+XyX/zssIEqgtL+/+pE2yfdYRC2FzIjtA1sppwnLAYUtpkZ+pOFKpYe?=
 =?us-ascii?Q?UBdGuz1NqQQ6BSrDuPh8kWpJK7THebvAP/E6VPzGYsCe6m/n8J5UGEZUpxds?=
 =?us-ascii?Q?+5cXehYhhgbQqFeGJ6WFz/TA00hwGso6WlGp5EqKlsNbPMN0LzWfQo+sw0iW?=
 =?us-ascii?Q?Kkhytx8dun2jzS2H6m9T9uVJjPqDrW56Y4M/35GLHRdyVy17yUjYS1TkxEeO?=
 =?us-ascii?Q?TBRtH9Myrw9RbKjGQ4yoScJAhrqxWW9+RMJTn8tPQYqkmDcFfvXwOf7V6VFq?=
 =?us-ascii?Q?0s+/dvNvY+OVVp6DP9Wk3QE6amzfLsHDfzNt8JMFEu6TGNeb0gx4BN122ZaG?=
 =?us-ascii?Q?azm/7YxnT51jimD+OxT3xIQvotFQ/y7wwxo09BcyK53Q2hppAgs4nA0LaB+T?=
 =?us-ascii?Q?178NfVK/UqWaWC2JaPSWaiLgX2iOI2a6UPl81NH/5S5qRQ50+JwPG5nbHp58?=
 =?us-ascii?Q?OmYvYDqmStqCEUrjf7uiIGKul5YyMl/cocIKY9f2/nHz6hqfzNPU66RmxwMu?=
 =?us-ascii?Q?0jXpfzSVzy9Zre03PSPwrxgW5iydo2P1Ndq5wskGgS/dGGpm4joh9hfLWao0?=
 =?us-ascii?Q?1/04CV53UVDFt3y1hHXWamerxwM8uI5YD7Kx/ksIoFAzb9LjNGDctlexOQ3o?=
 =?us-ascii?Q?fqjUReiv48QgCVvwHH8lwFEHbedPJTFAXJeVeLhcCQ8jGqIUfGCVMmCMnPSd?=
 =?us-ascii?Q?ozjvmWnBv5gqDDAKwuDF9mzYW6FLVXzfEhjTu2MBFks7XX4aDsv3XWi5z7Z7?=
 =?us-ascii?Q?KtHI4tpFvNQ+IvnKZB1RafAlrAnezNF0nwtSDWrhKkPXMKOUJvJ43uAgp8NW?=
 =?us-ascii?Q?LoU+qo695uGvKvPjHaibCe3xbn/g8i+3++QOezcw8mUMz0EVBQibNd8pPT+z?=
 =?us-ascii?Q?8M26GCbFCHyUtt0QTuVeFefKaGc1BQcX3/OaumcUyVuANUKME+XI/IzupFH3?=
 =?us-ascii?Q?Ic+cnd7sza8kKZ/Jb5mK/Qil7C89R/xAB25nn2BUDt9WdzHEksOzVGkgun0D?=
 =?us-ascii?Q?U6YGMvdPVdrH9+5NPc1VNw4AWzVny6J94woUJlsC3om9Gsx6fWU6+/sAWkFU?=
 =?us-ascii?Q?O9FD3zDwuqm1CJ/ud6Ct/JFDXH04b9G+0ymQmm8QZ1vl0N+3UUK/HdxZB2BO?=
 =?us-ascii?Q?LsaUB6c9e+Xhxf0lpbe/0okA/9uGAC5OcWLmw33nch1kb2CmrEye/MnWegVD?=
 =?us-ascii?Q?lfAieJFnyYOHYOig3nkvx50tHgW/yosIZrkfhryQJbezalXqCtpr9JmYj1Og?=
 =?us-ascii?Q?1GI/Cc9nDwgV5og02I4hWh0XbkdQQj7O71mzgQDjGIZOGAeoD7aS0VPumng8?=
 =?us-ascii?Q?aHiJSkoVaZacX1Q8x7W6tNo=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9CC72DE038DEB04181F7F2931C672D7B@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?h34myKGJh00X7rSmckZMkVQQYW5jTWRyy2JLsCHoWDZ8oIi1t2FkaqpH4vA2?=
 =?us-ascii?Q?vnlZ0SJerS78wdofhZX5/mpnCl9NCIOwu3QkJrA9pEGoEGRvkzko6Onoc//C?=
 =?us-ascii?Q?UoFrl+JrlToUY+RDkiKm8KmGSlvbX+oFPsIqd8gKhZ5iSXUj/m+kx9ULQUaE?=
 =?us-ascii?Q?l2TiMN5AirSBPGYxDHA22tGhUjPMuf7QGvxDvA26w/oaTBduSrMbg8WycRQ0?=
 =?us-ascii?Q?mPTVpkjd1P2+bBGEzFY22hSOzDVm/nWvvjPXQbFIXNLYEXsfKqzZ1LVh/GVY?=
 =?us-ascii?Q?1klrRqNZ9K/+LVe5TWQfwdCf2VUSqaxmTuvUHPw+f2bC+P8CxFjEYuyv8a64?=
 =?us-ascii?Q?Y/orrFlteUwd+n2T5ZRtW1+uzdh+u8ZY2ytDzROR+3ir8/evr8H6W32hN0JA?=
 =?us-ascii?Q?DW5OfBkAXnuWyetmWC4rFvO3qvoSbl+tlRpNgLbe/8AjTVUSG1zCW2AEk1qq?=
 =?us-ascii?Q?3CqALgXSib7qlhNGJQuS50VmuZRzhaHLqJclVNWl10QqWnqtaZhFCnP2DyhC?=
 =?us-ascii?Q?InQGWmy2P8x/LXVcBGfm+BgmRUfb1Q/kBIxENgvrdupYanBcYFU+MUs/SYZV?=
 =?us-ascii?Q?Y96McIesHUgpmpCiFNP5bGj+NqboIApa7ttccFeIGgcxAe664tMgxiCejSQ5?=
 =?us-ascii?Q?q5Qf+M3wEbuG34ehUiZo7qsqRYxN5xlzs/pnJiuuhldj/sbnOy8LCzMr5g2s?=
 =?us-ascii?Q?SzOaf3fkXcM1YdFkeqCy/QkicVblGkd7WJPNOWb+u73msfKvGIsb9CP+jkPM?=
 =?us-ascii?Q?K3MW3ijYMNoyYdzaCZb6rzciu4JYdSIci4HrtcYd1SXHXbAl/iTJ9KPDgGCp?=
 =?us-ascii?Q?3GPabpYg0MrW+mAT0MGSXOtGf2Mtl074TSdshVziZ1mQV57iGRasIW4MPL4w?=
 =?us-ascii?Q?VCtQuVfP6eKAuiEelNA85D9LyhTSoCMWh6lbUFKGfKH7Tw9eJT8wOl8mPkqO?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bec20963-734f-408e-9f2b-08dad2a91b90
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2022 08:01:37.9645
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DnjZsv3+ugx0scxgR6D1AOQD2A+pfHheE+pfBMzGH9dePgjyKn66RR3FQXXffxPgpmzeotY1AUCY5Ln5M3yR9EhyaNaEGsOz80PdqXiQfII=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR04MB7336
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Nov 29, 2022 / 15:28, Chaitanya Kulkarni wrote:
> The function __alloc_cmd() is responsible to allocate tag and
> initialize the different members of the null_cmd structure e.g.
> cmd->tag, cmd->error, and cmd->nq, Move only member bio that is initializ=
ed
> from alloc_cmd() into __alloc_cmd().
>=20
> Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
> Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

Looks good to me.

Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>

--=20
Shin'ichiro Kawasaki=