Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221124003351.7792-1-hayashi.kunihiko@socionext.com>
 <20221124003351.7792-3-hayashi.kunihiko@socionext.com> <CAMuHMdVH+amC83uMBpsCebaHd2EWp1EO59JNcgRTncbNGNNRsQ@mail.gmail.com>
 <6c423f87-1187-b2d6-8b70-c8cd709f3ea0@socionext.com>
In-Reply-To: <6c423f87-1187-b2d6-8b70-c8cd709f3ea0@socionext.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Wed, 30 Nov 2022 09:46:47 +0100
Message-ID: <CAMuHMdWa06ND-Tud1_bYTYAVbmo1qMnU3i0bETZo6FVehvLZhg@mail.gmail.com>
Subject: Re: [PATCH v3 2/2] spi: Add Socionext F_OSPI SPI flash controller driver
To:     Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Cc:     Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Hayashi-san,

On Wed, Nov 30, 2022 at 1:47 AM Kunihiko Hayashi
<hayashi.kunihiko@socionext.com> wrote:
> On 2022/11/30 1:49, Geert Uytterhoeven wrote:
> > On Thu, Nov 24, 2022 at 1:36 AM Kunihiko Hayashi
> > <hayashi.kunihiko@socionext.com> wrote:
> >> Introduce Socionext F_OSPI controller driver. This controller is used to
> >> communicate with slave devices such as SPI Flash memories. It supports
> >> 4 slave devices and up to 8-bit wide bus, but supports master mode only.
> >>
> >> This driver uses spi-mem framework for SPI flash memory access, and
> >> can only operate indirect access mode and single data rate mode.
> >>
> >> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>

> >> --- a/drivers/spi/Kconfig
> >> +++ b/drivers/spi/Kconfig
> >> @@ -906,6 +906,15 @@ config SPI_SLAVE_MT27XX
> >>            say Y or M here.If you are not sure, say N.
> >>            SPI slave drivers for Mediatek MT27XX series ARM SoCs.
> >>
> >> +config SPI_SN_F_OSPI
> >> +       tristate "Socionext F_OSPI SPI flash controller"
> >> +       depends on OF && HAS_IOMEM
> >> +       depends on SPI_MEM
> >
> > On which systems is this hardware block found?
> > Perhaps this should depend on ARCH_UNIPHIER || COMPILE_TEST?
>
> This IP doesn't depend on ARCH_UNIPHIER, so I expect that it can be widely
> applied not only to ARCH_UNIPHIER.

OK.

> If COMPILE_TEST is required, the dependency is like SPI_CADENCE_XSPI:
>          depends on (OF || COMPILE_TEST) && HAS_IOMEM

While this is not a hard requirement, it would be nice to have.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds