Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Chaitanya Kulkarni <kch@nvidia.com>
CC:     "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        "damien.lemoal@opensource.wdc.com" <damien.lemoal@opensource.wdc.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "vincent.fu@samsung.com" <vincent.fu@samsung.com>
Subject: Re: [PATCH V4 2/8] null_blk: code cleaup
Thread-Topic: [PATCH V4 2/8] null_blk: code cleaup
Thread-Index: AQHZBEpe5dDfQCkPMkCSOkWljl0aN65XGy6A
Date:   Wed, 30 Nov 2022 08:00:59 +0000
Message-ID: <20221130080059.dwyscjvro6bcmfj3@shindev>
References: <20221129232813.37968-1-kch@nvidia.com>
 <20221129232813.37968-3-kch@nvidia.com>
In-Reply-To: <20221129232813.37968-3-kch@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DxG1RcWfMZd4S/5o1Sb+p9UrqdsQTPsvxUXl0qQZJnRz1Os/VF67w907+uWA?=
 =?us-ascii?Q?s9wDGRFrFbnODZj+zs8DZpRCainTPr5hK9iCkZ4I6Lbb8eH13W1qMIuznN6+?=
 =?us-ascii?Q?qaHekZ/8JQ0dB/inYRJeHElpViuqbKuJSZkoC+DiGkOwDLFshNFUewr4znWn?=
 =?us-ascii?Q?jL3ZBw9u/LnrCslmZPFOV5tI8dpgI9EwfVOZunCK+HXZC+YkNj7W9TmZQXW6?=
 =?us-ascii?Q?n+96zf/YV4LeXkKMKxzsEzoZeoe/adrgZZife0onswPS0KsMHhcJLdbAqQUj?=
 =?us-ascii?Q?cfug823YAy/y1cPuTr/9EDB+5ijZqn4ao2hb5nckN+WFfKTJidIN72e6F/67?=
 =?us-ascii?Q?o0R5MF/pZHlPykCKC6vGuTl3eXdTISCNWv4zWdBI4vmKz2mHOoTlKYGT4W85?=
 =?us-ascii?Q?LHm5uwAaCwBDt+YYes8EQ6xSuE8s1i7c+8bsP0m7s2sCp3pTV/7ALvPNilQC?=
 =?us-ascii?Q?eA5pUTgBjBR1ddrwjBRR0ZkauBNCh0ANpnqVNM26n80gb4BMDQOjIWOUBpUl?=
 =?us-ascii?Q?RPsXdiRyEMhQdVNcH8g5F7TkpMTxCnJ28yqSTpX6EH/tiBofnMFerUr1zn7p?=
 =?us-ascii?Q?MStmshFyZp0QZbm1fPkbqzMIOcuDVFDsCpQnHktOvRp9dWicgnyuJasOb5NK?=
 =?us-ascii?Q?tCif/XKBVRdLL9PlUfYKlWtmIkq0Rd7uADhgukuVs9uhMRCbWqznbmCh5AcT?=
 =?us-ascii?Q?5waMfauhzbOzeQVngLdumbYvJh/pEqlKoiy+RcbbZg9SHMSzSRy1GKivdJJ/?=
 =?us-ascii?Q?RHNaDvz4f5v5zQa7bWTmUEb0iulrEFhfPk4uLkz5XHDJNfVv7wisVq5yWOiw?=
 =?us-ascii?Q?D0KGWQRAya07eZwz4ycOa+nXRawL7sI9thIG2z9lexpoRjToUHhTGYHaIJtO?=
 =?us-ascii?Q?zVFrQX/qJp8lBaAq6gaBXkCaomvg3ifjgxt3NuAIEOgqU07skxjmwpkLLzbV?=
 =?us-ascii?Q?k0lODeD+8Tzq81+Cytbon0xp5D186xxE88p2WmmAHvy4DecRgOmCPhHuT7hg?=
 =?us-ascii?Q?1zS4knAUK/5FUI9LXXSZ8t0S8suGbUEk1pP9T55gjSlxvMhRYliQ1JG7CKbI?=
 =?us-ascii?Q?zTRnZV3T11IbyRhfDVJ2bkBiI5uMB/JjijwuZMBrIJfRhaYJqd1A5I3cLu/3?=
 =?us-ascii?Q?Jxu99f9lUE0hFbaSt8ClI6rQqIFgdadGNMai/KGtdXS9QN7kVvKDXxVqFSJ0?=
 =?us-ascii?Q?0PIeUsBiMtP3fsyOZdWxzkDjVelQFuCAsCFyr2ws6WJcWTdGzJM19slIY3wy?=
 =?us-ascii?Q?VbAEcY27ULh22u7GfhGMOyf6eIVHvDKWMt7erPR8izqCs/TDZSsj/HY1oudh?=
 =?us-ascii?Q?2tocDIxHMbons2BFIVRrQ7+wJI6Cnn1wNfJGnYCoApD70JGJX+en3/E+3HTy?=
 =?us-ascii?Q?FFRwnigL+Gr6rELH1ZqOKdRA7QvXdZ9DynDUHUsui22+kp4WiLIRUiUMVP5K?=
 =?us-ascii?Q?3GpPyWgONsKSehKAUwPHWmyNfC1kzwBgziAddNDeF7M0xCZGTdhTYrtxDHqO?=
 =?us-ascii?Q?g9I53Y57+c1VhWLvcBmWmp8611Z/PB6nrFDbgc1OJpFKnLJl0FfD1DjpVdeH?=
 =?us-ascii?Q?3jW8bhlFndZKR/8dlCnuHSrnHTBjUaEN2kTKK/jwQ8z6gKWN8cjadcIm8vBq?=
 =?us-ascii?Q?LtgGxxxSo0do1XRb5KESDkA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <EA5211C469F99949BB5B3AB0C152EEB4@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?+KAcX1gGONNio4qhHVF7PMTNtov8527o6O5oqPJ7CWwnkjtExlattI6cgGML?=
 =?us-ascii?Q?GS4Y2Rde16aeJAmJKpUiXfDCtFTBcUR2UHtymuzMNalvNTYPRFXfAazV/d9e?=
 =?us-ascii?Q?dJOg4dkdYRUyIvxuKusIpkx7ABEvRA6GbZeBUcnih1NAl7glhgFgGuXVvI8H?=
 =?us-ascii?Q?5UvPU/j+4zVkPy0GTnuqXO9kMaFEpT+BIpFVS6+e/00ZvU6Jza1BNF11MZ3O?=
 =?us-ascii?Q?b6dSODen7Jv3YmQ4UKUAP5GYbGNyv1GRBMwE8bDSUcTg0Mi8peSiMFbmmiOL?=
 =?us-ascii?Q?d8w5USTG+6rXQEEDOkXBfh9WFXiP5hkDM/i7vF7NKHH1OMdn+wvzs6kH4oXJ?=
 =?us-ascii?Q?/Q6aeE265PJi+TriiVLs/QtVzXBcwMVl+u+quRyJvUE2tbVggs4IPynZBs5N?=
 =?us-ascii?Q?2cKNBGJM4aHR66RSHxY4a0QYW2vNh3xar3OnQXT+K/AZjBhPat1+rCrmIi3w?=
 =?us-ascii?Q?9Ddq+lxYIC1MTvMq1SqHBKlOuX2IB9Rua7eso6QmSH5HcaxBZYSXFnSzn2fD?=
 =?us-ascii?Q?gr4xT2LpbvhH/bvYOfUEOYMVgEHprpKBzRoBWlluu/plY9R6NtWwRTm8rFE1?=
 =?us-ascii?Q?tjCTySyaA7hUhGduyfIz5RBovcVD6grBXQJL0yGoB43ZUhGaZGgG/1tXrg6C?=
 =?us-ascii?Q?sz4XkOKQJ7joM8ybkSp0VdQP/cjwxlIGmnqAocaC45Pmbx8NlQyvK7b+7VuF?=
 =?us-ascii?Q?g0AxFVI6zmvspe/nxBhLcZhneLUbOl12v6I2QV6j7UEFaplYG4ISq17AXXvB?=
 =?us-ascii?Q?3G4Y9hLf2Dw4luZlKS1/RMz881VtUuLPeswrb1Qa/kVwiUW5zXV3TrXzn7Z7?=
 =?us-ascii?Q?mXYrtKusCqFw2y4H8T6uB48IzQqP83xai7UfYqtPl+LUiA+9t06Rk+Znv3Cm?=
 =?us-ascii?Q?nF9gMluAGv50E4jIQytV8+045nnbG3SOZGXhDRiCfHvdk3TfCO+DvHDFRfcq?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e494acb-4167-4266-3cc7-08dad2a904e6
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2022 08:00:59.9538
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PNprsnetDAlDGsB265cpylAjYT/AXeQAgF2QRl3XeekK4OvSuh1Qn5YVDo0Q9f7tdo1ERy3KTEaIAlpBzMVohmotatzbrf5xTT2zHbbotCM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR04MB7336
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Nov 29, 2022 / 15:28, Chaitanya Kulkarni wrote:
> Introduce and use two new macros for calculating the page index from
> given sector and index (offset) of the sector in the page.
> The newly added macros makes code easy to read with meaningful name and
> explanation comments attached to it.
>=20
> While at it adjust the code in the null_free_sector() to return early
> to get rid of the extra identation.
>=20
> Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>

Looks good to me.

Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>

--=20
Shin'ichiro Kawasaki=