Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Chaitanya Kulkarni <kch@nvidia.com>
CC:     "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        "damien.lemoal@opensource.wdc.com" <damien.lemoal@opensource.wdc.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "vincent.fu@samsung.com" <vincent.fu@samsung.com>
Subject: Re: [PATCH V4 6/8] null_blk: add param to set max disacrd sectors
Thread-Topic: [PATCH V4 6/8] null_blk: add param to set max disacrd sectors
Thread-Index: AQHZBEp5/mHwxPrqAEuGAmftqO8sqK5XHQ8A
Date:   Wed, 30 Nov 2022 08:07:43 +0000
Message-ID: <20221130080742.tlr7nnxernioteps@shindev>
References: <20221129232813.37968-1-kch@nvidia.com>
 <20221129232813.37968-7-kch@nvidia.com>
In-Reply-To: <20221129232813.37968-7-kch@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?J23EtUvvLze/3U4pMZmWvKUMp6pcghy7ZFiYMMCflIPalzK9/b5Ofj/qbuIg?=
 =?us-ascii?Q?KF83sR4mgWB18nWEw0hZpe1G2GM4Eq9GH/4+Yjtz+DJ7j4ckcvtBK49RaxZS?=
 =?us-ascii?Q?3AaqOiRfzftWsb6wjNPEJRKOJBEyhh33asYxoVKCdpmGEn4AoIzFkHZBDNOg?=
 =?us-ascii?Q?Thk8aNz1rMHhw7tTnhRKaqk4jpWtoH52GZ+Ng9LsJeZid66MUmXoL2bH7nwQ?=
 =?us-ascii?Q?2V5oI/ZZ+sgWA2VWMIgZMfI0cAyFhylLty0+a0rwjpxTTRyNZptOYIuNzeXu?=
 =?us-ascii?Q?ZWzoGSpHTVyS7FJ8ZeBRaNHk4kZwA38WQnjosv/nreQyviW+r1kL4c8plRLl?=
 =?us-ascii?Q?Lynrs4JjtFAINCK0OXwwynxcYEs9ayzI6A6hgj/AZsHxKUZoK08u79ecOcoo?=
 =?us-ascii?Q?XCuVIHQQhJwtTWCI9wR7RSo4a8z4NvGWuzGmEKEJhQ9D4+4g3F9qVR6IoDxg?=
 =?us-ascii?Q?ynZemedohHCuMM+4QMK/rS8Cbhmg2PQqaDBZ5FFdTg86RRUAzdcXiqWxZlAD?=
 =?us-ascii?Q?WmF+vBnXR3PZ95wiaEYa5xrkpRyrQkphFhCOBmDATCdUbROVbNJQ19MjaOxo?=
 =?us-ascii?Q?S+UbeygYpZ7oMAXVTp2nrQLYjjUFhfrkdn9nKfG9IXRjBAAvZoxkm6eNJgOx?=
 =?us-ascii?Q?dr93/qOQZ6sVWyrrSjaS2ADf87PraiZeKiMvTDyL8/4wLZq6qIRiuygjmdJ2?=
 =?us-ascii?Q?Wj1JCvXD9OOeGvVb0dWJX27RHeujUvesj/wwI3af6lLYS2jPM21Da3GS3+ey?=
 =?us-ascii?Q?A5xT53wMnQspl4p8wDx7zOGUzbktB1atuOkAz64wqXUwebUGC6oIMctjV+yM?=
 =?us-ascii?Q?XqvahqF+nTVEAZqupOM5bNzl8TroPDWahpubYHaSVsnXV4Mla09ZA9xP7O8F?=
 =?us-ascii?Q?UWRj2EEWDeAn3jubVLKYHoKFlZa7SOmpYZmqfpgDKA4lZIfvor8C7TjxfB0E?=
 =?us-ascii?Q?VnZDrkLHrkVqXl4RPfbrrPe0wQU033C3/dVwV9pKMNS0if+wPjHTVnR/j6xy?=
 =?us-ascii?Q?3wbhQQahAf2aFpr6chi3Keo084v2GcuMLjwXjimWf4Gr/482iDBUa1NJc2lo?=
 =?us-ascii?Q?Z6TIYaG3AltpJ55szTfvyqf05IfYPTMmB23JziePBqhjHVN+BQVYBtRDKpGD?=
 =?us-ascii?Q?grJsjztTW7E1OiJZWdCrd7n0IASgFntTG1pgJuyiZSBeIQXg4IeYzL8k3h3s?=
 =?us-ascii?Q?kx80jeR5hfwvRM9YyRdVx+hQBmOfu6n7gwfKEDI4F8bUJz/XLVipnmpD+nd5?=
 =?us-ascii?Q?liHfOWzqYLKl9VHunUahnqjT0mxs8z44u7+nY0xHfkf+b6uKEEv/Z9Ko7RmT?=
 =?us-ascii?Q?078irExkTWAabNiw49OdKIRel6BkWRcZp5TWyNrmKumsSCQMGVETD+50YfXP?=
 =?us-ascii?Q?amKKk7qzTY1k7wQj3ssG9nUdas9zlIHdjun81xrBu770HSDeBfI4twNwLSZ3?=
 =?us-ascii?Q?f48BAi+OP0dfa1iQI9U/6tjfA8WNCTYYEFk6hiMaEWAZnlCHLRDXHa6H6OlD?=
 =?us-ascii?Q?tzfJ1WGorgBhB574oxzTBeKAhfipd5QjUvLx0eUGs+wunsA/G4Jfuag9ywJh?=
 =?us-ascii?Q?NumOiNfo3QXH9O6hnHOnjIK1eRrZ071vceZy00FzeMGC8D0kxDzMkK2PBOFS?=
 =?us-ascii?Q?GA6jGsEzeT5IlBE+VSo0Xh0=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <744BA5C0D802244F9588D9EE907554F6@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?4O7qv/rH/9iQalauDl5VHWgOqC7L+AR8Al9b8aZgFRJ4JEAU84gT2/XjI0pD?=
 =?us-ascii?Q?f0tQtIfsrAnJj//Zu3l8tjC36h6RmqQtek0vmkawx920p55xkDpr8E/aEdw6?=
 =?us-ascii?Q?dvsS1O7kB+5YiLnc1RND87OEVi/W2yL1meziMAq6MvzJ8pxubMm/Rdxt18XK?=
 =?us-ascii?Q?ofkVASE+ajXFoaE3lABbtH7RmVM225aETauOz+LvM9dgvRPtXiWKQga7DbQS?=
 =?us-ascii?Q?f66K8TVgk1CjETcQuAZ9vShruzhNxJAFYt3CxVm6eDjVsZykcGCyTCdP/1p9?=
 =?us-ascii?Q?g93DOE7KFfHOtcIryWsMdVNFuvkotB5wFzaugEERuk8av+Tv95eqwdyZtlzp?=
 =?us-ascii?Q?A84LR2ecNe88qgL/5SX4dumiBAvAGDvenMqq1EYB2A+tfqRfualYeCD8yREB?=
 =?us-ascii?Q?3dTjZa03FKdY+XPr2LvNGi2v1pidzugOWdNNLw30NnT1ivoUMuldU3d8paST?=
 =?us-ascii?Q?9fxceem9ciB2q/s/eBOlg1JTnuoFXxz71zlspHrGShnwZdnZayktUWXCG8x2?=
 =?us-ascii?Q?Shi6IHZtMToASkEDN7wZBlWDTPkEiKMtDYqAIREfYh+OiU+q6w7dmtCaFgXw?=
 =?us-ascii?Q?MMDOQdSyWvtqw3Qkkkqy4CZ3Za3JNNsWtA306oSwwDDu/dfy1IYn7YC4/F7r?=
 =?us-ascii?Q?MpFZ7JfVbe4KL2eSWI7Sq18TbNpOP130bnca47XTLyFKjPXcZxU6l2bjjx5D?=
 =?us-ascii?Q?ruMMPVMv5r+Dea/ePhNbKiqcp1IuoF5VBwu+7be9H0NiYLJjIMY2CsM6WoOk?=
 =?us-ascii?Q?TkE0iY124L8EUad+4316573F7W1KSQWBBZ4CvcMVZelYBMa+SpX5CoegYiNZ?=
 =?us-ascii?Q?4S4rXc7ducvEC2c2j8WrgfKcNGbwAWWyBRkWjC26KynJ/DN2urIOJ9FyurJu?=
 =?us-ascii?Q?nX95v4O77MuFmZY0IpsL76d1UdTPN3K9diHWkK5bjKQeFLpnweH6KbRQ+j6t?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c8c22f2-8488-4b2f-a588-08dad2a9f52e
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2022 08:07:43.0814
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2mGCRQYETjxyT+QMmI1Ufyvzc+4mf1u7OMeKafeqO+boe1ZH8g39cRT1KudvtoJP0+Yw0ylgnmPwRpIbLQrwlEdaSW5Nd7VR9fzUyuHlouc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR04MB0851
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Nov 29, 2022 / 15:28, Chaitanya Kulkarni wrote:
> Instead of hardcoding value for the maximum discard sector to
> UINT_MAX >> 9, allow user to set the value with newly added module
> parameter max_discard_sectors.
>=20
> To retain the backward compatibility make set default value to
> UINT_MAX >> 9.
>=20
> Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>

Looks good to me.

Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>

--=20
Shin'ichiro Kawasaki=