Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2061277rwb; Wed, 30 Nov 2022 01:35:45 -0800 (PST) X-Google-Smtp-Source: AA0mqf7kFigpq+6Hnbas1e+wOWCX98zbeKYIydaWz5MeY0JrWoOXp0zD8DJDSIKhGgt+S4E0/4hX X-Received: by 2002:a05:6402:3808:b0:468:c911:d843 with SMTP id es8-20020a056402380800b00468c911d843mr55406326edb.422.1669800945479; Wed, 30 Nov 2022 01:35:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669800945; cv=none; d=google.com; s=arc-20160816; b=KYHJV0GCnzKhCX28Ayw7e/2tjkYLFHBTUTsNDDQVTzsvSVgpRqdFYZdYP2XEn1nZ3U e5MQAZAS2EvjCZwUV3h4uYB1aqkGF9KoeEQ5UotrDARYpuwmdGVLSKGHfVQUYZCM4CQq LsNYWVaVgcTEDLktbAH9I8GjaVZVdD4WfckDFlKYZVOS0jmibi6vQjWhFPn4+EM1Zy9k Fh7OHezkClTNwgTNoiBbucxD0RCo4c3EfEs+l45bOTHUmnEuZeCVF8W0HiZlvDVlJoeh o5uVt4UxRczsnoHLnOTPix8TEcDoeKhjNnLdwtZghJM3+oiEJKs88T/8RpOIOCvwucf7 vwUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from; bh=ObWLKHVCwOZf3QjxUVqlOhmx9K36nSfm3PIMpXaaEd0=; b=vnGAqSsLFRnG3k/Ehb2A8q1OVtLgnJXZtnwwMr42FrPubUecdaBR2EybWygFIQ+JnD 1RmHluvoQVGMqjZ83JIP54TJ1kOseeMGxfETpfYvLewHx+Fb5nTiTaapHGU4jDmyzaRV xZ+OrJo8MaRKdeqrk+vPUoTPanLf8MbZcSRzWZ1s8hg2HIyCBvBhqucWFrvsDGbnNLNd B37cTs1Sayulxp2Jsux51/QsjtwiCaMJBg/PYP+9gmm0OV87xRIxBO8hr42IloSfvnH1 djiTOjAytX0BkAqU9+IBWLY7CtlNG+yWTlWinZV7JA+pnfYos5JOL58K3AJuyCTuk3Qi 4bkA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j21-20020a50ed15000000b0046b1c38c13dsi886089eds.122.2022.11.30.01.35.24; Wed, 30 Nov 2022 01:35:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234163AbiK3Jbx (ORCPT + 84 others); Wed, 30 Nov 2022 04:31:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233820AbiK3Jbb (ORCPT ); Wed, 30 Nov 2022 04:31:31 -0500 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DBD352167; Wed, 30 Nov 2022 01:31:30 -0800 (PST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4NMYqf5t6Kz4xP3; Wed, 30 Nov 2022 20:31:26 +1100 (AEDT) From: Michael Ellerman To: Michael Ellerman , Benjamin Herrenschmidt , Anatolij Gustschin , Paul Mackerras , John Bonesio , Christophe JAILLET , Grant Likely Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org In-Reply-To: References: Subject: Re: [PATCH] powerpc: platforms: 52xx: Fix a resource leak in an error handling path Message-Id: <166980021648.3017288.16545601225539793155.b4-ty@ellerman.id.au> Date: Wed, 30 Nov 2022 20:23:36 +1100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 29 Jan 2022 08:16:04 +0100, Christophe JAILLET wrote: > The error handling path of mpc52xx_lpbfifo_probe() and a request_irq() is > not balanced by a corresponding free_irq(). > > Add the missing call, as already done in the remove function. > > Applied to powerpc/next. [1/1] powerpc: platforms: 52xx: Fix a resource leak in an error handling path https://git.kernel.org/powerpc/c/5836947613ef33d311b4eff6a32d019580a214f5 cheers