Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2086334rwb; Wed, 30 Nov 2022 02:02:56 -0800 (PST) X-Google-Smtp-Source: AA0mqf60xOr2oX/oV/dlJ4j8+dJMV2kWt9d90NpL7hAzbSNXbQOCly/+8pf/gEjOeHBy/SXF5Bdk X-Received: by 2002:a17:90a:898e:b0:218:bcab:96c6 with SMTP id v14-20020a17090a898e00b00218bcab96c6mr46940838pjn.46.1669802575845; Wed, 30 Nov 2022 02:02:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669802575; cv=none; d=google.com; s=arc-20160816; b=KFxBfuyKhRF/S4rgkMo7hm+6voXzYvltnsuaulftTOLy5+CBdmYR4UMhvOq4MsdRV6 MEzqWe+4V4TlvJJUQ4shmZR/EwJ605bNQs/IcyzKLcV4kkz6I3bb3/yEzvF0k6bcxXC0 RpyToKUjN0y8bpOV9Lm3lpGP4tghPQdVw3JUFOcuM+Fu3683URIIFP9APVstH2KR7luC sbpB0gTAnXY3gTvApzFJ9gOLEu4zV3CIAX6h23aypi/U6j5exfyHD8SolsfQZ8a3do7Y CIj+/cLPiFIMfZzReBgO1aXmsBSVbpUFvHwo+x2Cw0ot2OSJ/CSYpw8sOnR3k0REW+99 fQdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from; bh=ZEYJcq5QZqI8qUMaqCGoV4qCfCD4McwKLGA1t8GMo5c=; b=CCfkTmlv5RXG1T9reOTD2Us5GCMf6KH5XyonNC1kCHMLXW3NZ453BYihSAdZ+/Xf49 1zIKwil1soXy4ig1BDhOna9apAggIJ6ONtIL4ue/0YOaFt4NXp8TFCBe0Yl1iOQ0BTo2 otRlbBMZ99YRAsswfctYaZW4IfPsSyh9Wjv6O2QN0ZFEEIPwRHB63Wa8ecGXVOFlK6Ix 9KwXD1pBw9VchBvHiMi/EA8SBsJUYtcw78z1zXKdhk0Ve7PWmy/eEUtlPSoE95VRIwiG Ge4lYFOAJicm5f3nD9HBvcYLhtGGqvbDK0XZ8XsNnrZerEpGyuQilFVKAsEcQZXUR1Wo SHmQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r10-20020a65498a000000b00476ea7b91ddsi912106pgs.51.2022.11.30.02.02.45; Wed, 30 Nov 2022 02:02:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234439AbiK3Jhk (ORCPT + 85 others); Wed, 30 Nov 2022 04:37:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235530AbiK3JhL (ORCPT ); Wed, 30 Nov 2022 04:37:11 -0500 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A69148BD1D for ; Wed, 30 Nov 2022 01:34:07 -0800 (PST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4NMYtj2PK0z4xvr; Wed, 30 Nov 2022 20:34:05 +1100 (AEDT) From: Michael Ellerman To: Stephen Kitt , Benjamin Herrenschmidt Cc: Michael Ellerman , Daniel Thompson , linux-kernel@vger.kernel.org, Christophe Leroy , linuxppc-dev@lists.ozlabs.org In-Reply-To: <20220616170425.1346081-1-steve@sk2.org> References: <20220616170425.1346081-1-steve@sk2.org> Subject: Re: [PATCH v2] macintosh: via-pmu-backlight: Use backlight helper Message-Id: <166980022506.3017288.12402115611479311613.b4-ty@ellerman.id.au> Date: Wed, 30 Nov 2022 20:23:45 +1100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 16 Jun 2022 19:04:24 +0200, Stephen Kitt wrote: > backlight_properties.fb_blank is deprecated. The states it represents > are handled by other properties; but instead of accessing those > properties directly, drivers should use the helpers provided by > backlight.h. > > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > [...] Applied to powerpc/next. [1/1] macintosh: via-pmu-backlight: Use backlight helper https://git.kernel.org/powerpc/c/a0542d2c45a64162e63ad2d80684e57de0566271 cheers