Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2097019rwb; Wed, 30 Nov 2022 02:12:54 -0800 (PST) X-Google-Smtp-Source: AA0mqf5ZVbnpyMGiTLC/S3QnVmgjtvgBXjieDkLMJHvG+ToR2gLcdFmyAjEcrobrrDI+F8/6wVlL X-Received: by 2002:a17:907:376:b0:7c0:90da:9ec4 with SMTP id rs22-20020a170907037600b007c090da9ec4mr2035077ejb.327.1669803174168; Wed, 30 Nov 2022 02:12:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669803174; cv=none; d=google.com; s=arc-20160816; b=nGiETyakfFvVgCXmrUS73pNWA6I0bBi7URWP8UU8+8t5MS7KzCy6trlLCdeZU1kCpY OfHx9wB7Jek688kWwSzAZzedLhNe3wITUnyNcYUPYiv1rwCBjBlcMEYCOV7iY+VV2R3U 3avihS4aSM/5NVplSNrMMnb3WmYvmeMtq8mYTqvbjUTAWBWuvrDBY7OuhL648LAxQuw5 wJlA7cCEjCi4UO2YESw+Qvdi/a55XLpStkX246Jxs9z2JgiDq6UJIWgnq/KeSizb+wIx 0hJrAglI7SC2gadLkJ0rwLefh8i1cnXJhxOmhn0RXO35xgrPbDnMucVBaH+lUMj4KWGG dT0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=SR/y6pMkx6OwYkK5u9vHDU1gxTfgHGeGIKIpysk0H0I=; b=GQMYN7sssDbHgMIsyid1VSPhEhFLm/CjA3iKSsye7lZDRWHI39hIDDK9T+3NOPyIR5 Jx8VNUi7ppx6KPi8+geSyioG/PzvUXYOfzTuBD2ZkFgnhIcNZjRv9FNxSayIIVyTUKO5 MJlWRIuahi26dVXnx8e4r7/K+Jrr7xXkHdxv8LlIOQxOuSwkLoOQMUFfs4CrbzmEa29M WdmVvOSynM50L9Xr4uEawYy9fvdS4NX8rMNTyBTyVgab/kxOj0e7+Cazw2gJKmwzXhsj uf+CeZ9LXzPHTkf5FyLcDSuqnmQ8qX5pox3656fFN+d2+T/4Ri/WrlCfvfQUWQlIPM4D yOmA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=hisilicon.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gs20-20020a1709072d1400b0078232bfe3a0si1177870ejc.331.2022.11.30.02.12.34; Wed, 30 Nov 2022 02:12:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=hisilicon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232637AbiK3I7W (ORCPT + 84 others); Wed, 30 Nov 2022 03:59:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233400AbiK3I7T (ORCPT ); Wed, 30 Nov 2022 03:59:19 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8AB13F045; Wed, 30 Nov 2022 00:59:16 -0800 (PST) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NMY5h2g0tzHwJZ; Wed, 30 Nov 2022 16:58:32 +0800 (CST) Received: from kwepemm600013.china.huawei.com (7.193.23.68) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 30 Nov 2022 16:59:14 +0800 Received: from [10.67.103.121] (10.67.103.121) by kwepemm600013.china.huawei.com (7.193.23.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 30 Nov 2022 16:59:14 +0800 Subject: Re: [PATCH v3 for-rc 0/2] Fix sge_num bug To: Jason Gunthorpe CC: , , , References: <20221108133847.2304539-1-xuhaoyue1@hisilicon.com> From: "xuhaoyue (A)" Message-ID: Date: Wed, 30 Nov 2022 16:59:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.103.121] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600013.china.huawei.com (7.193.23.68) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,HK_RANDOM_ENVFROM, HK_RANDOM_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sorry about that. I will pay more attention to the commit messages in the future. Could you give me some advice about it? Which patch makes it confusing? Thanks, haoyue On 2022/11/19 8:23:21, Jason Gunthorpe wrote: > On Tue, Nov 08, 2022 at 09:38:45PM +0800, Haoyue Xu wrote: >> The patchset mainly fixes the sge_num bug relates to sq_inline. >> >> Changes since v2: >> 1. Move the refactor rq_inline and new CQE inline patches to go >> into for-next after this bugfix apply. >> 2. Change the commit message to better explain the bug. >> V2 Link: https://patchwork.kernel.org/project/linux-rdma/cover/20221026095054.2384620-1-xuhaoyue1@hisilicon.com/ >> >> Luoyouming (2): >> RDMA/hns: Fix ext_sge num error when post send >> RDMA/hns: Fix the problem of sge nums > > It is still not clear what the bugs are from the commit messages, and > the second is a bit big, so I put this in for-next > > Thanks, > Jason > . >