Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 30 Nov 2022 11:21:57 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Frank Jungclaus <Frank.Jungclaus@esd.eu>
Cc:     Stefan =?utf-8?B?TcOkdGpl?= <Stefan.Maetje@esd.eu>,
        "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
        "wg@grandegger.com" <wg@grandegger.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "mailhol.vincent@wanadoo.fr" <mailhol.vincent@wanadoo.fr>
Subject: Re: [PATCH RESEND 1/1] can: esd_usb: Allow REC and TEC to return to
 zero
Message-ID: <20221130102157.ip7w35ufc6xepb5w@pengutronix.de>
References: <20221124203806.3034897-1-frank.jungclaus@esd.eu>
 <20221124203806.3034897-2-frank.jungclaus@esd.eu>
 <20221125155651.ilwfs64mtzcn2zvi@pengutronix.de>
 <567bb7208c29388eb5a4fe7a270f2c3192a87e0e.camel@esd.eu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="txnwk44n5fupu5xm"
Content-Disposition: inline
In-Reply-To: <567bb7208c29388eb5a4fe7a270f2c3192a87e0e.camel@esd.eu>
Precedence: bulk


--txnwk44n5fupu5xm
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 29.11.2022 17:15:56, Frank Jungclaus wrote:
> Hello Marc,
> thanks for commenting.
>=20
> On Fri, 2022-11-25 at 16:56 +0100, Marc Kleine-Budde wrote:
> > On 24.11.2022 21:38:06, Frank Jungclaus wrote:
> > > We don't get any further EVENT from an esd CAN USB device for changes
> > > on REC or TEC while those counters converge to 0 (with ecc =3D=3D 0).
> > > So when handling the "Back to Error Active"-event force
> > > txerr =3D rxerr =3D 0, otherwise the berr-counters might stay on
> > > values like 95 forever ...
> > >=20
> > > Also, to make life easier during the ongoing development a
> > > netdev_dbg() has been introduced to allow dumping error events send by
> > > an esd CAN USB device.
> > >=20
> > > Signed-off-by: Frank Jungclaus <frank.jungclaus@esd.eu>
> >=20
> > Please add a Fixes tag.
> >=20
> > https://elixir.bootlin.com/linux/v6.0/source/Documentation/process/hand=
ling-regressions.rst#L107
> >=20
> From my point of view this is not a regression, it's a sort of
> imperfection existing since the initial add of esd_usb(2).c to the
> kernel. So should I add a "Fixes:" referring to the initial commit?
> (Currently) I'm slow on the uptake ;)

Please add a fixes tag that refers to the code that this patch fixes.

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--txnwk44n5fupu5xm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmOHLsMACgkQrX5LkNig
0103zQf/ZAgtOyPFAuMRQXXBwGvOD1FH/DO/cXRKQXSUcdSJDwPjg4ztdxsWa1Sp
jSg3bsvFTtRkSO7aOurWCjg8WZs6arv2YT80Kp7tB9rQ8YxxIXF7SVnt2L9KaxQS
KFgSUEC5liQt1VYTQtXTkf3fKkMpA+wi14jjuuOWWDD1dSDFVx/vYyMmC9z+/pDm
VzBVRxngUzjf1EgPHP8P9qOj4SOfOXbwLhN65A3TaxRJBQLZwqaqGWVF911Uwizi
x4YDkFnLqnMGJXQOfiZZjK9H92cpyKuwaaiMhfGEDnHgvDM/0x3idvqUN96nHUIv
m6xh2ULrXchDJVHHwbFRcUbM5IyKxA==
=cWlk
-----END PGP SIGNATURE-----

--txnwk44n5fupu5xm--