Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2155239rwb; Wed, 30 Nov 2022 03:09:47 -0800 (PST) X-Google-Smtp-Source: AA0mqf7k0vnl5+4PFvdDHNyR6onkT4WH8K6quZH4LwWnIi00ZOz5POKyVvzBO329CaUyhPitQbRS X-Received: by 2002:a17:902:8503:b0:188:e49e:2668 with SMTP id bj3-20020a170902850300b00188e49e2668mr44968357plb.125.1669806587116; Wed, 30 Nov 2022 03:09:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669806587; cv=none; d=google.com; s=arc-20160816; b=V+j+9C4Y0xaXRYgzu9iL5jnBLstBnRid9l8BqgB6w6LIU4G4zpUIJjfqi9D0ZVx2dO J6+hhw4rX+FGC3MS3sT7GueVGj5MF3lm05cRwDkD81ZT+RXuzu3xCoBvhVDtCNLE3160 dlgVq+pCPnSZIwGLaPWDzjv0vCUbBTKUzMfftVXtlX4e82dQTDZILPCXDFZqfSAM/Iw1 MztMDXfgOA0tnYsyhOTIDdjlQ0RChLRurd0uXRGUTtn55fCO0OKN3cK2M4KHL/74a2hL Umgr9Qzznn1felHxF6sB1QT1pSe/0kgApWMblSr+8vLhLM/Lhp7LkmZhJQb6mkWo6YJE w38A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:to:from; bh=fwodynjBiMmx50Bz9xDFfPwYVI5iIPg6A87Afs+BAeI=; b=kdPEvu54r7LK8oL5Aa1aCwChSDe07yhxifoWUoSy0yi3nfJqkXR8nKjemh7NnAiC5M 9B8X6fOo4qKLBbST0XDCgMCwDPLhHjgT+kibf2oNKbT7QOCPcv3t92ce+l5gsnlgj13v B1EKzIufhEW9A6FFTk9RPqYWumoVv3JGDpaEGSmDdd+rRuNn01fC16IedXSRL8q6QCOT my23sUZhR9IL8fz8FSdhBTe/zYEo9Vx5nX/OfOgmL9YkALxF40IDP5R8ugfmV+pvNyF4 yp3If0hCHY3ayAKk0bWUUjG7SszCgOprK8CQz5dvq5ifeFfYdDk1ktD0iLWjs865rTjO 7LWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k13-20020a636f0d000000b004782f073aa5si1017363pgc.151.2022.11.30.03.09.35; Wed, 30 Nov 2022 03:09:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234600AbiK3Jc6 (ORCPT + 84 others); Wed, 30 Nov 2022 04:32:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234532AbiK3JcA (ORCPT ); Wed, 30 Nov 2022 04:32:00 -0500 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 188425B87F for ; Wed, 30 Nov 2022 01:31:41 -0800 (PST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4NMYqv2FR2z4xTy; Wed, 30 Nov 2022 20:31:39 +1100 (AEDT) From: Michael Ellerman To: Miaoqian Lin , Michael Ellerman , Greg Kroah-Hartman , Frederic Barrat , linux-kernel@vger.kernel.org, Christophe Lombard , Andrew Donnellan , Arnd Bergmann , linuxppc-dev@lists.ozlabs.org In-Reply-To: <20220605060038.62217-1-linmq006@gmail.com> References: <20220605060038.62217-1-linmq006@gmail.com> Subject: Re: [PATCH] cxl: Fix refcount leak in cxl_calc_capp_routing Message-Id: <166980022428.3017288.10905643901571385394.b4-ty@ellerman.id.au> Date: Wed, 30 Nov 2022 20:23:44 +1100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 5 Jun 2022 10:00:38 +0400, Miaoqian Lin wrote: > of_get_next_parent() returns a node pointer with refcount incremented, > we should use of_node_put() on it when not need anymore. > This function only calls of_node_put() in normal path, > missing it in the error path. > Add missing of_node_put() to avoid refcount leak. > > > [...] Applied to powerpc/next. [1/1] cxl: Fix refcount leak in cxl_calc_capp_routing https://git.kernel.org/powerpc/c/1d09697ff22908ae487fc8c4fbde1811732be523 cheers