Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2158640rwb; Wed, 30 Nov 2022 03:12:44 -0800 (PST) X-Google-Smtp-Source: AA0mqf6pjwdtV2Gu7exTBj9+Wcw5qh02RcyCp1wc45OweZxp8R3olkT0KLlRv5h/7GMj75ob4zfj X-Received: by 2002:a62:8409:0:b0:575:1168:a970 with SMTP id k9-20020a628409000000b005751168a970mr17141577pfd.54.1669806764496; Wed, 30 Nov 2022 03:12:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669806764; cv=none; d=google.com; s=arc-20160816; b=kHHsQi/qRgyZQF7sl8iDxXCjMTTLiDURrR+mCtZPFb0B1m/BY5u9GP+B1hOz9/fITv 7Z2rD5u3hhXMw3zimn9u29RzJPLhpf0QlQcsbLzWQvIe4ZDaB5kyXKVL1mmK8pKyQrsP IVcJAb7i4g2ZAqZGAewRHDfSisuYmgcevoYpPWClg0WmAxJ/DcZ6Tt6IDfR3PGuFY2lG jyDLjtJkLw0zZLGUJHlxw+kjEkDVzimhrK7Dd7jWGXHEmGz2SS6drvzIEafzvel/xmSp ter/4xVlUJIgEKxVsu3NOx/QmiU5v89FHEWfIkHWCJgkQXRZ/cmkoxYWW2miU8QfDjl4 3S9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=T/qTFuvSDTyuxtbw1UheUU69WMndDEGtvZ8dq3mS7Wo=; b=E8y3cYGz4yH8bMjVpEQuH7l7SO1UhdhxSgInKda0pKG/4El8TQRJ+kOBBcTr3ggBO7 1XN9viqwYGSlEqlObD5vu8epuDt+LX4jaBmba6nolP6CrsAc1eNkr9Jf6jZHFBrRF9zx pXCmR0rELigX6Q1i/3uwXZuTIE9G0LI4myN93M+OkdHZOB/rNqetBXwUBEmno0bLRH2W xAWgw232QYhUpg4TeA3TCAkrrP2zv/7Lg2zwQoGHwEjAdIWBR2Z2hUgoto0Yw4hYNPV9 2g6Gbw/sA/+G5dkNrWh+61cXQWCMV4ItBy66fMByYRK9z8a+ejquZ3Js36GrFOQ1eE37 DccQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="TokZ/10l"; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e11-20020a17090a77cb00b002193068fe94si4010556pjs.37.2022.11.30.03.12.33; Wed, 30 Nov 2022 03:12:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="TokZ/10l"; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232322AbiK3K5U (ORCPT + 84 others); Wed, 30 Nov 2022 05:57:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230100AbiK3K5S (ORCPT ); Wed, 30 Nov 2022 05:57:18 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AF8C1758B for ; Wed, 30 Nov 2022 02:57:16 -0800 (PST) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1669805835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T/qTFuvSDTyuxtbw1UheUU69WMndDEGtvZ8dq3mS7Wo=; b=TokZ/10l9RkiVmqS+ibFGA2Nn+8F5Ekd13h73FlqhlLejZ1E/fZoD4bwbSt9qUG5W/GA+8 Bp3G+vsz5b1CPSKpalBeslslJEZ/ae1xADF9DxQyqEp4k2i/9HfHJHSlBHLQfuy47PxjCC 4taINMmqNeKfvlE1Zt+L1029jXWX/eRQXCjP+UnNtdEQA+s67dULKkMoLr9N42z596ziyE VaEq18/fDt9rf2BTlod4WGcPlbMtNy3WOOEbzuzn9uyLcf3LXfHIRLwBTctv91uQZEVAB2 eMpNMfk2QSwsCfnTzcKMU9yhwiWvC99BUKjK6AtnMNT6zRZkXMsju3vIebwvDw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1669805835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T/qTFuvSDTyuxtbw1UheUU69WMndDEGtvZ8dq3mS7Wo=; b=4XAaMV9DDKs8ryi1uMcO9sQ37GXtFxl3eZIyBN1VcaXpduqhPvJmQSFIDc+d5nrU2CrfH1 lgUx3wiUPViavhAQ== To: Jann Horn Cc: Andrei Vagin , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] time/namespace: Refactor copy-pasted helper into one copy In-Reply-To: References: <20221129191839.2471308-1-jannh@google.com> Date: Wed, 30 Nov 2022 11:57:14 +0100 Message-ID: <87k03cu2ut.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 30 2022 at 11:15, Jann Horn wrote: > On Tue, Nov 29, 2022 at 8:18 PM Jann Horn wrote: >> find_timens_vvar_page() is not arch-specific, as can be seen from how all >> five per-architecture versions of it are the same. >> (arm64, powerpc and riscv are exactly the same; x86 and s390 have two >> characters difference inside a comment, less blank lines, and mark the >> !CONFIG_TIME_NS version as inline.) >> >> Refactor the five copies into a central copy in kernel/time/namespace.c. >> >> Marked for stable backporting because it is a prerequisite for the >> following patch. >> >> Cc: stable@vger.kernel.org >> Signed-off-by: Jann Horn > > Should I resend this one without the Cc stable as a standalone cleanup patch? Yes, please.