Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c7acc1af-b97e-f9f7-4891-64bc9380a12e@arm.com>
Date:   Wed, 30 Nov 2022 12:28:17 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH] perf/arm-cmn: Add shutdown routine
Content-Language: en-GB
To:     Will Deacon <will@kernel.org>, Geoff Blake <blakgeof@amazon.com>,
        linux-kernel@vger.kernel.org
Cc:     catalin.marinas@arm.com, kernel-team@android.com,
        linux-arm-kernel@lists.infradead.org,
        Mark Rutland <mark.rutland@arm.com>
References: <20221125230153.49468-1-blakgeof@amazon.com>
 <166973320082.112522.10687339610259452670.b4-ty@kernel.org>
From:   Robin Murphy <robin.murphy@arm.com>
In-Reply-To: <166973320082.112522.10687339610259452670.b4-ty@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022-11-29 19:52, Will Deacon wrote:
> On Fri, 25 Nov 2022 17:01:53 -0600, Geoff Blake wrote:
>> The CMN driver does not gracefully handle all
>> restart cases, such as kexec.  On a kexec if the
>> arm-cmn driver is in use it can be left in a state
>> with still active  events that can cause spurious and/or
>> unhandled interrupts that appear as non-fatal kernel errors
>> like below, that can be confusing and misleading:
>>
>> [...]
> 
> Applied to will (for-next/perf), thanks!
> 
> [1/1] perf/arm-cmn: Add shutdown routine
>        https://git.kernel.org/will/c/316f862a787c

Oh, if I'd seen this I'd have said the same thing as when asked about it 
off-list, that it's needlessly overcomplicated and doesn't really solve 
the problem anyway. If there's a need to be robust against spurious 
interrupts then that needs to be done in the interrupt handler.

Even if we do think it's worth stopping the PMU on shutdown, as we do on 
remove, that still only needs a single register write (per the current 
remove implementation).

Thanks,
Robin.