Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2321613rwb; Wed, 30 Nov 2022 05:21:49 -0800 (PST) X-Google-Smtp-Source: AA0mqf6aZmmntcs5zhNJU6qXNlYMH9LFNkv2TiCMXLT5eNuEeuvObmu4YXO1YGBK6bMhETWj5d3V X-Received: by 2002:a62:1792:0:b0:56b:e975:cf98 with SMTP id 140-20020a621792000000b0056be975cf98mr43956489pfx.63.1669814509034; Wed, 30 Nov 2022 05:21:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669814509; cv=none; d=google.com; s=arc-20160816; b=R6aK8R3FiNC9z1mluKA5EVGrIRB2OZd5sIzgGLIMwv68eZyX+Af4ZJ0A3YUdvzRyhG 9yY4ZK9Yovk14GismJ8hKwOCuJvFVAiWeNstTc3i9JTk0u63sinW4Y8Gb6EAtxysfyGZ K01dw45K+aLXvwFsC7+McepkzTa8l7dGuMCbsI7D7ixW+vTpE+AMyAOgQRQKYizzA5uU UaWm0HhB4nNyriTa9A6WIiEygWqo5PpNGvqg3DSd5StVf/q9NaCiOiEbuGQ6UQENiJWp bVKZoVoywuTYBH5gIBAzlzuKTHwhv6LgF7ehgRG/PxCIva20rTfzmHAj9cnDL5TGxufa LtNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=sRw7uSrxLdkLalADot75LWX/mUgO7FMlC8yzaBgXwLo=; b=G79RuHgdV/Qdwcf9ftjb5+6bjX33ZLHROzhsEm81wLC5Ug/H3NYjrjCwJRsqGqqmgN UJSBZaLfFkCPx+QoYhXqpTv5JFTqKJoJF5RlOPhqsmu/U1QZI664mqs+9RQt2mpqnZYT PqBpTHK5qcRSIjuCrXdPvg/J+YX/uOjrPVwjDwYOPBzVvyPv3RXJbaBqOJTSIbmLHFxY 3RS1YnssHVVMBcwrJLGNRSRuXPZArGFQhPg8Xp391P5vEFnJB17BgL92mtjEw8z2CPSx XZj2xIDZykLX6mAHLrL54ka/N8t6W5HxvUdkxzzrPyW5drU2LQfgGCcqTHn6UgwfBpDz QeMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xs4all.nl Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x13-20020a63310d000000b004786623389asi594878pgx.288.2022.11.30.05.21.37; Wed, 30 Nov 2022 05:21:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xs4all.nl Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234906AbiK3Mqe (ORCPT + 84 others); Wed, 30 Nov 2022 07:46:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229613AbiK3Mqc (ORCPT ); Wed, 30 Nov 2022 07:46:32 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 488154A5A4; Wed, 30 Nov 2022 04:46:31 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F13E3B81B3D; Wed, 30 Nov 2022 12:46:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E0DDC433D6; Wed, 30 Nov 2022 12:46:26 +0000 (UTC) Message-ID: Date: Wed, 30 Nov 2022 13:46:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] media: Add ignore patterns to frontend.h.rst.exceptions Content-Language: en-US To: Akira Yokosawa Cc: Stephen Rothwell , linux-media@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Robert Schlabbach , Mauro Carvalho Chehab References: <3632a781-0595-d165-3514-36fb75ee477a@xs4all.nl> From: Hans Verkuil In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/30/22 13:37, Akira Yokosawa wrote: > On Wed, 30 Nov 2022 13:08:57 +0100, Hans Verkuil wrote: >> On 11/30/22 13:02, Akira Yokosawa wrote: >>> Commit 6508a50fe84f ("media: dvb: add DVB-C2 and DVB-S2X parameter >>> values") failed to add ignore patterns to frontend.h.rst.exceptions. >>> This results in new warning msgs from "make htmldocs" as reported >>> by Stephen [1]. >>> >>> Fix the issue by adding needed patterns. >> >> Patch has already been posted: >> >> https://patchwork.linuxtv.org/project/linux-media/patch/2bff9dd2-e4ef-1b10-e64e-3c62849eb3b0@xs4all.nl/ > > Even better! > >> >> Regards, >> >> Hans >> >>> >>> While at it, fix typos of "QAM-1024" and "QAM-4096" in frontend.h. > > Have these typos been taken care of? Yes, in another patch. https://patchwork.linuxtv.org/project/linux-media/patch/20221128054303.3124-1-rdunlap@infradead.org/ Hans > > Thanks, Akira > >>> >>> Fixes: 6508a50fe84f ("media: dvb: add DVB-C2 and DVB-S2X parameter values") >>> Reported-by: Stephen Rothwell >>> Link: [1] https://lore.kernel.org/r/20221128151900.5eb94a01@canb.auug.org.au/ >>> Signed-off-by: Akira Yokosawa >>> Cc: Robert Schlabbach >>> Cc: Mauro Carvalho Chehab >>> --- >>> .../media/frontend.h.rst.exceptions | 28 +++++++++++++++++++ >>> include/uapi/linux/dvb/frontend.h | 4 +-- >>> 2 files changed, 30 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/userspace-api/media/frontend.h.rst.exceptions b/Documentation/userspace-api/media/frontend.h.rst.exceptions >>> index 6283702c08c8..6f03c704d6ac 100644 >>> --- a/Documentation/userspace-api/media/frontend.h.rst.exceptions >>> +++ b/Documentation/userspace-api/media/frontend.h.rst.exceptions >>> @@ -86,6 +86,13 @@ ignore symbol APSK_16 >>> ignore symbol APSK_32 >>> ignore symbol DQPSK >>> ignore symbol QAM_4_NR >>> +ignore symbol QAM_1024 >>> +ignore symbol QAM_4096 >>> +ignore symbol APSK_8_L >>> +ignore symbol APSK_16_L >>> +ignore symbol APSK_32_L >>> +ignore symbol APSK_64 >>> +ignore symbol APSK_64_L >>> >>> ignore symbol SEC_VOLTAGE_13 >>> ignore symbol SEC_VOLTAGE_18 >>> @@ -119,6 +126,22 @@ ignore symbol FEC_AUTO >>> ignore symbol FEC_3_5 >>> ignore symbol FEC_9_10 >>> ignore symbol FEC_2_5 >>> +ignore symbol FEC_1_3 >>> +ignore symbol FEC_1_4 >>> +ignore symbol FEC_5_9 >>> +ignore symbol FEC_7_9 >>> +ignore symbol FEC_8_15 >>> +ignore symbol FEC_11_15 >>> +ignore symbol FEC_13_18 >>> +ignore symbol FEC_9_20 >>> +ignore symbol FEC_11_20 >>> +ignore symbol FEC_23_36 >>> +ignore symbol FEC_25_36 >>> +ignore symbol FEC_13_45 >>> +ignore symbol FEC_26_45 >>> +ignore symbol FEC_28_45 >>> +ignore symbol FEC_32_45 >>> +ignore symbol FEC_77_90 >>> >>> ignore symbol TRANSMISSION_MODE_AUTO >>> ignore symbol TRANSMISSION_MODE_1K >>> @@ -143,6 +166,7 @@ ignore symbol GUARD_INTERVAL_19_256 >>> ignore symbol GUARD_INTERVAL_PN420 >>> ignore symbol GUARD_INTERVAL_PN595 >>> ignore symbol GUARD_INTERVAL_PN945 >>> +ignore symbol GUARD_INTERVAL_1_64 >>> >>> ignore symbol HIERARCHY_NONE >>> ignore symbol HIERARCHY_AUTO >>> @@ -163,6 +187,9 @@ ignore symbol ROLLOFF_35 >>> ignore symbol ROLLOFF_20 >>> ignore symbol ROLLOFF_25 >>> ignore symbol ROLLOFF_AUTO >>> +ignore symbol ROLLOFF_15 >>> +ignore symbol ROLLOFF_10 >>> +ignore symbol ROLLOFF_5 >>> >>> ignore symbol INVERSION_ON >>> ignore symbol INVERSION_OFF >>> @@ -172,6 +199,7 @@ ignore symbol SYS_UNDEFINED >>> ignore symbol SYS_DVBC_ANNEX_A >>> ignore symbol SYS_DVBC_ANNEX_B >>> ignore symbol SYS_DVBC_ANNEX_C >>> +ignore symbol SYS_DVBC2 >>> ignore symbol SYS_ISDBC >>> ignore symbol SYS_DVBT >>> ignore symbol SYS_DVBT2 >>> diff --git a/include/uapi/linux/dvb/frontend.h b/include/uapi/linux/dvb/frontend.h >>> index 4fed9e316147..ab215d1c15d2 100644 >>> --- a/include/uapi/linux/dvb/frontend.h >>> +++ b/include/uapi/linux/dvb/frontend.h >>> @@ -363,8 +363,8 @@ enum fe_code_rate { >>> * @APSK_32: 32-APSK modulation >>> * @DQPSK: DQPSK modulation >>> * @QAM_4_NR: 4-QAM-NR modulation >>> - * @QAM-1024: 1024-QAM modulation >>> - * @QAM-4096: 4096-QAM modulation >>> + * @QAM_1024: 1024-QAM modulation >>> + * @QAM_4096: 4096-QAM modulation >>> * @APSK_8_L: 8APSK-L modulation >>> * @APSK_16_L: 16APSK-L modulation >>> * @APSK_32_L: 32APSK-L modulation >>> >>> base-commit: 6a5a4514854a637d01c50f5ea17b28f78b31ddb8 >>