Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     willy@infradead.org
Cc:     chao@kernel.org, fengnanchang@gmail.com,
        linux-f2fs-devel@lists.sourceforge.net,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, vishal.moola@gmail.com
Subject: Re: [PATCH]f2fs: Convert f2fs_write_cache_pages() to use filemap_get_folios_tag()
Date:   Wed, 30 Nov 2022 20:51:00 +0800
Message-Id: <20221130125100.80449-1-frank.li@vivo.com>
In-Reply-To: <Y4ZaBd1r45waieQs@casper.infradead.org>
References: <Y4ZaBd1r45waieQs@casper.infradead.org>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qj+JCBkZkkWaRcvazj2q0Fz6JPeLdA63d4OpKM3zMHOBXEFe0FIwWqD+mZyo?=
 =?us-ascii?Q?eU8Oevnone9LGdHbdxQefL4EEfgPUWDfVij9pRHp/2a9Xd69E2B4FCwCVk5r?=
 =?us-ascii?Q?7KlamatH4TjeWZ7eE1IYo7kkCjl3iTYAOFSu0bnY5cLMCZmHBBblj9I93Txi?=
 =?us-ascii?Q?A19CQfmehx58JjI5dZGVA65whyzESpnhlYvRZ5dYEd2J8nR7Nww6NvKa/5Lj?=
 =?us-ascii?Q?MFMsSJLPe5PYzp450459wi40f7fmtTJm+ZTfASGQ3mDKw1EHTlJaLm+0MQO8?=
 =?us-ascii?Q?BY8bryuH3GIvGw9V8CkZ8UAA5p7F6/ZlR+2bV3V4CopDG1cSyRb/8gHEN4fm?=
 =?us-ascii?Q?Mi6orC40u/p0R7WHAavmUNrCrgJrU4PqdJdb8rMeefi3/XJpdgclWQzAQ+N/?=
 =?us-ascii?Q?cbDddFmdsBMM5zaEWrgJx9/MrAPamG5XoBf8gXpcDyv8igJL86jdgj3Npni8?=
 =?us-ascii?Q?4wFxEB4Z6ixw55/IqpYTy/gx3/N/+LckXyr4KBzVqtR72pw5UHQwpByl8xK4?=
 =?us-ascii?Q?3LvXPKZNPArfLlKRT6PF3gAhICU14j/GyE+AUl5L34ZSRiqkEDsp+s8IY+wb?=
 =?us-ascii?Q?HZLI/H03Bccycf8sv2KyMFFgEslg+z7QmGHLW6fxywMnPhfgJ98Nc/Mr+CoU?=
 =?us-ascii?Q?RGITtAyvHHaXlM3VajX++IobHE61psflN0PJ2xhgBcsPo8hc5G5kIw0BdObC?=
 =?us-ascii?Q?rNWeopS301KczGTeOw42l4XkyuvaY+bjaykjOaokFAVbspQFQLRop4smwDw7?=
 =?us-ascii?Q?zpz6a9pTP0zMLKJxQKzgTxWNw1caoma9CwLtcp+QHxEpb9LoRy2FenBIbirZ?=
 =?us-ascii?Q?eFRnfmxFEg8q9Hydx7YPHyETdjqS/xO0CAmYLVqV4TANcufU8XYoNRoUn7wq?=
 =?us-ascii?Q?Oh/K7AnFcM2Cex+1fdoJJumPoE+F3GeQeL25qc+tKRZ2LTyT1s3HqR/smsQA?=
 =?us-ascii?Q?+FMh3QpMrWlJbmDE8KuoEpQEInqq9vTfzjbHwl58aIkXdEiZkLoW4AxXYWI4?=
 =?us-ascii?Q?r93CpzEe82hXbYtDAK+j01GD2vLDOED2RIC1E21KSJyTDFvyblJIfgrXTWXa?=
 =?us-ascii?Q?fg932yt5xT9SzNH8DHqjAYctVVip3tNR8RUy790WrASGica+pH1An99o8nvQ?=
 =?us-ascii?Q?xj5Ozw3Lj81n8F+1En00RzwvXb9QYcL4ujr5W9qozJP2AnYznKXZ4pYISz5e?=
 =?us-ascii?Q?sdVoJLjtSD4wX7KksRHjNo7WgadQbeyKcgWlXgzspoDCyBMG+NyyMaTNoT8d?=
 =?us-ascii?Q?uL5E8SQ7zrauhfWKXYOwv/Eo25841SKaozGOgdsvGvXNCvihevdI5tT7igHa?=
 =?us-ascii?Q?+3sYdIUOl/LG7J5GVruuicJHfKV9vDamxRs632k9c/BWkvjiPk5TeLF7jHML?=
 =?us-ascii?Q?QRfz8GmVHNN0Lg7Zi/8ImhS15HtohgdE9EZjdOYa4jmkALM3INe4M79Z3qR+?=
 =?us-ascii?Q?oJl0SMER1RPDNPO/kr9YklQbFLseMiN1gkjht+Tbgw1eFpgYAvMocd/OYB95?=
 =?us-ascii?Q?uTFdGqBbEIVVDKX4B0bu71RBYA9pq1OE7jhniFIiJiSga4f8RiZh7l8KQNxy?=
 =?us-ascii?Q?0ozKhpYhmAeCW+VEhxSUhnjmCopoN0JHZDqgzLGH?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1ea88094-c0f4-43f1-f5e7-08dad2d18d65
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 12:51:09.0644
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BB8bXitGeeQ6stPSWJWFrtdJSGfAnbSUtID3RQ3/tzaPxWyj1WUFApP1jdVl73iJanVB7GMYxbrZBr7diIDKaQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB5514
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

> Thanks for reviewing this.  I think the real solution to this is
> that f2fs should be using large folios.  That way, the page cache
> will keep track of dirtiness on a per-folio basis, and if your folios
> are at least as large as your cluster size, you won't need to do the
> f2fs_prepare_compress_overwrite() dance.  And you'll get at least fifteen
> dirty folios per call instead of fifteen dirty pages, so your costs will
> be much lower.
>
> Is anyone interested in doing the work to convert f2fs to support
> large folios?  I can help, or you can look at the work done for XFS,
> AFS and a few other filesystems.

Seems like an interesting job. Not sure if I can be of any help.
What needs to be done currently to support large folio?

Are there any roadmaps and reference documents.

Thx,
Yangtao