Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 30 Nov 2022 14:57:06 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     zys.zljxml@gmail.com
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Yushan Zhou <katrinzhou@tencent.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] net: tun: Remove redundant null checks before kfree
Message-ID: <Y4dhMhPswo5Y7DuU@corigine.com>
References: <20221129084329.92345-1-zys.zljxml@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20221129084329.92345-1-zys.zljxml@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHpQcXoyWDhIQVVKQllOTU8zRVlqSFFFNDlOeXFvNDlNM0RraDFldmhrdExJ?=
 =?utf-8?B?ZGkxT3JVc3BxWDlIcTJhb25XRDVkQ1h1eXA5YTRkOGNxVlp6NVQ0a2FNZnFK?=
 =?utf-8?B?aWEwWURiRFN0bjJLMFd6MGZldFNLdGc4aUdQSFRhU0xzamcxVEVMZXJKUkVq?=
 =?utf-8?B?N1Z4cS9uSlZacmxGUkQxSkxKaWp1Wng2MFo3N3NxTUVFOXQzOWxXd3VGQTdK?=
 =?utf-8?B?MTFyeGZHa0J1emd4K3R4UFhvY293Z0ZqWk1KU0c0M2JnMXIwa0VrYWFPckEy?=
 =?utf-8?B?VWRXNzlPZWJ5Y0NEaTZmcmpnUXRpUkdvQW5BUlRLaFRlV1cyUXNNRFM1bkNi?=
 =?utf-8?B?eElkV3BXSGNtVWZ5RDdlZm51bmk4L0RJYlVhVGM2cUlvSy81Yk5VYzh2ak9M?=
 =?utf-8?B?NnRxOG9PK1dDSmVEVUZ4VFhpYlZnaVRjZFF1OG4zK1JBVGhvejUrdGYweUsw?=
 =?utf-8?B?anBqSHloMU41L2lFNnQvNHIzREt1S3Qyem13cWZ5RVlqVEYwdHpPV3RrVU5s?=
 =?utf-8?B?N3VDWE9lLzByVFBBc0lyRzZzY1hPank0WEhVVGtJaEJIamMwYXgwU2VBNytS?=
 =?utf-8?B?TkV0eTdvMm5Ga1k1ZndhSytDaC9YSjFBOGlBTDd0S0R0SDdOUitpeDZVVG1t?=
 =?utf-8?B?SlJHY2xybEg5NHV6QUpIYkdBamZwWDRDR2tWMzNENkRsYy8yMllhaEI0QmtG?=
 =?utf-8?B?UGpvMWdJWllJajZEL0t5SmhCN3AxdWMzWjB3YUdRdm1XaWNSNGhLeWRKZmlI?=
 =?utf-8?B?S01tS2JUblBhMFgzV0hIc1dCZTJUUno5eXFlWlQ5NnFuZTZXT2xYdnJHdXdp?=
 =?utf-8?B?U2lQR25rNzd0aERNc1ljRWtZUURGQ2hUOGg5OUNmSlIxaUtFVmZGVjJ0Tk05?=
 =?utf-8?B?NGpjK1prb2pXYjF1SUoyMmZlcUxsS2ZUdzludnhnbU1LV0hxcmRvMG1YNGhq?=
 =?utf-8?B?NUo1NTVBcGRRa1VHL2lHZ1U0a2VHUzZzc28xdk92MzNoaGlTNk1iZ0VsQzND?=
 =?utf-8?B?ODRMb3M4bFRTNUNHeWlheHloT1duY2x3WktLdHlhQWxhL09jaTg3eHMxYmRn?=
 =?utf-8?B?c1dVYU9XQ3VZQ1BCRzRyeTM1a0RsdjBoY2haL3g2WXRCbTVuUEgvSjVZM1do?=
 =?utf-8?B?dTNxL0ZHUHd1eFByWUU5VzhTRXdoQUJuS2VRMEkrVW5iaXNPZG10VVJqOUM5?=
 =?utf-8?B?UzRiVUZSU0Yrbm1CTDBpOGVrMEdzNUNmODZoWFcrRm1BdXRjTmw5NzBLelVX?=
 =?utf-8?B?UE1qMlcvTHdKeTV2cUhwdnhRZGQ2amhGTkJsWkdKR1FmQ0xQSXFwZnBtcTNB?=
 =?utf-8?B?MWJrdkVES3pYRGxsblBOSTN2T3p3aGdCczFucTVxN1RDejlMNWliT3RtMWE4?=
 =?utf-8?B?cWFBWVl4NEdrRE45dUUzWVJQUjdtK0w5dFlqSGJxRFlna2lUcFdRNlBZeWh1?=
 =?utf-8?B?dW8zdWFxSytsZkJYY3BnYWJGcHRFOEl3WWlJWWY1TGduamh4eGdmQzVEblpU?=
 =?utf-8?B?MUQrem5OeGVGeUpuVHg0OHo1NnE3Z0Jabm1ETlh3c0Q4ZUNZemh4TWlleDZW?=
 =?utf-8?B?eDdQNmhxQW9KdmpRejdaZk5ZM203QkV4N2gyS0lLeDg2SExOUEdqK3F1WEZW?=
 =?utf-8?B?VUxtZm1iOE1EOVZaeFpvM20yV3hNcWxvWXIyMmhGbmF1d2Rud3hXU2pyZVV4?=
 =?utf-8?B?emNvb0V4VWZ3bUwrTWxBOWI0c1FqSW5UNldlR1JodEZINnFxQkpSNmNrb3RF?=
 =?utf-8?B?Mkp0WXoxWWlXN0FKWDNqbGhUYzBWSnR2UlZEZlBSNGh5aThwOXJYc3cvZFJG?=
 =?utf-8?B?cDJldnlWV3pyRVlNbU81Y3RKMjFhSWFkYk4zUVpEZW4yNGhwYVI1ajRNd08w?=
 =?utf-8?B?SkE1SmlXWWpZNzdPR2kya0hLN1hOeG9URFVBNDBONzU4QWVXeWNiN2lhaG9E?=
 =?utf-8?B?NCtNUngrM3lnV1ZJaXAxckdCVUtzZWdGaEF2ZXNYQjhUYjRCcXQ3VWhGNnFR?=
 =?utf-8?B?VWRSbGlUWFM3K1dsaHZrY0k1OGFtTG91eGwrZjJaQWVyV0JMSnBkRVpqU3Rr?=
 =?utf-8?B?MDZpZ1FwN0tuVXY1MTdObmJvQVlBaHYzaCtnd21QbERTanNzcllkNFJYK3Ra?=
 =?utf-8?B?UUo4WWU0UU8rZXkzNlNQeGQxU3VHY1RiOFRzcEowSGNnUWlEVDRRLzFqTm1O?=
 =?utf-8?B?UmpLaVU1TjY4Nk1yNlVqenR4aGp1c0pPbEF6MUN4ZEFZc3JJdWRacENPcFhU?=
 =?utf-8?B?VVRHRHpabzRtN2NjcEpNdk8rNGFBPT0=?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 63301554-6244-4050-0c21-08dad2dac826
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 13:57:13.0873
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: leSMybdwpiAfB9AddVZiKEVUu4aIczNI+GUjGiVZ+lMxiXuNyXhtnQcYusprXF68Lq3HasZDwzaWBYN2X1RR9yiP2zZ5pvw/4EMsSZScbBI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR13MB5483
X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,FORGED_SPF_HELO,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,T_SPF_TEMPERROR autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

+ Thierry Reding, linux-tegra, dri-devel

On Tue, Nov 29, 2022 at 04:43:29PM +0800, zys.zljxml@gmail.com wrote:
> From: Yushan Zhou <katrinzhou@tencent.com>
> 
> Fix the following coccicheck warning:
> ./drivers/gpu/host1x/fence.c:97:2-7: WARNING:
> NULL check before some freeing functions is not needed.
> 
> Signed-off-by: Yushan Zhou <katrinzhou@tencent.com>

Hi,

the change in the patch looks good to me.
However, it does not appear to be a networking patch,
so I think you have sent it to the wrong place.

With reference to:

$ ./scripts/get_maintainer.pl drivers/gpu/host1x/fence.c
Thierry Reding <thierry.reding@gmail.com> (supporter:DRM DRIVERS FOR NVIDIA TEGRA)
David Airlie <airlied@gmail.com> (maintainer:DRM DRIVERS)
Daniel Vetter <daniel@ffwll.ch> (maintainer:DRM DRIVERS)
Sumit Semwal <sumit.semwal@linaro.org> (maintainer:DMA BUFFER SHARING FRAMEWORK)
"Christian König" <christian.koenig@amd.com> (maintainer:DMA BUFFER SHARING FRAMEWORK)
dri-devel@lists.freedesktop.org (open list:DRM DRIVERS FOR NVIDIA TEGRA)
linux-tegra@vger.kernel.org (open list:DRM DRIVERS FOR NVIDIA TEGRA)
linux-kernel@vger.kernel.org (open list)
linux-media@vger.kernel.org (open list:DMA BUFFER SHARING FRAMEWORK)
linaro-mm-sig@lists.linaro.org (moderated list:DMA BUFFER SHARING FRAMEWORK)

And https://lore.kernel.org/dri-devel/39c44dce203112a8dfe279e8e2c4ad164e3cf5e5.1666275461.git.robin.murphy@arm.com/

I would suggest that the patch subject should be:

 [PATCH] gpu: host1x: Remove redundant null check before kfree

And you should send it:

  To: Thierry Reding <thierry.reding@gmail.com>
  Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org

> ---
>  drivers/gpu/host1x/fence.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/host1x/fence.c b/drivers/gpu/host1x/fence.c
> index ecab72882192..05b36bfc8b74 100644
> --- a/drivers/gpu/host1x/fence.c
> +++ b/drivers/gpu/host1x/fence.c
> @@ -93,8 +93,7 @@ static void host1x_syncpt_fence_release(struct dma_fence *f)
>  {
>         struct host1x_syncpt_fence *sf = to_host1x_fence(f);
> 
> -       if (sf->waiter)
> -               kfree(sf->waiter);
> +       kfree(sf->waiter);
> 
>         dma_fence_free(f);
>  }
> --
> 2.27.0
>