Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 30 Nov 2022 09:20:28 -0500
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     Alexander Usyskin <alexander.usyskin@intel.com>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        David Airlie <airlied@redhat.com>,
        "Daniel Vetter" <daniel@ffwll.ch>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        <linux-kernel@vger.kernel.org>,
        Tomas Winkler <tomas.winkler@intel.com>,
        Vitaly Lubart <vitaly.lubart@intel.com>,
        <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v3 0/2] mei: add timeout to send
Message-ID: <Y4dmrP9RzXi7wrwJ@intel.com>
References: <20221116124735.2493847-1-alexander.usyskin@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221116124735.2493847-1-alexander.usyskin@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?819Eu+lavdhBVqGhvumhuGsGAcXgBqH+YSFv3tiqWdCjikHMfQLYbZMy//eX?=
 =?us-ascii?Q?m5Twd7t1jFPWA6P9R2DmoWAab2e/EzNT6aIfXVdQEZ94w5M6t+TWUUXIFvFB?=
 =?us-ascii?Q?x1z6bt1B7D9vnOxDQqFZlAd7KSXQLsLw2wRYs5JNWqoFPN2WSxqlVpNKC5ED?=
 =?us-ascii?Q?XN99dQBmTsWf3ZMPGA6VgcvwwglzmPZepl2Kqer6e90CBNBbsjA7y3xoYbep?=
 =?us-ascii?Q?LoHCoUyW4r02NP9DdwdgpUCSv4sDByplJPQOqKfQ6vIOxa6zgqwyvpnMtDHJ?=
 =?us-ascii?Q?mQNcUGH62Iib7oTcPr/ISxiQejc3dT5Bjj2bU3Wnvl6RiaoyhwXhlFTEy5pb?=
 =?us-ascii?Q?PMsUTvmvq7cHL9kgtV20uHLZIkU5iDTZsdtr7uD5lBaRDCArQIivNTi2IWTE?=
 =?us-ascii?Q?4XU6uR6usC/CRdrccQx1mXSADtj3LMXBm40DX1FtyrN/GaPOCKhNha9BZDLB?=
 =?us-ascii?Q?JzI/T6HmvNDXLt5oHkt1RSdrn8RmdmVjirkBjdn7Qg6tbVWsXl2HI6G1faQ1?=
 =?us-ascii?Q?hwEtElq4dISD8t58ia+dJQjowL+U61g2HORPVdK2e/TsWVWW23AxA4D/BMDb?=
 =?us-ascii?Q?1CIpUCaJRtc5zgQVsBYSaaoYqTRQ2MtqX7O5UcblEXNFN3SOaFOML0RFgyl5?=
 =?us-ascii?Q?0lbpA5ldQfPy8lM/ijeuRds2OS/hkdXTLqZL3ZSPQ2TmYep5gA36Is/aiN96?=
 =?us-ascii?Q?faoDL7GFk2bMRhu+9fck75Mc7cFGZLdKkpERvRuA+yIZkUAMhocVr6FBn/Gk?=
 =?us-ascii?Q?ZcDhvdnpipdsXPwQ2nUY7vuk2HBnPN67p1h8d6pJkOCU4RhckJLVm8AyHoAd?=
 =?us-ascii?Q?ka1Stg/JB3uiJjn7hX5PCWLw249jqXkoN6p3QuR2ubSly5vW0e4nVNLWlhdC?=
 =?us-ascii?Q?Uck4qS/+kTBLBV0q413+y85Qa6BqCPp5pXrvu2Yg52dlyKeJs8weyDu8/7Yn?=
 =?us-ascii?Q?CB3M/g0JiyJi868VmB1zs/ITehupyctarJcJiharlGtNAWU/Fg1RYKpagVov?=
 =?us-ascii?Q?Uat3iffFED06sETPXjSfRscOAhQV7EBA462eVvqyKdF/tZEtXkafJbV/4de5?=
 =?us-ascii?Q?aFfmPjJAhU6FEiqeZ6CZrEFz5mZ8W7bU2tQniy6ptg84IczmVBV5NeAWW/is?=
 =?us-ascii?Q?6RGqueWLFy0qECsTAzleiNMj0rkHAypsd255fI+5XOfYhAwMVaeFFiUnzvH6?=
 =?us-ascii?Q?QiTZ9J3vUJB0TBBXr0sYtZd62VbpvnT8Gs4uCFdBLFGNllYXv9M0hglJwNvZ?=
 =?us-ascii?Q?BxYT4id0TcdVdIyWeyTTBH10X8SfNExNdjJ5SJxyRS+0MvotKntJJCtOW+2w?=
 =?us-ascii?Q?EFSSP84slFj+H4WoTiAXkJsynxqcHJcKfIwS0zV6+dYz4f042cUR2a93coOe?=
 =?us-ascii?Q?ZhfB6svWqMo3RTJhWauBvl0wodKf69RMrLYkWz7JSBlwYIkNHTNBbjLVj8Z/?=
 =?us-ascii?Q?SkNvgaV3femv2iwcbp+n0sK/VmI4cnALb22Lo9/ZusZxqoZzLjuKa2VOzujv?=
 =?us-ascii?Q?5+adif0+xhAcw6CBeGxiu/USIgqhJ3zuOkTupSZTtn+soIuqtOe6QtIo2g6k?=
 =?us-ascii?Q?z7B/TY/MGyHRzaeGxSR5Mh/jd5h0jXS5UPvC2RU9?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 16e125ef-59eb-4fcf-6ae6-08dad2de0b0b
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 14:20:34.0122
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wBvwgpXXMWEdC1G1Bcmrxvyx6+72FvR1T7NtmnE3acCr+pTADCcsucWBVEFVmFcdXh7OVroBixfQuHxXO0QaHQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6853
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 16, 2022 at 02:47:33PM +0200, Alexander Usyskin wrote:
> When driver wakes up the firmware from the low power state,
> it is sending a memory ready message.
> The send is done via synchronous/blocking function to ensure
> that firmware is in ready state. However, in case of firmware
> undergoing reset send might be block forever.
> To address this issue a timeout is added to blocking
> write command on the internal bus.
> 
> Introduce the __mei_cl_send_timeout function to use instead of
> __mei_cl_send in cases where timeout is required.
> The mei_cl_write has only two callers and there is no need to split
> it into two functions.
> 
> V2: address review comments:
>  - split __mei_cl_send and __mei_cl_send_timeout
>  - add units to timeout KDoc
>  - use MAX_SCHEDULE_TIMEOUT to squash wait to one macro
> 
> V3: - split the state fix into separate patch
>     - document define unit
>     - expand timeout KDoc

These 2 patches looks good to me now.

Greg, whenever you review it, please let me know if it is
okay to me to push these through the drm-fixes, or if you
prefer these to the mei branches.

Btw, Alexander, would we have a good "Fixes:" tag for these
patches?

Thanks,
Rodrigo.

> 
> Alexander Usyskin (2):
>   mei: add timeout to send
>   mei: bus-fixup: change pxp mode only if message was sent
> 
>  drivers/misc/mei/bus-fixup.c | 14 +++++++++-----
>  drivers/misc/mei/bus.c       | 22 +++++++++++++++++++++-
>  drivers/misc/mei/client.c    | 20 ++++++++++++++++----
>  drivers/misc/mei/client.h    |  2 +-
>  drivers/misc/mei/main.c      |  2 +-
>  drivers/misc/mei/mei_dev.h   |  2 ++
>  6 files changed, 50 insertions(+), 12 deletions(-)
> 
> -- 
> 2.34.1
>