Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <720cae36-ce6a-eec3-7d19-1f4ebca1b3ab@kernel.org>
Date:   Wed, 30 Nov 2022 09:01:19 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH 2/2] ARM: dts: socfpga: align LED node names with dtschema
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221125144236.477416-1-krzysztof.kozlowski@linaro.org>
 <20221125144236.477416-2-krzysztof.kozlowski@linaro.org>
From:   Dinh Nguyen <dinguyen@kernel.org>
In-Reply-To: <20221125144236.477416-2-krzysztof.kozlowski@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/25/22 08:42, Krzysztof Kozlowski wrote:
> The node names should be generic and DT schema expects certain pattern:
> 
>    socfpga_arria5_socdk.dtb: leds: 'hps0', 'hps1', 'hps2', 'hps3' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>   arch/arm/boot/dts/socfpga_arria5_socdk.dts          | 8 ++++----
>   arch/arm/boot/dts/socfpga_cyclone5_de0_nano_soc.dts | 2 +-
>   arch/arm/boot/dts/socfpga_cyclone5_socdk.dts        | 8 ++++----
>   3 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/socfpga_arria5_socdk.dts b/arch/arm/boot/dts/socfpga_arria5_socdk.dts
> index 7f5458d8fccc..c48385702a85 100644
> --- a/arch/arm/boot/dts/socfpga_arria5_socdk.dts
> +++ b/arch/arm/boot/dts/socfpga_arria5_socdk.dts
> @@ -29,22 +29,22 @@ aliases {
>   
>   	leds {
>   		compatible = "gpio-leds";
> -		hps0 {
> +		led-hps0 {
>   			label = "hps_led0";
>   			gpios = <&porta 0 1>;
>   		};
>   
> -		hps1 {
> +		led-hps1 {
>   			label = "hps_led1";
>   			gpios = <&portb 11 1>;
>   		};
>   
> -		hps2 {
> +		led-hps2 {
>   			label = "hps_led2";
>   			gpios = <&porta 17 1>;
>   		};
>   
> -		hps3 {
> +		led-hps3 {
>   			label = "hps_led3";
>   			gpios = <&porta 18 1>;
>   		};
> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_de0_nano_soc.dts b/arch/arm/boot/dts/socfpga_cyclone5_de0_nano_soc.dts
> index c8f051fb2bf6..bedf577cb056 100644
> --- a/arch/arm/boot/dts/socfpga_cyclone5_de0_nano_soc.dts
> +++ b/arch/arm/boot/dts/socfpga_cyclone5_de0_nano_soc.dts
> @@ -33,7 +33,7 @@ regulator_3_3v: regulator {
>   
>   	leds {
>   		compatible = "gpio-leds";
> -		hps0 {
> +		led-hps0 {
>   			label = "hps_led0";
>   			gpios = <&portb 24 0>;
>   			linux,default-trigger = "heartbeat";
> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts
> index b2241205c7a9..c7f5fa0ba0f2 100644
> --- a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts
> +++ b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts
> @@ -29,22 +29,22 @@ aliases {
>   
>   	leds {
>   		compatible = "gpio-leds";
> -		hps0 {
> +		led-hps0 {
>   			label = "hps_led0";
>   			gpios = <&portb 15 1>;
>   		};
>   
> -		hps1 {
> +		led-hps1 {
>   			label = "hps_led1";
>   			gpios = <&portb 14 1>;
>   		};
>   
> -		hps2 {
> +		led-hps2 {
>   			label = "hps_led2";
>   			gpios = <&portb 13 1>;
>   		};
>   
> -		hps3 {
> +		led-hps3 {
>   			label = "hps_led3";
>   			gpios = <&portb 12 1>;
>   		};


Both patches applied!

Thanks,
Dinh