Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 30 Nov 2022 14:57:59 +0000
From:   Mark Brown <broonie@kernel.org>
To:     "A. Sverdlin" <alexander.sverdlin@siemens.com>
Cc:     linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Linus Walleij <linus.walleij@linaro.org>,
        Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH] spi: spidev: mask SPI_CS_HIGH in SPI_IOC_RD_MODE
Message-ID: <Y4dvdzVQZDEt09+p@sirena.org.uk>
References: <20221130143948.426640-1-alexander.sverdlin@siemens.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="dzZ2XdGmVBkCOrh6"
Content-Disposition: inline
In-Reply-To: <20221130143948.426640-1-alexander.sverdlin@siemens.com>
Precedence: bulk


--dzZ2XdGmVBkCOrh6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Nov 30, 2022 at 03:39:48PM +0100, A. Sverdlin wrote:

>  	/* read requests */
>  	case SPI_IOC_RD_MODE:
> -		retval = put_user(spi->mode & SPI_MODE_MASK,
> -					(__u8 __user *)arg);
> +		tmp = spi->mode;
> +
> +		{
> +			struct spi_controller *ctlr = spi->controller;
> +
> +			if (ctlr->use_gpio_descriptors && ctlr->cs_gpiods &&
> +			    ctlr->cs_gpiods[spi->chip_select])
> +				tmp &= ~SPI_CS_HIGH;
> +		}
> +
> +		retval = put_user(tmp & SPI_MODE_MASK, (__u8 __user *)arg);
>  		break;
>  	case SPI_IOC_RD_MODE32:
>  		retval = put_user(spi->mode & SPI_MODE_MASK,

What about SPI_IOC_RD_MODE_32?  On the write path the code is shared...

--dzZ2XdGmVBkCOrh6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmOHb3YACgkQJNaLcl1U
h9CQJgf/daoxEQABFU5PoGFf/jNfQvZzeIJqAAztUAaw61V0mVzndC36v23iuL3V
Fj1dBlPh1oZ/e+rDgTS6kJVdYhsnQK0z8hCDSHvBcFclBWfmT1SnMehlN0913sQ7
GU1m/2xnDv8OVis3SY6SYpK4lcRgM6Dn97JO1JtMu9PXCg56bTfSSE/WGnZSahtN
BOGXweozbj3VWmq/IIUWa1stWGMPsfU+3Rtg5dIXOUU52knv2Q7rTnX1u50x0RgA
7ND0EqaR8EL7MlPl85SRRQ1BKbbOF1RZWAwLtGqwYnfzldZLoDjZPdZ6BG5I/yVQ
h5JIsT4eVW0JMEsu8jhk9R6w84KwMg==
=XgeV
-----END PGP SIGNATURE-----

--dzZ2XdGmVBkCOrh6--