Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2527007rwb; Wed, 30 Nov 2022 07:41:11 -0800 (PST) X-Google-Smtp-Source: AA0mqf7AEgHHuq2MnDfzPQfWib48xLAiC1j3VdiCeNuML7+mXlD6DPP5VWstdstQ4qDzjdy7ZVbA X-Received: by 2002:a17:906:3c12:b0:7ad:7e81:1409 with SMTP id h18-20020a1709063c1200b007ad7e811409mr52865128ejg.326.1669822871735; Wed, 30 Nov 2022 07:41:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669822871; cv=none; d=google.com; s=arc-20160816; b=WX5kKkJ0QGaikMFYq+bR685fexy6C1+hl2qCWkS9vRwqyOIjw/98Nde2xnZZYgzf+5 aM5NUQY6BE+AJ6Ymwqhq3eH0uSJs7XvHJpDc0Shpjn/zOtJXF+OsWlmOTk1hpuKjkyd0 qaSB8SC6Ehh9WAsDuXq1DB0ETs4bFzj81SDO9xsDAQFyPFF61hfM7egu3DpMJrv3FAmD 3FcBlsvMVTv7sQvXE7OQeiJwL+cJf0//Irkd3K8FnisDwh7uyZDaeQn0VcMsHHK2tuim Ckf/KKyDvsshWN6U3R8J97JjnyT1Wtu3MAULLzn3LKYBHCeigPhnRefEr4ly0VdqWK0w n34g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=hawNiGlCtzlPbrpiS85xbPkk5wst6Kv4FnQMrTfD5Oo=; b=TRBx3SLbiWii91jXDTlVOo4qa4C1LD+NBUnBPskmK7XRIZSWFigAJLmVW4ZxtKjBAi /tl5ec/Z580zLUMfr+Eehk+BolSCGxfCWIh75wNiuXr9isgd64ZJszQjfcwruP4/UC+5 htZeIqChf+We752MpKc+OgRNQMpwz/MODh+4uiHS8bygCcPsBUrXFcEjiqCRBN1/LcFs 7AKzoICKMUSvtGiERzODUm9d/qY53FqqdM4iVyOb1n6JMrGmiyMb6FUMiTSpjx1J7KzI bxttlggmomaSvqNJukHeHXXrwC+SQOaX76f8CrPIj6dbjAuReYq7aSQVDfJRshXxP8vx jfvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=t1oQij+R; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cf20-20020a170906b2d400b0078e1e77f443si1102916ejb.418.2022.11.30.07.40.50; Wed, 30 Nov 2022 07:41:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=t1oQij+R; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229910AbiK3PaB (ORCPT + 83 others); Wed, 30 Nov 2022 10:30:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229870AbiK3P36 (ORCPT ); Wed, 30 Nov 2022 10:29:58 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E544537E0 for ; Wed, 30 Nov 2022 07:29:55 -0800 (PST) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1669822193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hawNiGlCtzlPbrpiS85xbPkk5wst6Kv4FnQMrTfD5Oo=; b=t1oQij+RMdPhxm5R/tOuxXVA1Qn9l6vSpLsGNjxHaWs0VmBU6soaboEv54cr5eqnXvuyw/ qqwKWmgygTbCv+8TlhISSEwzVP6R9gRRH1oUPDzbLSvvGQMnJF/Mc0RiI3/inSQkjU6EEl UuXN87yFyLWAghpoR+8u3P/Ol92urMA9NwaHhX69GLQzbyKLH9JO/bK75Yo8iLtyxlFHfr f/Fq/u+jLDO3jqHyXPLJbn5uNOkLzvOm8ttQjA+qm2lG5VYUmB78RVVDGxLoCuUZFDkcPS sdZT6hf3Xj9jm2LiGHDKncSRZbxET3bykorZHJUOi1aqXWNy7Jo6ocSXz/8HGA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1669822193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hawNiGlCtzlPbrpiS85xbPkk5wst6Kv4FnQMrTfD5Oo=; b=aR2w1zintC6AmJ45sscxSsf+n7s9tReVK44wAKqS6gNTvk/bQgVBjeH3vx1Fswl9Ws+TOI 6/yGn/F0O2a32rCw== To: Samuel Holland , Marc Zyngier , Palmer Dabbelt Cc: linux-riscv@lists.infradead.org, Samuel Holland , Paul Walmsley , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] genirq: Simplify cond_unmask_eoi_irq() In-Reply-To: <87edtkts5p.ffs@tglx> References: <20221126234134.32660-1-samuel@sholland.org> <20221126234134.32660-2-samuel@sholland.org> <87edtkts5p.ffs@tglx> Date: Wed, 30 Nov 2022 16:29:52 +0100 Message-ID: <87a648tq8f.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 30 2022 at 15:48, Thomas Gleixner wrote: > On Sat, Nov 26 2022 at 17:41, Samuel Holland wrote: >> + (desc->istate & IRQS_ONESHOT) && !desc->threads_oneshot) >> unmask_irq(desc); > > This breaks the mask logic of handle_fasteoi_mask_irq() for an interrupt > which does not have IRQS_ONESHOT set. Ignore this one. That handler is broken by design.